how to make make fast my code in c#

venkat

9y1.1kVisual Basic .NET

Hi All,

i am uploading one excel file . file contains 5k Records .

it is taking around 29 minutes. how to make a fast .could please any one help?

below is my code.

Parallel.For(0, requests.Count, new ParallelOptions { MaxDegreeOfParallelism = 10 }, i =>

{

string s = requests[i].LdcName;

try

{

Utility utility = GetUtilities(client).FirstOrDefault(x => x.DEAbbreviation == requests[i].LdcName);

requests[i].LdcName = utility != null ? utility.Abbreviation : s;

client.PutUsageRequest(requests[i]);

statuses.Add(MapRequestToStatus(requests[i], true, SUCCESS_STATUS, i + 2));

}

catch (Exception ex)

{

//Report to the UI the provided ldc name

requests[i].LdcName = s;

statuses.Add(MapRequestToStatus(requests[i], false, ex.Message, i + 2));

}

});

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Tapan Patel9y ago
Well, I am not sure what exactly you are doing but as per my understanding, you are accessing/updating non-thread safe variable request to update LcdName property "requests[i].LdcName = utility != null ? utility.Abbreviation : s;".

That could be the reason for huge delay in overall operation. It actually blocks other threads from accessing request list which is defined outside Parallel.Foreach loop (making it non-thread safe). And there would be temporary deadlock sort of situation.

solution would be to loop through these request (in addtional loop -foreach or for ) before doing parallel.foreach and only update name property for each request and then run Parallel.foreach to send out request (considering the server or app that is uploading data is able to handle the Multiple requests at the same time).
Nilesh Shah9y ago
still not able to understand what you are doing

but based on my experience in solving similar problem with excel, I suggest you don't do operation row by row i.e. do bulk operation

I wanted to store 20k + excel rows in SQL Server dB and was doing it row by row using EF, it was taking nearly 30 minutes

then I changed my approach, made a string together out of all rows, passed it to SP

and in SP did the row seperation, then inserted in bulk, the operation was finished in 15 secs.

similarly you can send rows in bulk in one piece, on the other side you have to implement logic to preocess that rows collection
venkat9y ago
Hi Nilesh,
I need to upload one excel file . that excel file contains 5k records.for uploading and response it is taking nearly 40 minutes. so i need to reduce the time . for this i used below code. please help me.

var requests = new List();
var statuses = new List();
if (file != null)
{
var excel = new SLDocument(file.InputStream, WORKSHEET_NAME);
SLWorksheetStatistics stats = excel.GetWorksheetStatistics();
//We want to start on the second row as the first is headers
for (var row = stats.StartRowIndex + 1; row <= stats.NumberOfRows; row++)
{
//Convert the file to the PutUsageRequest object
var usageRequest = GetPutUsageRequestFromRow(excel, row, user);
if (usageRequest != null)
{
//Check to make sure that they have the required information as NumberOfRows could think
//there are more rows modified than actually are
if (!string.IsNullOrEmpty(usageRequest.LdcName) &&
!string.IsNullOrEmpty(usageRequest.AccountNumber) &&
!string.IsNullOrEmpty(usageRequest.Customer.CompanyName))
{
requests.Add(usageRequest);
}
else
{
statuses.Add(MapRequestToStatus(usageRequest, false, MISSING_VITAL_INFO_STATUS, row));
}
}
}
//We aren't saving this excel so we only care about closing
excel.CloseWithoutSaving();
using (var client = new HistoricalUsageDataServiceClient())
{
Parallel.For(0, requests.Count, new ParallelOptions { MaxDegreeOfParallelism = 10 }, i =>
{
string s = requests[i].LdcName;
try
{
Utility utility = GetUtilities(client).FirstOrDefault(x => x.DEAbbreviation == requests[i].LdcName);
requests[i].LdcName = utility != null ? utility.Abbreviation : s;
client.PutUsageRequest(requests[i]);
statuses.Add(MapRequestToStatus(requests[i], true, SUCCESS_STATUS, i + 2));
}
catch (Exception ex)
{
//Report to the UI the provided ldc name
requests[i].LdcName = s;
statuses.Add(MapRequestToStatus(requests[i], false, ex.Message, i + 2));
}

});

}
}
else
{
statuses.Add(new MultipleUsageRequestModel.UsageRequestStatus()
{
IsSuccess = false
,
Row = 1
,
StatusMessage = NO_FILE_SELECTED_STATUS
});
}
return statuses.OrderBy(x => x.Row);
Nilesh Shah9y ago
It is not clear by your code that what means "uploading one excel file"

are you reading contents of an excel file and posting its records one by one to some URL?

or do you want to save all records to DB?

You may need to change approach based on your requirement