I am beginner in ASP.Net Core. I got the following way to develop. Can anybody please check my code for Dropdown, Logged In user checking and View? And let me know if I am doing this with a Standard way?

Controller :

using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Mvc.Rendering;
using Microsoft.EntityFrameworkCore;
using test.Data;
using test.Models;

namespace test.Controllers
{
    public class JobsController : Controller
    {
        private readonly testContext _context;

        public JobsController(testContext context)
        {
            _context = context;
        }

        // GET: Jobs
        public async Task Index()
        {
            var testContext = _context.Jobs.Include(j => j.Clients).Include(j => j.Locations);
            return View(await testContext.ToListAsync());
        }

        // GET: Jobs/Details/5
        public async Task Details(long? id)
        {
            if (id == null)
            {
                return NotFound();
            }

            var jobs = await _context.Jobs
                .Include(j => j.Clients)
                .Include(j => j.Locations)
                .FirstOrDefaultAsync(m => m.JobID == id);
            if (jobs == null)
            {
                return NotFound();
            }

            return View(jobs);
        }

        // GET: Jobs/Create
        public IActionResult Create()
        {
            ViewData["ClientID"] = new SelectList(_context.Clients, "ClientID", "Address");
            ViewData["LocationID"] = new SelectList(_context.Locations, "LocationID", "LocationID");
            return View();
        }

        // POST: Jobs/Create
        // To protect from overposting attacks, please enable the specific properties you want to bind to, for
        // more details see http://go.microsoft.com/fwlink/?LinkId=317598.
        [HttpPost]
        [ValidateAntiForgeryToken]
        public async Task Create([Bind("JobID,LocationID,ClientID,ClientContactName,ClientEmail,JobDescription,JobNo,JobCode,CreatedBy,CreatedOn")] Jobs jobs)
        {
            if (ModelState.IsValid)
            {
                _context.Add(jobs);
                await _context.SaveChangesAsync();
                return RedirectToAction(nameof(Index));
            }
            ViewData["ClientID"] = new SelectList(_context.Clients, "ClientID", "Address", jobs.ClientID);
            ViewData["LocationID"] = new SelectList(_context.Locations, "LocationID", "LocationID", jobs.LocationID);
            return View(jobs);
        }

        // GET: Jobs/Edit/5
        public async Task Edit(long? id)
        {
            if (id == null)
            {
                return NotFound();
            }

            var jobs = await _context.Jobs.FindAsync(id);
            if (jobs == null)
            {
                return NotFound();
            }
            ViewData["ClientID"] = new SelectList(_context.Clients, "ClientID", "Address", jobs.ClientID);
            ViewData["LocationID"] = new SelectList(_context.Locations, "LocationID", "LocationID", jobs.LocationID);
            return View(jobs);
        }

        // POST: Jobs/Edit/5
        // To protect from overposting attacks, please enable the specific properties you want to bind to, for
        // more details see http://go.microsoft.com/fwlink/?LinkId=317598.
        [HttpPost]
        [ValidateAntiForgeryToken]
        public async Task Edit(long id, [Bind("JobID,LocationID,ClientID,ClientContactName,ClientEmail,JobDescription,JobNo,JobCode,CreatedBy,CreatedOn")] Jobs jobs)
        {
            if (id != jobs.JobID)
            {
                return NotFound();
            }

            if (ModelState.IsValid)
            {
                try
                {
                    _context.Update(jobs);
                    await _context.SaveChangesAsync();
                }
                catch (DbUpdateConcurrencyException)
                {
                    if (!JobsExists(jobs.JobID))
                    {
                        return NotFound();
                    }
                    else
                    {
                        throw;
                    }
                }
                return RedirectToAction(nameof(Index));
            }
            ViewData["ClientID"] = new SelectList(_context.Clients, "ClientID", "Address", jobs.ClientID);
            ViewData["LocationID"] = new SelectList(_context.Locations, "LocationID", "LocationID", jobs.LocationID);
            return View(jobs);
        }

        // GET: Jobs/Delete/5
        public async Task Delete(long? id)
        {
            if (id == null)
            {
                return NotFound();
            }

            var jobs = await _context.Jobs
                .Include(j => j.Clients)
                .Include(j => j.Locations)
                .FirstOrDefaultAsync(m => m.JobID == id);
            if (jobs == null)
            {
                return NotFound();
            }

            return View(jobs);
        }

        // POST: Jobs/Delete/5
        [HttpPost, ActionName("Delete")]
        [ValidateAntiForgeryToken]
        public async Task DeleteConfirmed(long id)
        {
            var jobs = await _context.Jobs.FindAsync(id);
            _context.Jobs.Remove(jobs);
            await _context.SaveChangesAsync();
            return RedirectToAction(nameof(Index));
        }

        private bool JobsExists(long id)
        {
            return _context.Jobs.Any(e => e.JobID == id);
        }
    }
}

View :

Create:

@model test.Models.Jobs

@{
ViewData["Title"] = "Create";
}

Create

Jobs

Back to List

@section Scripts {
@{await Html.RenderPartialAsync("_ValidationScriptsPartial");}
}

Edit:

@model test.Models.Jobs

@{
ViewData["Title"] = "Edit";
}

Edit

Jobs

Back to List

@section Scripts {
@{await Html.RenderPartialAsync("_ValidationScriptsPartial");}
}

Model:

using System;
using System.Collections.Generic;
using System.ComponentModel.DataAnnotations;
using System.ComponentModel.DataAnnotations.Schema;
using System.Linq;
using System.Threading.Tasks;

namespace test.Models
{
    [Table("Jobs")]
    public class Jobs
    {
        [Key]
        public long JobID { get; set; }

        [Required(ErrorMessage = "Please select location")]
        [Display(Name = "Location Name")]
        public Guid LocationID { get; set; }

        [Required(ErrorMessage = "Please select client")]
        [Display(Name = "Client Name")]
        public long ClientID { get; set; }

        [Display(Name = "Client Contact Name")]
        [Required(ErrorMessage = "Please enter client contact name")]
        [MaxLength(50, ErrorMessage = "Please enter client contact name less than {1}")]
        [RegularExpression(@"^\s*[A-z]+[\s[A-z]*]*$", ErrorMessage = "Please enter character only")]
        public string ClientContactName { get; set; }

        [Required(ErrorMessage = "Please enter client email")]
        [EmailAddress(ErrorMessage = "Please enter valid email")]
        [Display(Name = "Client Email")]
        [MaxLength(50, ErrorMessage = "Please enter client email less than {1}")]
        public string ClientEmail { get; set; }

        [Display(Name = "Job Description")]
        [Required(ErrorMessage = "Please enter job description")]
        [DataType(DataType.MultilineText)]
        [MaxLength(2000, ErrorMessage = "Please enter job description less than {1}")]
        public string JobDescription { get; set; }

        [Display(Name = "Job Number")]
        public long JobNo { get; set; }

        [Display(Name = "Job Code")]
        public string JobCode { get; set; }

        [Display(Name = "Created By")]
        public Guid CreatedBy { get; set; }

        [Display(Name = "Created On")]
        public DateTime CreatedOn { get; set; }

        [ForeignKey("ClientID")]
        public virtual Clients Clients { get; set; }

        [ForeignKey("LocationID")]
        public virtual Locations Locations { get; set; }

    }
}

1 Reply

Know the answer? Post it — somebody with the same question will find it here.

Rajanikant Hawaldar6y ago
Hi Refer this link there many articles and blogs are written by senior developers, you can go through code how they are written so that it will help you to improve your code yourself. https://www.c-sharpcorner.com/technologies/Asp-Net-core

ASP .NET Core Coding Standard

Create

Jobs

Edit

Jobs