c# best coding pattern

Hi ,

I would like to know , which is the best way to do in a situation am facing now . Actually issue is a simple one and have the solution for that . But to know , which is the best . That's why am posting here .

I have a simple method . In the method , i want to set for 2 arguements accotding to the situation . Situation can solve , if it implement it in 2 methods . But i want to know , is there any other way to do it as a part of optimizing the code . here is my code .

//EncoderParamters is a class .

private EncoderParameters encoderparam = GetEncoderParameters();

//Method definition .

private static EncoderParameters GetEncoderParameters()

{

myencoderparameters.Param[1] = new EncoderParameter(System.Drawing.Imaging.Encoder.Compression, (long)EncoderValue.CompressionCCITT4);

return myencoderparameters;

}

In the method , i have to set for 2 arguements when it comes for CCITT4 and CCITLWZ . Currently it is set for CCITT4 . but a situation will come the same method need to call for CCITLWZ compression .

//Method call area .

resultBitmap.Save(newImageName, this.imagecodec, this.encoderparam);

We are going to have a step the same save method , but when call this.encoderparam , it should execute the method GetEncoderParameters() with the second arguement . I know that , if we do in another method and call . Also can set a parameter says bool, string and all , we can do it in that way also . I need to know , accepting the c# coding principle , is there any best way to handle this situation ?

Advance Thanks

Xavi

If you're going to be switching between CCITT4 and CCITLWZ in the same application, I'd cache the corresponding EncoderParameter objects in static fields so you don't have to keep creating new objects on each switch.

However, I wouldn't then cache the EncoderParameters object as well - I'd just call the GetEncoderParameters() method each time you need it with a bool argument to indicate which basis is required.

So you'd then have:

// field definitions

private static EncoderParameter _CCITT4 = new EncoderParameter(System.Drawing.Imaging.Encoder.Compression, (long)EncoderValue.CompressionCCITT4);

private static EncoderParameter _CCITLWZ = new EncoderParameter(System.Drawing.Imaging.Encoder.Compression, (long)EncoderValue.CompressionCCITLWZ);

//Method definition .

private static EncoderParameters GetEncoderParameters(bool useCCITT4)

{

if (useCCITT4)

{

myencoderparameters.Param[1] = _CCITT4;

}

else

{

myencoderparameters.Param[1] = _CCITLWZ;

}

return myencoderparameters;

}

//Method call area if using CCITT4

resultBitmap.Save(newImageName, this.imagecodec, GetEncoderParameters(true));

// or if using CCITLWZ

resultBitmap.Save(newImageName, this.imagecodec, GetEncoderParameters(false));

1 Reply

Know the answer? Post it — somebody with the same question will find it here.

Vulpes11y ago
Accepted answer
If you're going to be switching between CCITT4 and CCITLWZ in the same application, I'd cache the corresponding EncoderParameter objects in static fields so you don't have to keep creating new objects on each switch.

However, I wouldn't then cache the EncoderParameters object as well - I'd just call the GetEncoderParameters() method each time you need it with a bool argument to indicate which basis is required.

So you'd then have:

// field definitions

private static EncoderParameter _CCITT4 = new EncoderParameter(System.Drawing.Imaging.Encoder.Compression, (long)EncoderValue.CompressionCCITT4);

private static EncoderParameter _CCITLWZ = new EncoderParameter(System.Drawing.Imaging.Encoder.Compression, (long)EncoderValue.CompressionCCITLWZ);

//Method definition .
private static EncoderParameters GetEncoderParameters(bool useCCITT4)
{
if (useCCITT4)
{
myencoderparameters.Param[1] = _CCITT4;
}
else
{
myencoderparameters.Param[1] = _CCITLWZ;
}

return myencoderparameters;
}

//Method call area if using CCITT4
resultBitmap.Save(newImageName, this.imagecodec, GetEncoderParameters(true));

// or if using CCITLWZ
resultBitmap.Save(newImageName, this.imagecodec, GetEncoderParameters(false));