Can anyone see anything wrong with coding for a simple hangman game?

static void HangmanEasy()

{

List word = new List();

word.Add("ABLE");

word.Add("ACHE");

word.Add("ACID");

word.Add("AERO");

word.Add("AFRO");

word.Add("AUTO");

word.Add("BABE");

word.Add("BAKE");

word.Add("BALD");

word.Add("BALL");

word.Add("BAND");

word.Add("BANG");

word.Add("BANK");

word.Add("BARK");

word.Add("BARN");

word.Add("BASE");

word.Add("BASS");

word.Add("BATH");

word.Add("BEAR");

word.Add("BEER");

word.Add("BIKE");

word.Add("BITE");

word.Add("BIRD");

word.Add("BODY");

word.Add("BOMB");

word.Add("BURN");

word.Add("BUSH");

word.Add("CAFE");

word.Add("CAKE");

word.Add("CALM");

string[] FourLetterWords = new string[word.Count];

for (int i = 0; i < word.Count; i++)

{

FourLetterWords[i] = word[i];

}

string fourWord = FourLetterWords[r.Next(1, (word.Count + 1))];

char[] letters = fourWord.ToCharArray();

string[] empty = new string[4];

for (int a = 0; a < empty.Length; a++)

{

empty[a] = "_";

}

Play:

Console.Clear();

Console.WriteLine("Choose your letters and lets play!");

Console.WriteLine("----------------------------------");

Console.WriteLine("");

Console.WriteLine(" " + empty[0] + " " + empty[1] + " " + empty[2] + " " + empty[3]);

Console.WriteLine("");

string letterChoice = Console.ReadLine().ToUpper();

char[] letter = letterChoice.ToCharArray();

for (int pos = 0; pos < letters.Length; pos ++)

{

if (letters[pos] == letter[0])

{

empty[pos] = letterChoice;

goto Play;

}

else

{

goto Play;

}

First, please, please, please get rid of "goto". You never need it and 99% of programmers will never use goto in the manner you do. Your program is probably a good example of why a goto statement makes programs confusing. Look more closely at the program; the goto statement will always be executed in the first iteration of the for loop. In other words, the for statement is useless; in the for loop, pos will alwhays be zero since the goto will cause the program to get out of the for loop before the for loop increments pos.

Do you know how to use the debugger? You need to know how to use the debugger. Using the debugger to single-step through the program would help you understand what is happening and not happening.

1 Reply

Know the answer? Post it — somebody with the same question will find it here.

Sam Hobbs16y ago
First, please, please, please get rid of "goto". You never need it and 99% of programmers will never use goto in the manner you do. Your program is probably a good example of why a goto statement makes programs confusing. Look more closely at the program; the goto statement will always be executed in the first iteration of the for loop. In other words, the for statement is useless; in the for loop, pos will alwhays be zero since the goto will cause the program to get out of the for loop before the for loop increments pos.

Do you know how to use the debugger? You need to know how to use the debugger. Using the debugger to single-step through the program would help you understand what is happening and not happening.
0