Can someone tell me what's wrong with my code?

Hi All, I am new and just got an interview coding question. My code is below. The feedback was unsatisfied but I cannot see why. The code is fully tested.

Definitely need a second eye on it. Can someone tell me what's wrong with it? Thanks a bunch!

Here is the objective. And class Team is the missing class I wrote.

Implement the missing class without modifying the provided classes.

The correct output should be:

Local Boys = 6 (Home)

Tourists = 0 (Away)

Code is here:

using System;

namespace Invision.Test

{

public class Team

{

public enum FieldAdvantage { Home = 100, Away = 200 };

// declare a delegate to wire up score change event to the class

public delegate void ScoreChangeEventHandler(FieldAdvantage side, int newScore, ref bool overrule);

protected string _name;

protected FieldAdvantage _side;

protected int _score;

// declare the score change "event" which will be called whenever score value is changed

// this "event" will be set in the Referee class

public ScoreChangeEventHandler ScoreChange;

// this method will be called from the setter

// after execution, it sets the bool value passed from the caller

protected void OnScoreChanged(FieldAdvantage side, int newScore, ref bool overrule)

{

if (ScoreChange != null)

{

ScoreChange(side, newScore, ref overrule);

}

public virtual int NumPlayers

{

get { return 0; }

}

public FieldAdvantage Side

{

get { return _side; }

set { _side = value; }

}

public int Score

{

get { return _score; }

set

{

_score = value;

bool overrule = false;

OnScoreChanged(_side, _score, ref overrule);

if (overrule)

{

_score -= 100;

if (_score < 0)

_score = 0;

}

public Team(string name, FieldAdvantage side)

{

_name = name;

_side = side;

}

// override ToString method for displaying the name field

public override string ToString()

{

return _name;

}

public class FootballTeam : Team

{

public FootballTeam(string name, FieldAdvantage side)

: base(name, side)

{

}

public override int NumPlayers

{

get

{

return 11;

}

public void Touchdown()

{

// calls the setter method of property Score

Score += 6;

}

public class Game

{

public FootballTeam Home = new FootballTeam("Local Boys", Team.FieldAdvantage.Home);

public FootballTeam Away = new FootballTeam("Tourists", Team.FieldAdvantage.Away);

public static void Main()

{

Game game = new Game();

Referee referee = new Referee(game);

game.Home.Touchdown();

game.Away.Touchdown();

game.Home.Score += 100;

Console.WriteLine("{0} = {1} ({2})", game.Home, game.Home.Score, game.Home.Side.ToString());

Console.WriteLine("{0} = {1} ({2})", game.Away, game.Away.Score, game.Away.Side.ToString());

}

public class Referee

{

public Referee(Game game)

{

game.Home.ScoreChange += new Team.ScoreChangeEventHandler(OnScoreChange);

game.Away.ScoreChange += new Team.ScoreChangeEventHandler(OnScoreChange);

}

private void OnScoreChange(Team.FieldAdvantage side, int newScore, ref bool overrule)

{

if ((side == Team.FieldAdvantage.Away) || (newScore > 100))

overrule = true;

}

This is my output using your scoring logic:

Local Boys = 6 (Home)

Tourists = 0 (Away)

I made a couple of changes that to the base class and the properties (Let me know if it makes sense and it helps):

using System;

using System.Collections.Generic;

using System.Linq;

using System.Text;

namespace Test

{

static class Program

{

static void Main(string[] args)

{

FootballTeam home = new FootballTeam("Local Boys", FieldAdvantage.Home);

FootballTeam visitors = new FootballTeam("Tourists", FieldAdvantage.Away);

Referee referee = new Referee();

referee.AddTeam(home);

referee.AddTeam(visitors);

home.Touchdown();

visitors.Touchdown();

home.Score += 100;

Console.WriteLine("{0} = {1} ({2})", home.ToString(), home.Score, home.Side.ToString());

Console.WriteLine("{0} = {1} ({2})", visitors.ToString(), visitors.Score, visitors.Side.ToString());

}

public enum FieldAdvantage

{

Home = 0,

Away = 1

};

public abstract class Team

{

public delegate bool ScoreChangeEventHandler(FieldAdvantage side, int newScore);

public ScoreChangeEventHandler ScoreChange;

protected int m_score = 0;

public Team(string name, FieldAdvantage fieldAdvantage)

{

this.Name = name;

this.Side = fieldAdvantage;

}

public string Name { get; private set; }

public virtual int PlayerCount { get; set; }

public FieldAdvantage Side { get; private set; }

public int Score

{

get { return m_score; }

set

{

CalculateScore(value);

}

protected virtual void CalculateScore(int value)

{

m_score = value;

if (ScoreChange(Side, value))

{

m_score -= 100;

if (m_score < 0) m_score = 0;

}

public override string ToString()

{

return Name;

}

public class FootballTeam : Team

{

public FootballTeam(string name, FieldAdvantage side)

: base(name, side)

{

PlayerCount = 11;

}

public void Touchdown()

{

Score += 6;

}

public class Referee

{

public Referee()

{

}

public void AddTeam(FootballTeam team)

{

team.ScoreChange += new Team.ScoreChangeEventHandler(OnScoreChange);

}

private bool OnScoreChange(FieldAdvantage side, int newScore)

{

if ((side == FieldAdvantage.Away) || (newScore > 100))

return true;

else

return false;

}

1 Reply

Know the answer? Post it — somebody with the same question will find it here.

Felipe Ramos16y ago
This is my output using your scoring logic:

Local Boys = 6 (Home)
Tourists = 0 (Away)

I made a couple of changes that to the base class and the properties (Let me know if it makes sense and it helps):

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace Test
{
   static class Program
   {
   static void Main(string[] args)
   {
   FootballTeam home = new FootballTeam("Local Boys", FieldAdvantage.Home);
   FootballTeam visitors = new FootballTeam("Tourists", FieldAdvantage.Away);
   Referee referee = new Referee();
   referee.AddTeam(home);
   referee.AddTeam(visitors);

   home.Touchdown();
   visitors.Touchdown();

   home.Score += 100;

   Console.WriteLine("{0} = {1} ({2})", home.ToString(), home.Score, home.Side.ToString());
   Console.WriteLine("{0} = {1} ({2})", visitors.ToString(), visitors.Score, visitors.Side.ToString());
   }
   }

   public enum FieldAdvantage
   {
   Home = 0,
   Away = 1
   };

   public abstract class Team
   {
   public delegate bool ScoreChangeEventHandler(FieldAdvantage side, int newScore);
   public ScoreChangeEventHandler ScoreChange;
   protected int m_score = 0;

   public Team(string name, FieldAdvantage fieldAdvantage)
   {
   this.Name = name;
   this.Side = fieldAdvantage;
   }

   public string Name { get; private set; }
   public virtual int PlayerCount { get; set; }
   public FieldAdvantage Side { get; private set; }
   public int Score
   {
   get { return m_score; }
   set
   {
   CalculateScore(value);
   }
   }

   protected virtual void CalculateScore(int value)
   {
   m_score = value;

   if (ScoreChange(Side, value))
   {
   m_score -= 100;
   if (m_score < 0) m_score = 0;
   }
   }

   public override string ToString()
   {
   return Name;
   }
   }

   public class FootballTeam : Team
   {
   public FootballTeam(string name, FieldAdvantage side)
   : base(name, side)
   {
   PlayerCount = 11;
   }

   public void Touchdown()
   {
   Score += 6;
   }
   }

   public class Referee
   {
   public Referee()
   {
   }

   public void AddTeam(FootballTeam team)
   {
   team.ScoreChange += new Team.ScoreChangeEventHandler(OnScoreChange);
   }

   private bool OnScoreChange(FieldAdvantage side, int newScore)
   {
   if ((side == FieldAdvantage.Away) || (newScore > 100))
   return true;
   else
   return false;
   }
   }
}
0