filling combobox with datatable

Violeta Popa

Hi :) I'm trying to fill a combobox with a datatable, but i don't know what's wrong, because it doesn't display any item. This is the code:

SqlConnection conn = new SqlConnection();

conn.ConnectionString = "Data Source=.\\SQLEXPRESS;AttachDbFilename='C:\\Users\\Vio\\Desktop\\Gestiune asigurari auto\\Gestiune asigurari auto\\Resources\\asigurari.mdf';Integrated Security=True;Connect Timeout=30;User Instance=True";

conn.Open();

string selectClient = "SELECT * FROM client WHERE UPPER(SUBSTRING(denumire, 1, 2)) = 'RO' and tip_client='altul'";

SqlDataAdapter da = new SqlDataAdapter(selectClient, conn);

DataTable dt = new DataTable();

da.Fill(dt);

for (int i = 0; i < dt.Rows.Count; i++)

{

comboBox1.Items.Add(dt.Rows[i]["denumire"]);

}

conn.Close();

the connection works fine, i've tested it.

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Shankar M13y ago
Hi violeta,

You can use the DataSource of combobox to fill from DataTable and using the DisplayMember and ValueMember properties of the combobox.

cmb.DataSource = dt;
cmb.DisplayMember = "CODE_DESC";
cmb.ValueMember = "CODE_VAL";
Violeta Popa13y ago
thanks you guys, i fixed it!
Satyapriya Nayak13y ago
Try

string ConnectionString = System.Configuration.ConfigurationSettings.AppSettings["dsn"];
        OleDbCommand com;
        OleDbDataAdapter oda;
        DataSet ds;
        string str;

private void Form1_Load(object sender, EventArgs e)
        {
            OleDbConnection con = new OleDbConnection(ConnectionString);
            con.Open();
            str = "select * from emp";
            com = new OleDbCommand(str, con);
            oda = new OleDbDataAdapter(com);
            ds = new DataSet();
            oda.Fill(ds, "emp");
            DataTable dt = ds.Tables["emp"];
            int i;
            for (i = 0; i <= dt.Rows.Count - 1; i++)
            {
                comboBox1.Items.Add(dt.Rows[i].ItemArray[0]);
            }
            con.Close();
        }
Javeed M Shaikh13y ago
can you print what is the output in dt.Rows[i]["denumire"]

also you can try this..

foreach(DataRow row in dt.Rows)
{
comboBox1.Items.Add(row["denumire"].ToString());
}