Help: Datatable

David Smith

I miss this requriement for the value function today, How would i use the datatable and datarow in the function below. I am simply setting the int vlue

void SetValue(this DataTable datatable, DataRow datarow, string columnName, int value)
{

}

9 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes11y ago
Yes, it looks OK now.

I agree that, to be on the safe side, you're best checking that the datarow parameter isn't null.
David Smith11y ago
Ok I update the function. Is there anything wrong with the function below. Also do you reason to check for null on the datarow

       public static void SetValue(this DataTable datatable, DataRow datarow, string columnName, double value)
        {
            try
            {
                //Standard null exception
                if (datatable == null)
                    throw new ArgumentNullException("datatable", "Datatable is null.");

                //Standard null exception
                if (datarow == null)
                    throw new ArgumentNullException("datarow", "DataRow is null.");

                //Standard exception if row doesn't belong to this table
                if (!datatable.Equals(datarow.Table))
                    throw new ArgumentException("datarow", "DataRow does not belong to this DataTable.");

                //Standard out of range exception for column
                if (!datatable.Columns.Contains(columnName))
                    throw new ArgumentOutOfRangeException("columnName", "Column does not exist.");

                datarow.SetField(columnName, value);

            }
            catch (Exception ex)
            {
                throw new Exception("SetValue: \n" + ex.Message);
            }
        }
Vulpes11y ago
Oops! I meant to do:

datarow[columnName] = value;

However, you can use the SetField extension method if you like:

datarow.SetField(columnName, value);

Do you know for sure that the DataRow hasn't yet been added to the DataTable's Rows collection when this method is called?
David Smith11y ago
What do you think vuples, anything you see wrong with this below.

public static void SetValue(this DataTable datatable, DataRow datarow, string columnName, int value)
        {
            try
            {

                //Standard null exception
                if (datatable == null)
                    throw new ArgumentNullException("datatable", "Datatable is empty.");

                //Standard exception if row doesn't belong to this table
                if (!datatable.Equals(datarow.Table))
                    throw new ArgumentException("datarow", "DataRow does not belong to this DataTable.");

                //Standard out of range exception for column
                if (!datatable.Columns.Contains(columnName))
                    throw new ArgumentOutOfRangeException("columnName", "Column does not exist.");

                datarow.SetField(columnName, value);

                datatable.Rows.Add(datarow);

            }
            catch (Exception ex)
            {
                throw new Exception("SetValue: \n" + ex.Message);
            }
        }
David Smith11y ago
Vuples the function says setvalue, you are returning. Also datarow has a setfield property
Vulpes11y ago
Passing the RowIndex would have been better.

That's what you did when 'getting' the value.
David Smith11y ago
I couldnt remember why they supplied the datatable parameter and datarow parameter. I will know why later on today
Vulpes11y ago
To be consistent with the code for the GetValueInt() method in your previous thread, I'd suggest:

public static void SetValueInt(this DataTable datatable, DataRow datarow, string columnName, int value)
{
try
{
//Standard null exception
if (datatable == null)
throw new ArgumentNullException("datatable", "Datatable is null.");

//Standard exception if row doesn't belong to this table
if (!datatable.Equals(datarow.Table))
throw new ArgumentException("datarow", "DataRow does not belong to this DataTable.");

//Standard out of range exception for column
if (!datatable.Columns.Contains(columnName))
throw new ArgumentOutOfRangeException("columnName", "Column does not exist.");

return Convert.ToInt32(datarow[columnName].ToString());
}
catch (Exception ex)
{
throw new Exception("SetValueInt: \n" + ex.Message);
}
}
Joginder Banger11y ago
Hi David Smith,
i can't understand what's you try. plz explore the problem what's you try or share more code for better understand.