How to avoid compilation error when .c file is included in the vc++ project??

Karthik Agarwal

15y2.7k

Hi,

I have a .c file which is included in my vc++ solution. I called a function in the .c file from another class but if try to call the same function from another class in the same namespace its popping up lot of errors like C2011, C2084, C2086, C2296, C2370, C2372, C3861 which are compilation error identifiers.

Note: Both the classes from where i am calling the .c function are different .cpp files.

Earliest response would be appreciated. I guess the problem is, when i am trying to call the .c file for the second time the .c file is getting compiled one more time. For any doubts please post back.

26 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes15y ago
Accepted answer
As the Excel cells may contain embedded spaces or commas, then the only thing I've been able to come up with is to save the Excel file as a tab delimited file - hopefully there are no embedded tabs in the cells.

I'm not sure whether this gets saved as UTF-8 or Unicode but, whatever it is, the surplus quotes are still there.

However, we can now remove them like this:

array^ lines = File::ReadAllLines("d:\\excel files\\book1.txt");
array^ items;

for(int i = 0; i < lines->Length; i++)
{
items = lines[i]->Split('\t');
for(int j = 0; j < items->Length; j++)
{
items[j] = items[j]->Substring(1, items[j]->Length - 2); // remove outer set of double quotes
items[j] = items[j]->Replace("\"\"", "\""); // replace inner double quotes with single quotes
}
Console::WriteLine(String::Join("\t", items));
}
0
Karthik Agarwal15y ago
Ok Vulpes i agree what you said, probably from next time i will do that.
0
Vulpes15y ago
If you're asking a supplementary question which requires knowledge of the current thread to answer it, then this is best asked on the current thread.

However, if it's a totally different point, I think it should be asked on a separate thread.

Here, the Excel point has nothing to do with the original question (and turned out to be non-trivial), so I agree with Sam that it should have been asked on a separate thread. There may well be other people on the forum who have better ideas than me for solving it but who wouldn't bother reading the current thread because they'd have no idea on the original question.
0
Karthik Agarwal15y ago
Hi SamHobbs,

Probably if you look at my older posts i have posted many threads till now but i feel that the thread is major one then i have created a new thread otherwise i continued with the same thread which was active. According to me its waste to post new thread all the time if its a small problem. What do you say Vulpes?
0
Karthik Agarwal15y ago
Ok Vulpes probably this should be the best solution rather the last one.
0
Sam Hobbs15y ago
It would help very much if a new question (thread) was created for a new question (problem). It looks to me as if the initial problem is solved and there is an entirely different problem. I am not sure how much of this to read and how much to ignore. If there is an outstanding problem then it will help if a new thread was created that explained the problem.
0
Karthik Agarwal15y ago
Yup now you got it. i might get any number of double cotes which we can't predetermine or assume some number of cotes. Ok anyways i will wait for the reply as you already got what i meant?
0
Vulpes15y ago
The code works by replacing all occurrences of three consecutive double quote characters with a single double quote character.

As long as you don't actually have any occurrences of the former that you want to retain it should work fine.

EDIT:

Sorry, I misread that. So you're saying that it's not as simple as always replacing one double quote with 3 double quotes. Sometimes it'll be two and sometimes you'll get one that you didn't want at all!

I'll need to have another look at it. Will get back soonest.
0
Karthik Agarwal15y ago
I doubt how this code is gonna work bcz there are places where a cell in excel sheet contains a string as follows:

"POWER" drücken

which will be replaced as """POWER"" drücken" in the unicode file.

I am not sure how the code works. This is one of the odd examples there are many of that kind can't even expect where the cote can be and how many it can be.
0
Vulpes15y ago
I've just tried it myself and I see what you mean.

I can't find any obvious way to prevent that from Excel itself, so you'll just have to do it from VC++.

Something like this:

System::Text::Encoding^ encoding = System::Text::Encoding::Unicode;
String^ text = File::ReadAllText("d:\\excel files\\book1.txt", encoding);
Console::WriteLine(text); // contains triple quotes
text = text->Replace("\"\"\"", "\""); // replace them with single quotes
Console::WriteLine(text); // check it worked
File::WriteAllText("d:\\excel files\\book1.txt", text, encoding); // resave
text = File::ReadAllText("d:\\excel files\\book1.txt", encoding);
Console::WriteLine(text); // OK now
0
Karthik Agarwal15y ago
No Vulpes I am not working on VBA but in VC++. In order to use the excel sheet in VC++ i have saved the excel sheet in unicode format which is .txt extension. How can i avoid this double cote problem in VC++ it can even be in the coding side as well.

Note: I want to avoid the double cotes which excel is adding automatically while converting to unicode format.
0
Vulpes15y ago
If you wanted to express this string: "text" (including the quotes) in Excel VBA, you'd have to 'escape' the quotes by doubling them: ""text""

So, as a VBA string literal it would be:

Dim s As String = """text"""

It sounds to me as though the problem is related to that.

What are you doing here, exporting a .csv file to Excel and then resaving it in spreadsheet form?
0
Karthik Agarwal15y ago
Ok Vulpes.

I have a excel file with Unicode content of which some cells are contains text inside double cotes i.e "text". but when i save the excel file in Unicode format the text which contains single double cote is showing up with three double cotes i.e """text""". How can i solve this issue. There are some places where i even have text which contains comma (,) i.e text, which is converted into "text," in the Unicode file i.e it is adding double cote the text which contains special characters i guess. How can i avoid this kind of stuff may be if i can avoid it in the coding also its ok?
0
Vulpes15y ago
It does no harm but, you're right, you don't really need to repeat it.
0
Karthik Agarwal15y ago
I need not write extern "C" in the below line i guess

extern "C" void process(int count);

as it's already there in the below line.

#ifdef __cplusplus
extern "C" {
#endif

What do you say Vulpes?
0
Vulpes15y ago
Yes, it will give you duplicate defintions errors if write #include "name.c" in the second file as well as the first but, if the #define is working OK, then I'd stick with that.
0
Karthik Agarwal15y ago
This way i tried vulpes which still shows some errors, but all the errors disappeared using the following way but i am not sure whether that's correct or not.

#ifdef __cplusplus
extern "C" {
#endif

#ifndef NAME_C        .........1
#define NAME_C        .........2
#endif                     .........3

    extern "C" void process(int count);

#ifdef __cplusplus
}
#endif

I wrote the above code in second file which cleared all the issues
But if i write #include "name.c" instead of the lines 1,2 and 3 then its still popping most of the errors like C2084, C3861, C2086, C2011, C2296, C2371 and C2370
0
Vulpes15y ago
OK, I've just modelled the situation as follows in a CLR console app and in fact you shouldn't need to use #pragma once at all:

// first.cpp : main project file.

#include "stdafx.h"

#ifdef __cplusplus
extern "C" {
#endif

#include "name.c"

#ifdef __cplusplus
}
#endif

void SomeFunction(); // forward declaration

using namespace System;

int main(array ^args)
{
process(3);
Console::WriteLine();
SomeFunction();
Console::ReadKey();
return 0;
}

// second.cpp
#include "stdafx.h"

extern "C" void process(int count); // forward declaration

using namespace System;

void SomeFunction()
{
process(4);
}

// name.c

#include

extern "C" void process(int count)
{
printf("%s %d", "Hello from process with count = ", count);
}

This built and ran fine with the output, as expected, being:

Hello from process with count = 3
Hello from process with count = 4
0
Karthik Agarwal15y ago
I have one .cpp file where .c file has been already included as follows:

#ifdef __cplusplus
extern "C" {
#endif

#include "name.c"

#ifdef __cplusplus
}
#endif

and a function in the .c file which has been declared as follows in .cpp file:

extern "C" void process(int count);

and has been called as follows:
bidi_process(count);

Now what i want to call the same function in the .c file from another .h file.
So how can i do that?
Any more doubts please post back.
0
Vulpes15y ago
It's very difficult to say without seeing some code.

Can you post an outline (not all of it) so I can get an idea.
0
Karthik Agarwal15y ago
I have included #pragma once included in the code even before you told me.
If i have to keep it as it is and want to avoid those errors what should i be doing???
0
Vulpes15y ago
I'm getting the impression, Karthik, that we may be at cross purposes here ;)

Are you saying that:

1. You'd already included #pragma once but were still getting all those errors.

2. You hadn't included #pragma once but, when you did, you still got the same errors?
0
Karthik Agarwal15y ago
Then how about the errors i am getting, how can i avoid them?
0
Vulpes15y ago
You need to compile with #pragma once included in the source code to avoid the file being loaded more than once.
0
Karthik Agarwal15y ago
If i want to compile do i need to remove #pragma once or else is there any other way to do that?
0
Vulpes15y ago
It sounds like a duplicate definition error.

If you use the following preprocessor directive:

#pragma once

it will ensure the .c file is only included once by the VC++ compiler.
0