How to compare the tag of HTML files in C++?

Please don't be upset, I always respect your knowledge and your personality , because You have done uncountable favor to me, so I am so sorry that I made you angry.

Vulpes11y ago

If you're saying that the code I gave you for redirecting console output to a file doesn't work, then all I can say is that it worked fine when I tried it myself.

I don't see how you can calculate the weight of the edges earlier as you don't know what the relevant variables are going to be until you've done a full comparison between each pair of files.

Although 9 minutes may seem like a long time to run the program, it's considerably better than it looked like it was going to be at first when I thought it might take several hours to run!

Anyway there's nothing to stop you trying other approaches to speed it up some more.

As far as I'm concerned I've given you some reasonable working code for this and so this will be my final post on the thread.

Joe Wilson11y ago

Well,do you mean is it good that it takes 9 min to run the program,and your suggestion about pausing the console didn't work, by the way, do you think if the process of calculating the weight of the edges , it would be run earlier or not?

Vulpes11y ago

Rather than printing stuff to the console I'd redirect it to a file. You won't then need to worry about pausing the console.

If you make the highlighted alterations to the main function it will redirect to a file called output.txt which you can open with notepad and inspect at your leisure:

// check it worked

// redirect standard output to a file

freopen("output.txt", "w", stdout);

cout << "The list contains" << endl << endl;

for(nit = nodes.begin(); nit != nodes.end(); nit++) // iterate through nodes vector

{

cout << nit->file1 << ", " << nit->file2 << ", " << nit->f << endl;

}

// add to graph

Graph G(nodes.size(), false);

for(nit = nodes.begin(); nit != nodes.end(); nit++)

{

G.insert(nit->file1, nit->file2, nit->f);;

}

cout << endl << "The graph contains" << endl << endl;

G.show();

fclose(stdout);

return 0;

}

I have wondered before about using a hash-table approach but, if it does so at all, I doubt whether it will improve performance enough to be worth the effort of rewriting the program.

If you've managed to get the running time down to 6 to 10 minutes on an i7 machine I think that's a pretty good result :)

Joe Wilson11y ago

Oh, It takes about 6 to 10 min to run the program, and by the way, I don't understand where I should use system("pause") , What is your opinion about using hash while finding the strings in order to decrease time complexity ?

Vulpes11y ago

Here's a list of all 209 files to paste into files.csv:

10072.csv

10105.csv

10107.csv

10108.csv

10128.csv

1014691.csv

10151.csv

1029.csv

1051327.csv

1060.csv

106587.csv

1116874.csv

113.csv

1133624.csv

115.csv

1182675.csv

1182694.csv

1182710.csv

1182718.csv

1182720.csv

11837.csv

11862.csv

11883.csv

1222607.csv

12349.csv

12466.csv

12491.csv

1386651.csv

1391550.csv

14710.csv

1472.csv

1473.csv

1477.csv

1479.csv

1495.csv

1500.csv

1507.csv

1512.csv

1525.csv

1526.csv

1527.csv

1534.csv

1537.csv

1538.csv

1541442.csv

1549.csv

15540.csv

1577.csv

1586826.csv

1588.csv

1590.csv

1638.csv

1653.csv

1667444.csv

167585.csv

1729243.csv

173670.csv

1748.csv

1769540.csv

17728.csv

1812.csv

19036.csv

19485.csv

1977.csv

1994.csv

20410.csv

2122992.csv

2150.csv

2152.csv

2182.csv

2184.csv

2199.csv

2204.csv

2215.csv

2225.csv

2228.csv

2236.csv

2264.csv

2280068.csv

22957.csv

22986.csv

2299193.csv

23107.csv

2340.csv

2348.csv

2449742.csv

2475502.csv

2480465.csv

2492277.csv

2567.csv

2575.csv

25918.csv

2619901.csv

2704.csv

2718.csv

2742161.csv

2770499.csv

2770555.csv

2773690.csv

283.csv

29144.csv

2930.csv

29374.csv

2964.csv

3032251.csv

3045.csv

3067.csv

3092.csv

3093889.csv

3123767.csv

3167566.csv

3181280.csv

3203319.csv

3203347.csv

3203350.csv

3203356.csv

3206242.csv

3207.csv

3253.csv

3261.csv

3359.csv

3373.csv

33867.csv

34878.csv

3488194.csv

3514.csv

3577382.csv

364.csv

3654.csv

3657.csv

3728592.csv

3745066.csv

39272.csv

393681.csv

3962.csv

4041453.csv

4044.csv

4053418.csv

4131.csv

4183.csv

4248.csv

4307.csv

43191.csv

44123.csv

4432994.csv

4479754.csv

4679.csv

4890.csv

4921.csv

4931.csv

4933.csv

4936.csv

4948864.csv

4979986.csv

5057.csv

5061284.csv

5068.csv

5072307.csv

5104.csv

5115.csv

5174.csv

5189.csv

5197633.csv

522063.csv

5276341.csv

5403381.csv

5448.csv

55332.csv

5537.csv

5794.csv

5864.csv

6026.csv

6117835.csv

6215.csv

6435.csv

6518.csv

654973.csv

675.csv

683408.csv

6945753.csv

6954108.csv

7189.csv

7244.csv

7489.csv

7554.csv

7730623.csv

777000.csv

7856.csv

785984.csv

7903.csv

8019757.csv

816613.csv

825739.csv

8288.csv

8294.csv

8338263.csv

8366.csv

837.csv

8384326.csv

8461488.csv

8488.csv

8520.csv

8662515.csv

883.csv

9036.csv

913.csv

9279041.csv

995.csv

9978.csv

To pause the screen, use this command:

system("pause");

Joe Wilson11y ago

Fortunately, the problem solved, I used 8 individuals in i7 system and It ran immediately, please send me all files to me to use them, by the way, I used getch() to see the result completely before getting disappear , but it doesn't work. is there any other solution for avoid result getting disappear.

Vulpes11y ago

Go to the C:\DS_Project directory and type this at the prompt:

notepad files.csv

Next paste the following into the notepad window and save the file:

1060.csv

1472.csv

1473.csv

1477.csv

1479.csv

1495.csv

1500.csv

1507.csv

Now run Milad.exe again.

Joe Wilson11y ago

No, the problem doesn't related to the size and number of the files the problem didn't revealed yet, the windows give stopped working error.
There isn't any other way to run the program, please help me.

Vulpes11y ago

No, I've only run the program using the 8 files which you provided originally all of which contain more than 2000 lines.

As mentioned earlier, by optimizing for speed, I managed to get the running time for these 8 files down to about 3 seconds on my i3 machine.

If there are 212 files altogether and the 8 used are fairly typical of these, then I would expect the total running time to be around 40 minutes. This is why I think it's important to test the program on a small number of files first.

Joe Wilson11y ago

Well, I know why you talk about the number of csv files , and I understood that what I have done was correct, but believe me I must use all the files and the the program must be enough dynamic to support even more files than it was, so I have a question, have you ever used this number of csv files ? by the way, the strings which are in each 212 files are about 2000 , so I think this number of strings and files affect the result.

Vulpes11y ago

The immediate problem is the absence of the files.csv file.

If you look at the program, the first thing it does is to load the contents of this file, so that it knows which individual .csv files to process.

An alternative to having this file would be to load ALL .csv files in the folder. However, this isn't a great idea from a testing point of view when (as here) there are a lot of files in the folder. You really want to test the program on just a few.

Joe Wilson11y ago

Well, do you mean there isn't problem in my process that You have explained me to do, and the problem is the number of files ?
I think I have done what you have told before in order to solve the stopped working problem, but it didn't solve yet.

Vulpes11y ago

The reason for the error is that there's no files.csv file in that folder listing the individual .csv files to be processed.

So you need to create one. To start off I'd just list a few files in it rather than the whole lot so you can see that it is in fact working.

Joe Wilson11y ago

I tried what you have explained completely in other computer , with visual studio 10 and copied what was happened in filelist.txt , but the problem is when I run the program(.exe file which was created by command prompt) the windows gave me stopped working.So, do you think is there any problem in what I have done below. Once, I remember you have told that the notepad must be upgraded so this problem can be occur according to the notepad version or something other cause this problem.

here is the txt file that I created
after creation of the program and exe file.

Volume in drive C is OS
Volume Serial Number is 703B-8275

Directory of C:\DS_Project

12/28/2014 12:16 AM              .
12/28/2014 12:16 AM              ..
10/10/2014 01:55 AM            65,120 10072.csv
10/10/2014 01:55 AM            39,971 10105.csv
10/10/2014 01:55 AM            39,900 10107.csv
10/10/2014 01:55 AM            36,161 10108.csv
10/10/2014 01:55 AM            40,249 10128.csv
10/10/2014 02:26 AM            37,027 1014691.csv
10/10/2014 01:55 AM            38,399 10151.csv
10/10/2014 01:51 AM            42,781 1029.csv
10/10/2014 02:26 AM            44,605 1051327.csv
10/10/2014 01:51 AM            49,327 1060.csv
10/10/2014 02:07 AM            37,135 106587.csv
10/10/2014 02:27 AM            53,129 1116874.csv
10/10/2014 01:51 AM            86,725 113.csv
10/10/2014 02:27 AM            87,639 1133624.csv
10/10/2014 01:51 AM            86,791 115.csv
10/10/2014 02:27 AM            76,070 1182675.csv
10/10/2014 02:27 AM            39,201 1182694.csv
10/10/2014 02:27 AM            38,446 1182710.csv
10/10/2014 02:27 AM            42,466 1182718.csv
10/10/2014 02:27 AM            41,863 1182720.csv
10/10/2014 01:55 AM            53,123 11837.csv
10/10/2014 01:55 AM            40,228 11862.csv
10/10/2014 01:55 AM            62,113 11883.csv
10/10/2014 02:28 AM            55,459 1222607.csv
10/10/2014 01:55 AM            36,173 12349.csv
10/10/2014 01:55 AM            38,985 12466.csv
10/10/2014 01:55 AM            40,700 12491.csv
10/10/2014 02:29 AM            61,486 1386651.csv
10/10/2014 02:29 AM            51,629 1391550.csv
10/10/2014 01:56 AM            39,586 14710.csv
10/10/2014 01:52 AM            87,281 1472.csv
10/10/2014 01:51 AM            38,982 1473.csv
10/10/2014 01:51 AM            72,383 1477.csv
10/10/2014 01:52 AM            50,892 1479.csv
10/10/2014 01:51 AM            36,986 1495.csv
10/10/2014 01:51 AM            45,646 1500.csv
10/10/2014 01:51 AM            37,747 1507.csv
10/10/2014 01:51 AM            39,601 1512.csv
10/10/2014 01:51 AM            56,978 1525.csv
10/10/2014 01:52 AM            75,349 1526.csv
10/10/2014 01:51 AM            52,268 1527.csv
10/10/2014 01:51 AM            45,464 1534.csv
10/10/2014 01:51 AM            46,331 1537.csv
10/10/2014 01:52 AM            70,993 1538.csv
10/10/2014 02:30 AM            71,067 1541442.csv
10/10/2014 01:51 AM            49,081 1549.csv
10/10/2014 01:56 AM            60,831 15540.csv
10/10/2014 01:51 AM            36,901 1577.csv
10/10/2014 02:30 AM            47,709 1586826.csv
10/10/2014 01:51 AM            41,775 1588.csv
10/10/2014 01:52 AM            64,176 1590.csv
10/10/2014 01:52 AM            55,875 1638.csv
10/10/2014 01:51 AM            37,895 1653.csv
10/10/2014 02:30 AM            59,167 1667444.csv
10/10/2014 02:11 AM            36,202 167585.csv
10/10/2014 02:31 AM            42,843 1729243.csv
10/10/2014 02:12 AM            50,613 173670.csv
10/10/2014 01:51 AM            38,757 1748.csv
10/10/2014 02:31 AM            48,184 1769540.csv
10/10/2014 01:57 AM            56,634 17728.csv
10/10/2014 01:51 AM            65,045 1812.csv
10/10/2014 01:57 AM            47,471 19036.csv
10/10/2014 01:57 AM            40,771 19485.csv
10/10/2014 01:52 AM            67,220 1977.csv
10/10/2014 01:51 AM            36,267 1994.csv
10/10/2014 01:57 AM            46,516 20410.csv
10/10/2014 02:32 AM            37,925 2122992.csv
10/10/2014 01:52 AM            46,676 2150.csv
10/10/2014 01:52 AM            38,199 2152.csv
10/10/2014 01:52 AM            43,507 2182.csv
10/10/2014 01:52 AM            39,612 2184.csv
10/10/2014 01:52 AM            50,980 2199.csv
10/10/2014 01:52 AM            87,727 2204.csv
10/10/2014 01:52 AM            40,198 2215.csv
10/10/2014 01:52 AM            41,329 2225.csv
10/10/2014 01:52 AM            54,077 2228.csv
10/10/2014 01:52 AM            53,679 2236.csv
10/10/2014 01:52 AM            54,301 2264.csv
10/10/2014 02:32 AM            50,493 2280068.csv
10/10/2014 01:58 AM            38,483 22957.csv
10/10/2014 01:57 AM            37,411 22986.csv
10/10/2014 02:33 AM            63,195 2299193.csv
10/10/2014 01:58 AM            36,653 23107.csv
10/10/2014 01:52 AM            65,167 2340.csv
10/10/2014 01:52 AM            50,850 2348.csv
10/10/2014 02:33 AM            44,003 2449742.csv
10/10/2014 02:33 AM            65,696 2475502.csv
10/10/2014 02:33 AM            59,016 2480465.csv
10/10/2014 02:33 AM            51,763 2492277.csv
10/10/2014 01:52 AM            45,975 2567.csv
10/10/2014 01:52 AM            40,590 2575.csv
10/10/2014 01:58 AM            41,110 25918.csv
10/10/2014 02:33 AM            40,000 2619901.csv
10/10/2014 01:52 AM            48,070 2704.csv
10/10/2014 01:52 AM            49,412 2718.csv
10/10/2014 02:34 AM            87,387 2742161.csv
10/10/2014 02:34 AM            61,667 2770499.csv
10/10/2014 02:34 AM            57,196 2770555.csv
10/10/2014 02:34 AM            93,865 2773690.csv
10/10/2014 01:51 AM            41,750 283.csv
10/10/2014 01:59 AM            38,319 29144.csv
10/10/2014 01:52 AM            73,611 2930.csv
10/10/2014 01:59 AM            50,259 29374.csv
10/10/2014 01:52 AM            88,695 2964.csv
10/10/2014 02:34 AM            48,361 3032251.csv
10/10/2014 01:52 AM            47,170 3045.csv
10/10/2014 01:52 AM            57,904 3067.csv
10/10/2014 01:52 AM            92,429 3092.csv
10/10/2014 02:35 AM            72,195 3093889.csv
10/10/2014 02:35 AM            83,827 3123767.csv
10/10/2014 02:35 AM            41,473 3167566.csv
10/10/2014 02:35 AM            54,384 3181280.csv
10/10/2014 02:35 AM            42,270 3203319.csv
10/10/2014 02:35 AM            64,278 3203347.csv
10/10/2014 02:35 AM            57,652 3203350.csv
10/10/2014 02:35 AM            59,167 3203356.csv
10/10/2014 02:35 AM            84,261 3206242.csv
10/10/2014 01:52 AM            41,633 3207.csv
10/10/2014 01:52 AM            46,952 3253.csv
10/10/2014 01:52 AM            64,705 3261.csv
10/10/2014 01:52 AM            38,754 3359.csv
10/10/2014 01:52 AM            52,082 3373.csv
10/10/2014 01:59 AM            40,663 33867.csv
10/10/2014 01:59 AM            44,806 34878.csv
10/10/2014 02:35 AM            41,537 3488194.csv
10/10/2014 01:52 AM            37,203 3514.csv
10/10/2014 02:36 AM            92,542 3577382.csv
10/10/2014 01:51 AM            57,689 364.csv
10/10/2014 01:52 AM            36,106 3654.csv
10/10/2014 01:52 AM            47,356 3657.csv
10/10/2014 02:36 AM            36,540 3728592.csv
10/10/2014 02:36 AM            40,699 3745066.csv
10/10/2014 02:00 AM            40,514 39272.csv
10/10/2014 02:19 AM            74,246 393681.csv
10/10/2014 01:52 AM            36,701 3962.csv
10/10/2014 02:37 AM            47,930 4041453.csv
10/10/2014 01:53 AM            65,676 4044.csv
10/10/2014 02:37 AM            79,652 4053418.csv
10/10/2014 01:52 AM            41,230 4131.csv
10/10/2014 01:52 AM            39,795 4183.csv
10/10/2014 01:52 AM            67,278 4248.csv
10/10/2014 01:52 AM            40,748 4307.csv
10/10/2014 02:01 AM            40,294 43191.csv
10/10/2014 02:01 AM            38,024 44123.csv
10/10/2014 02:42 AM            44,683 4432994.csv
10/10/2014 02:42 AM            46,756 4479754.csv
10/10/2014 01:53 AM            46,577 4679.csv
10/10/2014 01:53 AM            37,333 4890.csv
10/10/2014 01:53 AM            38,372 4921.csv
10/10/2014 01:53 AM            50,773 4931.csv
10/10/2014 01:53 AM            41,815 4933.csv
10/10/2014 01:53 AM            35,792 4936.csv
10/10/2014 02:49 AM            38,426 4948864.csv
10/10/2014 02:50 AM            95,823 4979986.csv
10/10/2014 01:53 AM            59,070 5057.csv
10/10/2014 02:51 AM            37,300 5061284.csv
10/10/2014 01:53 AM            37,063 5068.csv
10/10/2014 02:51 AM            43,629 5072307.csv
10/10/2014 01:53 AM            39,538 5104.csv
10/10/2014 01:53 AM            39,585 5115.csv
10/10/2014 01:53 AM            57,185 5174.csv
10/10/2014 01:53 AM            39,069 5189.csv
10/10/2014 02:52 AM            66,140 5197633.csv
10/10/2014 02:21 AM            52,014 522063.csv
10/10/2014 02:54 AM            80,658 5276341.csv
10/10/2014 02:56 AM            96,694 5403381.csv
10/10/2014 01:53 AM            64,195 5448.csv
10/10/2014 02:03 AM            51,326 55332.csv
10/10/2014 01:53 AM            58,120 5537.csv
10/10/2014 01:53 AM            41,195 5794.csv
10/10/2014 01:53 AM            63,153 5864.csv
10/10/2014 01:53 AM            44,502 6026.csv
10/10/2014 03:04 AM            50,907 6117835.csv
10/10/2014 01:53 AM            40,444 6215.csv
10/10/2014 01:53 AM            37,645 6435.csv
10/10/2014 01:54 AM            43,761 6518.csv
10/10/2014 02:23 AM            42,065 654973.csv
10/10/2014 01:51 AM            36,535 675.csv
10/10/2014 02:23 AM            88,419 683408.csv
10/10/2014 03:12 AM            48,641 6945753.csv
10/10/2014 03:12 AM            44,313 6954108.csv
10/10/2014 01:54 AM            37,369 7189.csv
10/10/2014 01:54 AM            39,546 7244.csv
10/10/2014 01:54 AM            42,138 7489.csv
10/10/2014 01:54 AM            57,153 7554.csv
10/10/2014 03:16 AM            54,545 7730623.csv
10/10/2014 02:24 AM            43,948 777000.csv
10/10/2014 01:54 AM            49,534 7856.csv
10/10/2014 02:24 AM            35,862 785984.csv
10/10/2014 01:54 AM            39,167 7903.csv
10/10/2014 03:19 AM            61,980 8019757.csv
10/10/2014 02:24 AM            54,068 816613.csv
10/10/2014 02:24 AM            58,442 825739.csv
10/10/2014 01:54 AM            58,106 8288.csv
10/10/2014 01:54 AM            66,582 8294.csv
10/10/2014 03:23 AM            46,907 8338263.csv
10/10/2014 01:54 AM            46,174 8366.csv
10/10/2014 01:51 AM            44,154 837.csv
10/10/2014 03:24 AM            89,943 8384326.csv
10/10/2014 03:24 AM            55,395 8461488.csv
10/10/2014 01:54 AM            54,400 8488.csv
10/10/2014 01:54 AM            42,212 8520.csv
10/10/2014 03:26 AM            62,765 8662515.csv
10/10/2014 01:51 AM            51,979 883.csv
10/10/2014 01:54 AM            41,038 9036.csv
10/10/2014 01:51 AM            49,197 913.csv
10/10/2014 03:31 AM            53,699 9279041.csv
10/10/2014 01:51 AM            46,190 995.csv
10/10/2014 01:54 AM            43,594 9978.csv
12/28/2014 12:16 AM                 0 filelist.txt
12/28/2014 12:11 AM             8,193 Milad.cpp
12/28/2014 12:12 AM           184,320 Milad.exe
12/28/2014 12:12 AM           391,075 Milad.obj
             213 File(s)     11,395,151 bytes
               2 Dir(s) 14,019,293,184 bytes free

Vulpes11y ago

The command interpreter, cmd.exe, which is what is running during a command prompt session, has a number of built in commands.

The 'move' command moves all the files (*.*) from the sub-folder to the folder itself.

The 'rd' command removes the sub-folder.

The 'dir' command lists the files in the current folder so you can check that the other commands have done what you expected them to do.

Joe Wilson11y ago

Well, I got happy that the problem is revealed, but I don't correctly understand what I must type in command prompt please help me more about this.
and what do you mean by explaining the text below:

To deal with that, whilst you're in the d:\DS_Project folder, type this:

move files.csv\*.*
rd files.csv

If you run the 'dir' command you should now see files.csv and all the individual .csv files listed in d:\DS_Project.

Please describe and explain more.

Vulpes11y ago

Well, I can now see straightaway what the problem is.

The files to be processed are in a sub-folder of the d:\DS_Project called files.csv.

They are not in the folder itself which is what the program is assuming.

To deal with that, whilst you're in the d:\DS_Project folder, type this:

move files.csv\*.*
rd files.csv

If you run the 'dir' command you should now see files.csv and all the individual .csv files listed in d:\DS_Project.

If you do, then try to run the executable again with:

Milad.exe

Joe Wilson11y ago

Well, i think this is what you had requested at first,

Volume in drive D has no label.
Volume Serial Number is 68AC-C111

Directory of D:\DS_Project

12/27/2014 03:28 PM              .
12/27/2014 03:28 PM              ..
12/24/2014 06:52 PM              files.csv
12/27/2014 03:28 PM                 0 Flist.txt
12/24/2014 07:03 PM             8,214 Milad.cpp
12/24/2014 06:59 PM           201,216 Milad.exe
12/24/2014 06:59 PM           479,726 Milad.obj
               4 File(s)        689,156 bytes
               3 Dir(s) 194,734,579,712 bytes free

So, Could you please explain what the problem is.

Vulpes11y ago

That isn't the directory we've created for c++ projects :(

It's the directory which contains the system binary files for Visual C++.

Before you leave that directory, you should clean it up by deleting the two text files that have been created today:

del flist.txt

del filelist.txt

It looks like you've actually created the cpp_project folder as a sub-folder of the 'bin' directory. This isn't the ideal place to create it but we won't worry about that for the moment.

So, whilst you're still in the 'bin' directory do this:

cd cpp_project

and then do this:

dir > filelist.txt

Now open filelist.txt with notepad and do what you did before to copy the contents and paste them into your next post so we can see what's in that directory.

Joe Wilson11y ago

Well, I typed dir > filelist.txt in command prompt and the notepad which is created contains :

Volume in drive D has no label.
Volume Serial Number is 68AC-C111

Directory of d:\program files (x86)\microsoft visual studio 11.0\vc\bin

12/27/2014 09:50 AM              .
12/27/2014 09:50 AM              ..
01/04/2014 12:23 AM              1033
10/11/2014 09:28 PM              amd64
01/03/2014 11:54 PM              arm
07/26/2012 07:08 PM           173,000 atlprov.dll
11/06/2012 01:20 AM            87,496 bscmake.exe
11/06/2012 01:20 AM           747,464 c1.dll
11/06/2012 01:20 AM           990,144 c1ast.dll
11/06/2012 01:20 AM         2,593,232 c1xx.dll
11/06/2012 01:20 AM         2,767,840 c1xxast.dll
11/06/2012 01:20 AM         3,593,672 c2.dll
11/06/2012 01:20 AM           160,696 cl.exe
11/05/2012 07:55 PM               409 cl.exe.config
12/22/2014 02:36 PM              cpp_project
11/06/2012 01:20 AM            42,968 cvtres.exe
11/06/2012 01:20 AM         1,350,080 dpcmi.dll
11/06/2012 01:20 AM            25,056 dumpbin.exe
11/06/2012 01:20 AM            25,032 editbin.exe
01/04/2014 12:23 AM              en-US
12/27/2014 09:44 AM             2,361 filelist.txt
12/27/2014 09:50 AM                 0 flist.txt
11/06/2012 01:20 AM            25,016 lib.exe
11/06/2012 01:20 AM           759,232 link.exe
11/05/2012 07:55 PM               409 link.exe.config
06/23/2012 04:24 PM         2,523,240 localespc.dll
12/22/2014 02:37 PM              milad_project
11/06/2012 01:20 AM           434,616 ml.exe
11/06/2012 01:20 AM         1,836,512 mspft110.dll
11/06/2012 01:20 AM           102,848 nmake.exe
07/26/2012 07:08 PM            58,816 pgocvt.exe
07/26/2012 07:08 PM            65,488 pgodb110.dll
07/26/2012 07:08 PM            85,952 pgomgr.exe
07/26/2012 07:08 PM            46,032 pgort110.dll
07/26/2012 07:08 PM            59,848 pgosweep.exe
11/06/2012 01:20 AM            27,104 undname.exe
11/06/2012 01:20 AM            81,880 vcmeta.dll
11/06/2012 01:20 AM            17,856 vcmui.dll
10/01/2012 09:09 AM             4,452 vcvars32.bat
10/11/2014 09:17 PM              x86_amd64
10/11/2014 09:17 PM              x86_arm
11/06/2012 05:43 AM            47,584 xdcmake.exe
10/01/2012 08:21 AM               370 xdcmake.exe.config
              33 File(s)     18,736,705 bytes
              10 Dir(s) 194,734,862,336 bytes free

So, please analyze this and help me to solve the problem and errors.

Vulpes11y ago

I'm not just interested in .csv files but all files that are in the d:\cpp_projects folder.

The 'dir' command just produces a listing of files. It doesn't copy or interfere with those files in any way.

Normally, 'dir' lists the files to the console. However, we're redirecting its output to a file, filelist.txt, so that you can easily copy the contents and paste them into your next post.

Joe Wilson11y ago

Well, you mean I must just use dir > filelist.txt in the command propmt , bu the question is which files and where the location of the files, and how does it distinguish that it must access to csv files,and in this process I won't use the code you have sent me, because you just told that all files will be copied in the filelist.txt, I somehow get confused, please explain more.

Vulpes11y ago

This isn't something which is part of the normal process.

I'm just trying to figure out why it's working on my machine but not on yours and the logical place to start is to check that all the files are there.

Joe Wilson11y ago

Thank you for your answer, do you mean this process is the complement of the previous process, I mean after creating cpp_project folder and use md d:\cpp_project and cd d:\cpp_project , I must add dir > filelist.txt which will contain all files.csv folder files and etc after the previous elements in command prompt and copy the result of this process to you, Am I right?

Vulpes11y ago

This command prints the name of all files in the directory but, instead of printing them to the console, it prints them to a new file, called filelist.txt

dir > filelist.txt

To see what's in the directory you then need to open filelist.txt:

notepad filelist.txt

and copy everything in it so you can paste it to a new forum post. I can then check what's in the d:\cpp_projects folder to see if we're missing something.

Joe Wilson11y ago

Thank you for your favor, I have understood that it checks that the files are contain in files.csv but about the new post I received , there are few misunderstood 1. I must type notepad listfile.txt in command propmt ? 2. is it check all the files in files.csv folder 3. the location and elements of copying and pasting process.
Please explain more about these.

Vulpes11y ago

Well, at least the command prompt is correct :)

I just want to check that all the files which should be in that folder are in fact in there.

So whilst you're at the command prompt, type this:

dir > filelist.txt

and then

notepad filelist.txt

Now press Ctrl A to select the contents of this file and Ctrl C to copy it to the clip-board.

Finally, paste the contents into your next forum post by pressing Ctrl V.

Joe Wilson11y ago

Thank you for your answer, but believe me I did whatever you have told but windows gave me stopped working error,by the way, the command prompt itself gave this d:\cpp_projects > when I used drive d for folders location. I have a question, is there any other way to use the code instead of using using notepad and command prompt,because it doesn't matter, how carefully I use the code and type something in command prompt , the windows or compiler gave error, please help me, I am going to be hopeless step by step.

Vulpes11y ago

Yes, you must do that to change the drive from c: to d:

The command prompt should then change to:

d:\cpp_projects >

I've had a look at improving execution speed and I started by changing the linked lists we were using previously to vectors. As we're only adding stuff at the end of the list - not inserting it in the middle - I thought this might improve matters a bit but, in the event, it made little difference :(

I then looked at compiler optimizations and found that if we optimized for speed (/O2 compiler switch), it improved performance about 10 fold which meant that on my Pentium i3 laptop (not the fastest machine in the world) it ran in about 3 seconds.

It's still going to take a long time to deal with 200+ files but it's probably as good as we can get it.

Here's the latest version of the program:

#include

using namespace std;

typedef map< pair, double>::const_iterator clm_it;

class Graph

{

private:

int nNodes;

int nEdges;

bool isDirected;

map< pair, double > link_map;

public:

Graph( const int& nodes, const bool& directed );

~Graph();

int V() const;

int E() const;

bool directed() const;

void insert( const string& s, const string& t, const double& weight );

void remove( const string& s, const string& t );

bool edge( const string& s, const string& t);

clm_it getEdge( const string& s, const string& t);

void show() const;

};

Graph::Graph( const int& nodes, const bool& directed )

{

nNodes = nodes;

nEdges = 0;

isDirected = directed;

}

Graph::~Graph()

{}

clm_it Graph::getEdge( const string& s, const string&t )

{

pair p( s, t );

clm_it mit = link_map.find( p );

return mit;

}

// Check if link exists between end nodes

bool Graph::edge( const string& s, const string& t)

{

return getEdge( s, t ) != link_map.end();

}

// Add a link: map node pair with weight

void Graph::insert( const string& s, const string& t, const double& weight )

{

pair p1( s, t );

pair p2( t, s );

link_map[ p1 ] = weight;

if ( !isDirected )

{

link_map[ p2 ] = weight;

}

nEdges++;

}

// Remove selected link - remove both directions

// if graph is not directed

void Graph::remove( const string& s, const string& t )

{

pair p1( s, t );

map< pair, double>::iterator mit = link_map.find( p1 );

link_map.erase( mit );

if ( !isDirected )

{

pair p2( t, s );

mit = link_map.find( p2 );

link_map.erase( mit );

}

nEdges--;

}

// Print the network topology

void Graph::show() const

{

clm_it mit = link_map.begin();

for ( ; mit != link_map.end(); ++ mit )

{

pair p = (*mit).first;

cout << p.first << " " << p.second << " " << (*mit).second << std::endl;

}

// Return true if graph is directed; false otherwose

bool Graph::directed() const

{

return isDirected;

}

// Return number of network nodes

int Graph::V() const

{

return nNodes;

}

// Return number of edges

int Graph::E() const

{

return nEdges;

}

struct TAGFREQ

{

string tag;

int freq;

} tagfreq;

struct NODE

{

string file1;

string file2;

double f;

} node;

bool compare_bytag (const TAGFREQ& first, const TAGFREQ& second)

{

return first.tag < second.tag;

}

int main()

{

vector files;

vector tagfreqs, tagfreqs2;

vector::iterator it, it2, start;

vector nodes;

vector::iterator nit;

int first_sum_freq;

int second_sum_freq;

int first_qty_same;

int second_qty_same;

int num_same;

string line;

size_t pos;

ifstream infiles("files.csv"); // open list of files

while (infiles.good()) // while there are still lines

{

getline(infiles,line); // get a line

if(line == "") continue; // ignore blank lines

files.push_back(line); // add line to the vector

}

infiles.close(); // close files.csv

for(int i = 0; i < files.size() - 1; i++) // iterate through files

{

tagfreqs.clear(); // clear vector for first file

first_sum_freq = 0;

ifstream infile(files[i].c_str()); // open first file

int ii = 0;

while (infile.good()) // while there are still lines

{

getline(infile,line); // get a line

pos = line.find_first_of(','); // look for comma

if (pos == string::npos) continue; // skip if no comma

tagfreq.tag = line.substr(0, pos); // set tag to code before comma

tagfreq.freq = atoi(line.substr(pos + 1).c_str()); // set freq to rest of text converted to int

ii++;

tagfreqs.push_back(tagfreq); // add these values to vector for file 1

}

infile.close(); // close first file

sort(tagfreqs.begin(), tagfreqs.end(), compare_bytag); //sort the vector for file 1 by tag

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++)

first_sum_freq += it->freq; // iterate through file 1 vector and sum the frequencies

for(int j = i + 1; j < files.size(); j++) // iterate through rest of files

{

tagfreqs2.clear(); // clear vector for second file

second_sum_freq = 0;

first_qty_same = 0;

second_qty_same = 0;

num_same = 0;

ifstream infile2(files[j].c_str()); // open second file

while (infile2.good()) // while there are still lines

{

getline(infile2,line); // get a line

pos = line.find_first_of(','); // look for comma

if (pos == string::npos) continue; // skip if no comma

tagfreq.tag = line.substr(0, pos);

tagfreq.freq = atoi(line.substr(pos + 1).c_str());

tagfreqs2.push_back(tagfreq);

}

infile2.close(); // close second file

sort(tagfreqs2.begin(), tagfreqs2.end(), compare_bytag); // sort the vector for file 2 by tag

for(it = tagfreqs2.begin(); it != tagfreqs2.end(); it++)

second_sum_freq += it->freq; // iterate through file2 vector and sum the frequencies

start = tagfreqs2.begin(); // set 'start' initially to beginning of file2 vector

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++) // iterate through file1 vector

{

for(it2 = start; it2 != tagfreqs2.end(); it2++) // iterate through file2 vector

{

if(it->tag == it2->tag) // if the tags of the corresponding vector elements are the same

{

first_qty_same += it->freq; // increase total frequency of elements which are same for file1

second_qty_same += it2->freq; // ditto for file2

num_same++; // increment the total number which are the same

start = ++it2; // increment 'start' so we don't go over same element again

break; // loop file1 vector iterator

}

double average = (double)(first_qty_same + second_qty_same) / (first_sum_freq + second_sum_freq); // work out average

double f = (double)num_same / (tagfreqs.size() + tagfreqs2.size() - num_same) * average; // work out 'f'

node.file1 = files[i]; // set node's file1 field to file1 string variable

node.file2 = files[j]; // set node's file2 field to file2 string variable

node.f = f; //set node's f field to f double variable

nodes.push_back(node); // add these values to nodes vector

}

// check it worked

cout << "The list contains" << endl << endl;

for(nit = nodes.begin(); nit != nodes.end(); nit++) // iterate through nodes vector

{

cout << nit->file1 << ", " << nit->file2 << ", " << nit->f << endl;

}

// add to graph

Graph G(nodes.size(), false);

for(nit = nodes.begin(); nit != nodes.end(); nit++)

{

G.insert(nit->file1, nit->file2, nit->f);;

}

cout << endl << "The graph contains" << endl << endl;

G.show();

return 0;

}

You'll now need to compile it with this line:

cl /EHsc /O2 joe.cpp

Joe Wilson11y ago

Thank you for your answer, DO you mean beside type

md d:\cpp_projects

cd d:\cpp_projects

I must type d: into command propmt and by the way, I hope you will have quicken up the program by 2015/17/01.

Vulpes11y ago

If you've created the cpp_projects folder on d: rather than c: drive then, after doing this:

md d:\cpp_projects

cd d:\cpp_projects

you'll also need to do this:

d:

to actually change to your working directory.

What I said is that the program needs to be 'quickened up' before you can even contemplate processing a lot of files with it. However, it's not a five minute job to do that as it's not immediately obvious where the bottle-neck lies. I'll get onto it when I have more time.

Joe Wilson11y ago

Thank you for your favor, I did whatever you have explained but when I run exe file windows gave me stopped working error , by the way, the location I have chosen for the created folder was Drive D , so do you think what my problem is.
Is any other solution for my problem? I remember you have told that there is other way which is more efficient than the code you had sent before. Please explain your solution.

Vulpes11y ago

You're nearly there :)

The only difference is that it's not the joe.cpp file which runs.

The C++ compiler, cl.exe, generates a binary file, joe.exe, from the .cpp file by converting it to native code and linking in any libraries which we're calling. It's joe.exe which actually runs.

Joe Wilson11y ago

Oh , I somehow think that you mean after creating folder and check the directory by command propmt next copy the code in notepad and save it as joe.cpp and save and close it. then use

cl /EHsc joe.cpp
in the command prompt and after that run the notepad which I have saved the code in it,
Please check if there is any misunderstood in my description.

Vulpes11y ago

After you've done this:

cd c:\cpp_projects

do this at the command line:

notepad joe.cpp

Click 'yes' to create a new file and paste the .cpp file in my previous post into it.

Now save it from the File menu and close notepad.

Next compile it using this line:

cl /EHsc joe.cpp

Finally, run the executable with:

joe.exe

If all the files have been copied into the cpp_projects folder as previously described, then you should see some output appear at the console after several seconds.

I'm not sure what that previous error related to but see if you still get it when you run it from the command line as described above.

Joe Wilson11y ago

I create the cpp_project by typing

md c:\cpp_projects
cd c:\cpp_projects

but I don't really understand about this description :

The latest version of the cpp file (which I called joe.cpp for now) also needs to be copied to this directory. Alternatively, you can create it from scratch by typing:

notepad.exe

pasting the following code into the window and saving it as joe.cpp within the cpp_projects folder:

please explain more about which directory I must copy the cpp file and do you mean cpp file is the project file which prefix is cpp , and about exe file.

Do you mean that I must copy and paste the code to the visual studio c++ window which name is joe ,then copy the created program to the folder I have created before.

By the way, please look at the error that compiler gives me.

Vulpes11y ago

I meant to create the cpp_projects folder from within the command prompt.

There's nothing complicated about this. To create it, just do:

md c:\cpp_projects

and to make it your current working directory, do:

cd c:\cpp_projects

Then copy all the files to this directory. You can either do this from within the command prompt (using the copy command) or from outside it using the normal copy and paste operations.

files.csv should now contain a list of the 8 files you uploaded:

1060.csv

1472.csv

1473.csv

1477.csv

1479.csv

1495.csv

1500.csv

1507.csv

The latest version of the cpp file (which I called joe.cpp for now) also needs to be copied to this directory. Alternatively, you can create it from scratch by typing:

notepad.exe

pasting the following code into the window and saving it as joe.cpp within the cpp_projects folder:

#include

using namespace std;

typedef map< pair, double>::const_iterator clm_it;

class Graph

{

private:

int nNodes;

int nEdges;

bool isDirected;

map< pair, double > link_map;

public:

Graph( const int& nodes, const bool& directed );

~Graph();

int V() const;

int E() const;

bool directed() const;

void insert( const string& s, const string& t, const double& weight );

void remove( const string& s, const string& t );

bool edge( const string& s, const string& t);

clm_it getEdge( const string& s, const string& t);

void show() const;

};

Graph::Graph( const int& nodes, const bool& directed )

{

nNodes = nodes;

nEdges = 0;

isDirected = directed;

}

Graph::~Graph()

{}

clm_it Graph::getEdge( const string& s, const string&t )

{

pair p( s, t );

clm_it mit = link_map.find( p );

return mit;

}

// Check if link exists between end nodes

bool Graph::edge( const string& s, const string& t)

{

return getEdge( s, t ) != link_map.end();

}

// Add a link: map node pair with weight

void Graph::insert( const string& s, const string& t, const double& weight )

{

pair p1( s, t );

pair p2( t, s );

link_map[ p1 ] = weight;

if ( !isDirected )

{

link_map[ p2 ] = weight;

}

nEdges++;

}

// Remove selected link - remove both directions

// if graph is not directed

void Graph::remove( const string& s, const string& t )

{

pair p1( s, t );

map< pair, double>::iterator mit = link_map.find( p1 );

link_map.erase( mit );

if ( !isDirected )

{

pair p2( t, s );

mit = link_map.find( p2 );

link_map.erase( mit );

}

nEdges--;

}

// Print the network topology

void Graph::show() const

{

clm_it mit = link_map.begin();

for ( ; mit != link_map.end(); ++ mit )

{

pair p = (*mit).first;

cout << p.first << " " << p.second << " " << (*mit).second << std::endl;

}

// Return true if graph is directed; false otherwose

bool Graph::directed() const

{

return isDirected;

}

// Return number of network nodes

int Graph::V() const

{

return nNodes;

}

// Return number of edges

int Graph::E() const

{

return nEdges;

}

struct TAGFREQ

{

string tag;

int freq;

} tagfreq;

struct NODE

{

string file1;

string file2;

double f;

} node;

bool compare_bytag (const TAGFREQ& first, const TAGFREQ& second)

{

return first.tag < second.tag;

}

int main()

{

vector files;

list tagfreqs, tagfreqs2;

list::iterator it, it2, start;

list nodes;

list::iterator nit;

int first_sum_freq;

int second_sum_freq;

int first_qty_same;

int second_qty_same;

int num_same;

string line;

size_t pos;

ifstream infiles("files.csv"); // open list of files

while (infiles.good()) // while there are still lines

{

getline(infiles,line); // get a line

if(line == "") continue; // ignore blank lines

files.push_back(line); // add line to the vector

}

infiles.close(); // close files.csv

for(int i = 0; i < files.size() - 1; i++) // iterate through files

{

tagfreqs.clear(); // clear list for first file

first_sum_freq = 0;

ifstream infile(files[i].c_str()); // open first file

int ii = 0;

while (infile.good()) // while there are still lines

{

getline(infile,line); // get a line

pos = line.find_first_of(','); // look for comma

if (pos == string::npos) continue; // skip if no comma

tagfreq.tag = line.substr(0, pos); // set tag to code before comma

tagfreq.freq = atoi(line.substr(pos + 1).c_str()); // set freq to rest of text converted to int

ii++;

tagfreqs.push_back(tagfreq); // add these values to list for file 1

}

infile.close(); // close first file

tagfreqs.sort(compare_bytag); //sort the list for file 1 by tag

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++)

first_sum_freq += it->freq; // iterate through file 1 list and sum the frequencies

for(int j = i + 1; j < files.size(); j++) // iterate through rest of files

{

tagfreqs2.clear(); // clear list for second file

second_sum_freq = 0;

first_qty_same = 0;

second_qty_same = 0;

num_same = 0;

ifstream infile2(files[j].c_str()); // open second file

while (infile2.good()) // while there are still lines

{

getline(infile2,line); // get a line

pos = line.find_first_of(','); // look for comma

if (pos == string::npos) continue; // skip if no comma

tagfreq.tag = line.substr(0, pos);

tagfreq.freq = atoi(line.substr(pos + 1).c_str());

tagfreqs2.push_back(tagfreq);

}

infile2.close(); // close second file

tagfreqs2.sort(compare_bytag); // sort the list for file 2 by tag

for(it = tagfreqs2.begin(); it != tagfreqs2.end(); it++)

second_sum_freq += it->freq; // iterate through file2 list and sum the frequencies

start = tagfreqs2.begin(); // set 'start' initially to beginning of file2 list

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++) // iterate through file1 list

{

for(it2 = start; it2 != tagfreqs2.end(); it2++) // iterate through file2 list

{

if(it->tag == it2->tag) // if the tags of the corresponding list elements are the same

{

first_qty_same += it->freq; // increase total frequency of elements which are same for file1

second_qty_same += it2->freq; // ditto for file2

num_same++; // increment the total number which are the same

start = ++it2; // increment 'start' so we don't go over same element again

break; // loop file1 list iterator

}

double average = (double)(first_qty_same + second_qty_same) / (first_sum_freq + second_sum_freq); // work out average

double f = (double)num_same / (tagfreqs.size() + tagfreqs2.size() - num_same) * average; // work out 'f'

node.file1 = files[i]; // set node's file1 field to file1 string variable

node.file2 = files[j]; // set node's file2 field to file2 string variable

node.f = f; //set node's f field to f double variable

nodes.push_back(node); // add these values to nodes list

}

// check it worked

cout << "The list contains" << endl << endl;

for(nit = nodes.begin(); nit != nodes.end(); nit++) // iterate through nodes list

{

cout << nit->file1 << ", " << nit->file2 << ", " << nit->f << endl;

}

// add to graph

Graph G(nodes.size(), false);

for(nit = nodes.begin(); nit != nodes.end(); nit++)

{

G.insert(nit->file1, nit->file2, nit->f);;

}

cout << endl << "The graph contains" << endl << endl;

G.show();

return 0;

}

I'm not saying that it won't work with 220 files - I'm just saying that, judging by the time it took to process 8 files, you'll probably be waiting 'all day' for some output!

When I have more time, I'll try and 'quicken up' the program but the important thing just now is for you to get the code to work for a small number of files.

Joe Wilson11y ago

Thank you for your favor, do you mean the cpp_project folder must be in the program folder that the visual studio command propmt has created, and your explanation about creating folder by using visual studio command prompt was so complicated that I didn't understand well by the way, I have about 220 files.csv and do you mean the program you have sent wouldn't work correctly for this number of files.

Vulpes11y ago

I've tested those files and, whilst I was worried initially that the lines written in languages such as Arabic and Hebrew which are written right to left would be a problem, in fact the program seemed to read them all fine and produced the following output:

The list contains

1060.csv, 1472.csv, 0.0531434

1060.csv, 1473.csv, 0.0595926

1060.csv, 1477.csv, 0.0547377

1060.csv, 1479.csv, 0.0643462

1060.csv, 1495.csv, 0.0452037

1060.csv, 1500.csv, 0.0679078

1060.csv, 1507.csv, 0.0628616

1472.csv, 1473.csv, 0.128021

1472.csv, 1477.csv, 0.215165

1472.csv, 1479.csv, 0.1142

1472.csv, 1495.csv, 0.0360904

1472.csv, 1500.csv, 0.0595848

1472.csv, 1507.csv, 0.0554586

1473.csv, 1477.csv, 0.113672

1473.csv, 1479.csv, 0.115742

1473.csv, 1495.csv, 0.0444889

1473.csv, 1500.csv, 0.0613936

1473.csv, 1507.csv, 0.0686212

1477.csv, 1479.csv, 0.117681

1477.csv, 1495.csv, 0.0473835

1477.csv, 1500.csv, 0.0625702

1477.csv, 1507.csv, 0.0635985

1479.csv, 1495.csv, 0.0404034

1479.csv, 1500.csv, 0.0687095

1479.csv, 1507.csv, 0.0751519

1495.csv, 1500.csv, 0.0402336

1495.csv, 1507.csv, 0.0466032

1500.csv, 1507.csv, 0.100388

The graph contains

1060.csv 1472.csv 0.0531434

1060.csv 1473.csv 0.0595926

1060.csv 1477.csv 0.0547377

1060.csv 1479.csv 0.0643462

1060.csv 1495.csv 0.0452037

1060.csv 1500.csv 0.0679078

1060.csv 1507.csv 0.0628616

1472.csv 1060.csv 0.0531434

1472.csv 1473.csv 0.128021

1472.csv 1477.csv 0.215165

1472.csv 1479.csv 0.1142

1472.csv 1495.csv 0.0360904

1472.csv 1500.csv 0.0595848

1472.csv 1507.csv 0.0554586

1473.csv 1060.csv 0.0595926

1473.csv 1472.csv 0.128021

1473.csv 1477.csv 0.113672

1473.csv 1479.csv 0.115742

1473.csv 1495.csv 0.0444889

1473.csv 1500.csv 0.0613936

1473.csv 1507.csv 0.0686212

1477.csv 1060.csv 0.0547377

1477.csv 1472.csv 0.215165

1477.csv 1473.csv 0.113672

1477.csv 1479.csv 0.117681

1477.csv 1495.csv 0.0473835

1477.csv 1500.csv 0.0625702

1477.csv 1507.csv 0.0635985

1479.csv 1060.csv 0.0643462

1479.csv 1472.csv 0.1142

1479.csv 1473.csv 0.115742

1479.csv 1477.csv 0.117681

1479.csv 1495.csv 0.0404034

1479.csv 1500.csv 0.0687095

1479.csv 1507.csv 0.0751519

1495.csv 1060.csv 0.0452037

1495.csv 1472.csv 0.0360904

1495.csv 1473.csv 0.0444889

1495.csv 1477.csv 0.0473835

1495.csv 1479.csv 0.0404034

1495.csv 1500.csv 0.0402336

1495.csv 1507.csv 0.0466032

1500.csv 1060.csv 0.0679078

1500.csv 1472.csv 0.0595848

1500.csv 1473.csv 0.0613936

1500.csv 1477.csv 0.0625702

1500.csv 1479.csv 0.0687095

1500.csv 1495.csv 0.0402336

1500.csv 1507.csv 0.100388

1507.csv 1060.csv 0.0628616

1507.csv 1472.csv 0.0554586

1507.csv 1473.csv 0.0686212

1507.csv 1477.csv 0.0635985

1507.csv 1479.csv 0.0751519

1507.csv 1495.csv 0.0466032

1507.csv 1500.csv 0.100388

However, performance wasn't good which isn't entirely surprising as there's a massive amount of processing going on even for all combinations of only 8 files.

I'll have to see if I can find a way to quicken it up but, of course, none of this matters if you can't read the files in the first place!

What I'd suggest is that you come out of Visual Studio and use the command line instead.

So go into the Visual Studio Command Prompt or Developer Command Prompt from VS 2012 onwards.

You should be able to find this from the Start menu under Visual Studio tools.

First of all create a folder for your C++ projects by typing this (always press return after each line when in the command prompt):

md c:\cpp_projects

Next type this to change the working folder to the one you've just created:

cd c:\cpp_projects

Next copy into this folder:

1. files.csv and the 8 individual files it contains.

2. The .cpp file for the program (I'll call this joe.cpp for now).

Next type:

cl /EHsc joe.cpp

After some compiler stuff, you should see the following lines confirming the operation was successful:

/out:joe.exe

joe.obj

Finally, run the executable with:

joe.exe

and you should see the output I posted above.

Joe Wilson11y ago

I sent some of my files.csv to you , please use them and check the code if there was any problem in code, by the way, if there wasn't any problem in code , please guide me to how to use my files. Thank you

Vulpes11y ago

I'll need the whole solution to have much chance of diagnosing the problem here.

So just zip (or rar) the solution folder and upload it with your next post.

Joe Wilson11y ago

I used the targetdir too, but That wasn't solved, could you please give me an email address to send some of my files to check the code, I think it is better.what do you think?

Vulpes11y ago

Good, so the files are not a problem.

Regarding the setting of the working directory, did you try $(TargetDir) rather than $(ProjectDir)\Debug?

Joe Wilson11y ago

The file types are Microsoft Excel Comma Separated Values File (.csv) so I mean the files are runs in excel , by the way, the strings in the files are for example (jfgkls,3) not ("jfgkls",3") so I think the problem is accessing the files , so what is your solution?
Furthermore, the my files name are numbers like 835 or 1152 or ... so when compiler want to access to them the location of them are not clear, and I have changed the working directory to projectdir\debug can't access to files in debug folder, this problem make me nervous, please help me

Vulpes11y ago

If the files are Excel workbooks (.xls or .xlsx extension), then those are binary files, not text files, and can't be read as such.

However, if you've exported the worksheet contents to a .csv file, then those will be text files. A possible problem is that the fields may be enclosed in quotes which would need to be removed before they could be parsed.

In other words lines in the file might be like this:

"joiuh","12"

instead of like this:

joiuh,12

If you're having difficulty trying to run this program from VS, then I could try and show you how to run it from the command line instead. Do you want to do that?

Joe Wilson11y ago

Thank you but believe me I change the projectdir to projectdir\debug in working directory but nothing happen, the error wasn't solved. Please suggest other way to solve that.
by the way, the files are excel files is there any difference between files.csv and excel files?

Vulpes11y ago

It should be under the Project menu.

Click on Properties, then on Configuration Properties, then on Debugging and you should see a textbox to enable you to view or set 'Working Directory'.

Joe Wilson11y ago

Thank you but I couldn't find working directory to change projectdir to projectdir\debug.
Please guide me?

Vulpes11y ago

files.csv should be in the same folder as the individual files.

So, if you've copied all of them to the executable folder then, yes, change the working directory to: $(ProjectDir)\Debug

Joe Wilson11y ago

Thank you for your favor, by the way, because I have copied the files.csv to the debug folder, I must change projectDir to project dir\Debug?

Vulpes11y ago

The first time I read the second part of your last post I thought you were taking about the file names themselves but, reading it again, I think you just mean that the contents of the file are using a comma rather than a space separator. So a typical file will now look like this:

/* file1.csv */

joiuh,12

@62jj,10

k6235,2

99ui*,3

00Qyu67,9

*8455,7

If that's the case then it's an easy alteration to make:

for(int i = 0; i < files.size() - 1; i++) // iterate through files

{

tagfreqs.clear(); // clear list for first file

first_sum_freq = 0;

ifstream infile(files[i].c_str()); // open first file

while (infile.good()) // while there are still lines

{

getline(infile,line); // get a line

pos = line.find_first_of(','); // look for conma

if (pos == string::npos) continue; // skip if no space

tagfreq.tag = line.substr(0, pos); // set tag to code before space

tagfreq.freq = atoi(line.substr(pos + 1).c_str()); // set freq to rest of text converted to int

tagfreqs.push_back(tagfreq); // add these values to list for file 1

}

infile.close(); // close first file

tagfreqs.sort(compare_bytag); //sort the list for file 1 by tag

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++)

first_sum_freq += it->freq; // iterate through file 1 list and sum the frequencies

for(int j = i + 1; j < files.size(); j++) // iterate through rest of files

{

tagfreqs2.clear(); // clear list for second file

second_sum_freq = 0;

first_qty_same = 0;

second_qty_same = 0;

num_same = 0;

ifstream infile2(files[j].c_str()); // open second file

while (infile2.good()) // while there are still lines

{

getline(infile2,line); // get a line

pos = line.find_first_of(','); // look for comma

if (pos == string::npos) continue; // skip if no space

tagfreq.tag = line.substr(0, pos);

tagfreq.freq = atoi(line.substr(pos + 1).c_str());

tagfreqs2.push_back(tagfreq);

}

infile2.close(); // close second file

tagfreqs2.sort(compare_bytag); // sort the list for file 2 by tag

for(it = tagfreqs2.begin(); it != tagfreqs2.end(); it++)

second_sum_freq += it->freq; // iterate through file2 list and sum the frequencies

start = tagfreqs2.begin(); // set 'start' initially to beginning of file2 list

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++) // iterate through file1 list

{

for(it2 = start; it2 != tagfreqs2.end(); it2++) // iterate through file2 list

{

if(it->tag == it2->tag) // if the tags of the corresponding list elements are the same

{

first_qty_same += it->freq; // increase total frequency of elements which are same for file1

second_qty_same += it2->freq; // ditto for file2

num_same++; // increment the total number which are the same

start = ++it2; // increment 'start' so we don't go over same element again

break; // loop file1 list iterator

}

double average = (double)(first_qty_same + second_qty_same) / (first_sum_freq + second_sum_freq); // work out average

double f = (double)num_same / (tagfreqs.size() + tagfreqs2.size() - num_same) * average; // work out 'f'

node.file1 = files[i]; // set node's file1 field to file1 string variable

node.file2 = files[j]; // set node's file2 field to file2 string variable

node.f = f; //set node's f field to f double variable

nodes.push_back(node); // add these values to nodes list

}

Vulpes11y ago

If by 'program folder' you mean the folder where the .exe file is located, namely:

H:\Program Files\Graph1.1\debug\

that's not the same as the 'project folder' which, as mentioned previously, I'd expect to be:

H:\Program Files\Graph1.1\Graph1.1\

However, if you don't want to move the files again, you can change the working directory instead to point to the .exe folder.

If you go to Project menu -> Properties -> Configaration Properties ->Debugging -> Working Directory and change it from:

$(ProjectDir)

to:

$(TargetDir)

then hopefully it will work.

If it still doesn't work, try changing the working directory instead to:

$(ProjectDir)\Debug

I'll get back to you on the other point later as that will mean rewriting the program yet again.

Joe Wilson11y ago

Thank you for your answer, but I don't really understand that what you mean about
I think it will look in the project directory by default whose path - judging by the path in the error message - will be:

H:\Program Files\Graph1.1\Graph1.1\

I copied the files to the program folder but I don't understand why that error appeared ,please help me to solve the problem.
By the way, the csv files that I have given , have string and their number which is separated by ( , ) so how can I rewrite the program?

Vulpes11y ago

If you're using unqualified files names (such as file1.csv) then Visual Studio will assume they're in the project folder by default.

The path to the project folder should be the one I gave in my previous post.

So, if they're not in there already, I'd copy them into that folder and see if it will work then.

Joe Wilson11y ago

Thank you for your answer,Unfortunately, I don't get what you mean I copied csv files to my program folder, please explain where I should use or even copy csv files.
By the way, the number of each string in the each csv file is separated by (,) so I think I should use split to distinguish the string and the number of each string to use it while calculating the weight of the edge, please help me to do that.

Vulpes11y ago

Well, I'm pretty sure that error means that the debugger can't find the files.

Which folder have you copied them to?

I think it will look in the project directory by default whose path - judging by the path in the error message - will be:

H:\Program Files\Graph1.1\Graph1.1\

Joe Wilson11y ago

Thank you for your favor, I used the program that you have sent me and after I copied the files.csv to the program folder but compiler gave me the error below.

note: graph1.1 is the program name .

Debug assertion failed!
program: H:\Program Files\Graph1.1\debug\graph1.1.exe
File c:\program files\ microsoft visual studio 10.0\vc\include\vector
Line: 932

Expression: vector subscript out of range

please help me to solve this problem.

Vulpes11y ago

That's correct, Joe.

Joe Wilson11y ago

Thank you for your favor, I have a question, if first file had an string which is in all the other files, so this program would be able to make an edge between all files and first file?

Vulpes11y ago

All files.csv does is to list all the files that are to be compared to each other.

After reading this file, you're then in a position to generate all possible pairings of these files and to process them.

Of course, to do this you still need to read each file individually.

I did think of reading the info in all the files first before generating and looping through the pairings. However, the trouble with this approach is that it will require a lot of memory to store the info.

At present, we're just reading the info for each pairing into two structs and then overwriting the structs with the info for the next pairing so hardly any memory is used for that purpose.

You could also save memory by replacing each file name with a number (say the number of the line in files.csv) when you populate the graph. However, I haven't attempted anything like this since it might not be very convenient when processing the nodes in the graph.

Joe Wilson11y ago

Thank you for your answer, by the way, someone told me that the method I wanted to rename the files first then by using a simple loop , wasn't logical enough, so you mean If I use list of files I won't have the problem of reading the files and create a graph by using them.

Vulpes11y ago

I've rewritten the program on the assumption that files.csv now looks like this:

file1.csv
file2.csv
file3.csv
(and so on)

After reading in the contents of this file, the program now considers each combination of the files, taken 2 at a time, and processes them in the same way as previous versions did.

However, if you have more than 1000 files I wouldn't expect this to work quickly as there will be upwards of a million nodes in the graph.

Although I've left it in for testing purposes, you may want to remove any code which prints values to the console:

#include

using namespace std;

typedef map< pair, double>::const_iterator clm_it;

class Graph

{

private:

int nNodes;

int nEdges;

bool isDirected;

map< pair, double > link_map;

public:

Graph( const int& nodes, const bool& directed );

~Graph();

int V() const;

int E() const;

bool directed() const;

void insert( const string& s, const string& t, const double& weight );

void remove( const string& s, const string& t );

bool edge( const string& s, const string& t);

clm_it getEdge( const string& s, const string& t);

void show() const;

};

Graph::Graph( const int& nodes, const bool& directed )

{

nNodes = nodes;

nEdges = 0;

isDirected = directed;

}

Graph::~Graph()

{}

clm_it Graph::getEdge( const string& s, const string&t )

{

pair p( s, t );

clm_it mit = link_map.find( p );

return mit;

}

// Check if link exists between end nodes

bool Graph::edge( const string& s, const string& t)

{

return getEdge( s, t ) != link_map.end();

}

// Add a link: map node pair with weight

void Graph::insert( const string& s, const string& t, const double& weight )

{

pair p1( s, t );

pair p2( t, s );

link_map[ p1 ] = weight;

if ( !isDirected )

{

link_map[ p2 ] = weight;

}

nEdges++;

}

// Remove selected link - remove both directions

// if graph is not directed

void Graph::remove( const string& s, const string& t )

{

pair p1( s, t );

map< pair, double>::iterator mit = link_map.find( p1 );

link_map.erase( mit );

if ( !isDirected )

{

pair p2( t, s );

mit = link_map.find( p2 );

link_map.erase( mit );

}

nEdges--;

}

// Print the network topology

void Graph::show() const

{

clm_it mit = link_map.begin();

for ( ; mit != link_map.end(); ++ mit )

{

pair p = (*mit).first;

cout << p.first << " " << p.second << " " << (*mit).second << std::endl;

}

// Return true if graph is directed; false otherwose

bool Graph::directed() const

{

return isDirected;

}

// Return number of network nodes

int Graph::V() const

{

return nNodes;

}

// Return number of edges

int Graph::E() const

{

return nEdges;

}

struct TAGFREQ

{

string tag;

int freq;

} tagfreq;

struct NODE

{

string file1;

string file2;

double f;

} node;

bool compare_bytag (const TAGFREQ& first, const TAGFREQ& second)

{

return first.tag < second.tag;

}

int main()

{

vector files;

list tagfreqs, tagfreqs2;

list::iterator it, it2, start;

list nodes;

list::iterator nit;

int first_sum_freq;

int second_sum_freq;

int first_qty_same;

int second_qty_same;

int num_same;

string line;

size_t pos;

ifstream infiles("files.csv"); // open list of files

while (infiles.good()) // while there are still lines

{

getline(infiles,line); // get a line

if(line == "") continue; // ignore blank lines

files.push_back(line); // add line to the vector

}

infiles.close(); // close files.csv

for(int i = 0; i < files.size() - 1; i++) // iterate through files

{

tagfreqs.clear(); // clear list for first file

first_sum_freq = 0;

ifstream infile(files[i].c_str()); // open first file

while (infile.good()) // while there are still lines

{

getline(infile,line); // get a line

pos = line.find_first_of(' '); // look for space

if (pos == string::npos) continue; // skip if no space

tagfreq.tag = line.substr(0, pos); // set tag to code before space

tagfreq.freq = atoi(line.substr(pos + 1).c_str()); // set freq to rest of text converted to int

tagfreqs.push_back(tagfreq); // add these values to list for file 1

}

infile.close(); // close first file

tagfreqs.sort(compare_bytag); //sort the list for file 1 by tag

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++)

first_sum_freq += it->freq; // iterate through file 1 list and sum the frequencies

for(int j = i + 1; j < files.size(); j++) // iterate through rest of files

{

tagfreqs2.clear(); // clear list for second file

second_sum_freq = 0;

first_qty_same = 0;

second_qty_same = 0;

num_same = 0;

ifstream infile2(files[j].c_str()); // open second file

while (infile2.good()) // while there are still lines

{

getline(infile2,line); // get a line

pos = line.find_first_of(' '); // look for space

if (pos == string::npos) continue; // skip if no space

tagfreq.tag = line.substr(0, pos);

tagfreq.freq = atoi(line.substr(pos + 1).c_str());

tagfreqs2.push_back(tagfreq);

}

infile2.close(); // close second file

tagfreqs2.sort(compare_bytag); // sort the list for file 2 by tag

for(it = tagfreqs2.begin(); it != tagfreqs2.end(); it++)

second_sum_freq += it->freq; // iterate through file2 list and sum the frequencies

start = tagfreqs2.begin(); // set 'start' initially to beginning of file2 list

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++) // iterate through file1 list

{

for(it2 = start; it2 != tagfreqs2.end(); it2++) // iterate through file2 list

{

if(it->tag == it2->tag) // if the tags of the corresponding list elements are the same

{

first_qty_same += it->freq; // increase total frequency of elements which are same for file1

second_qty_same += it2->freq; // ditto for file2

num_same++; // increment the total number which are the same

start = ++it2; // increment 'start' so we don't go over same element again

break; // loop file1 list iterator

}

double average = (double)(first_qty_same + second_qty_same) / (first_sum_freq + second_sum_freq); // work out average

double f = (double)num_same / (tagfreqs.size() + tagfreqs2.size() - num_same) * average; // work out 'f'

node.file1 = files[i]; // set node's file1 field to file1 string variable

node.file2 = files[j]; // set node's file2 field to file2 string variable

node.f = f; //set node's f field to f double variable

nodes.push_back(node); // add these values to nodes list

}

// check it worked

cout << "The list contains" << endl << endl;

for(nit = nodes.begin(); nit != nodes.end(); nit++) // iterate through nodes list

{

cout << nit->file1 << ", " << nit->file2 << ", " << nit->f << endl;

}

// add to graph

Graph G(nodes.size(), false);

for(nit = nodes.begin(); nit != nodes.end(); nit++)

{

G.insert(nit->file1, nit->file2, nit->f);;

}

cout << endl << "The graph contains" << endl << endl;

G.show();

return 0;

}

For various reasons I nearly always use the command line VC++ compiler when writing C/C++ code for this forum so, if any support files are needed, I either create them in the directory I use for such programs or copy them to that directory so that I can use 'unqualified' file names.

If you're using the Visual Studio IDE, then you can still do the same thing. The path to the executable will typically be on these lines:

C:\Users\someusername\Documents\Visual Studio 2010\Projects\someprogram\someprogram\debug

However, you'll find that there are already quite a lot of files in this directory and so I don't think it will be practicable to add 1000 plus text files to it. It might be better to either leave them where they are and build the full path in the program when you open them or to put them in a sub-folder of the project or executable folder and then use a 'relative' path.

What you don't want to do here is to save the full file path to the graph as this will waste memory needlessly.

Joe Wilson11y ago

Thank you for your guidance , How can I change the code in this way that I want to rename the files.csv next by simple loops compare all files because I have about 1000 till 3000 files so if it is possible please help me to do that.By the way, you talked about how I can locate files.csv in my project I mean that you have created them in the same folder as the executable itself so I could use unqualified paths. Could you please explain more about what you have done ?

Vulpes11y ago

I don't see any alternative to listing pairs of files to be compared UNLESS every time you add a file you want it to be compared to EVERY other file.

In that case, you could have a list of files to be compared and the program could figure out all possible combinations of those files, taken two at a time, and run the code on each combination.

Yes, it's a good idea to copy all files you use to the project folder. In fact, in my application, I created them in the same folder as the executable itself so I could use unqualified paths.

Joe Wilson11y ago

Thank you for your answers, by the way, if I use this method for each new file that I use as a vertex I must use the some methods several times so the time complexity will increased more than usual, isn't it?
In addition, for accessing the file if I want to avoid using the location is it possible to copy my files.csv to the project location?

Vulpes11y ago

As I said in my fourth post in this thread, the idea is that you have a file (files.csv) which contains on each line the pairs of files to be compared. For example:

file1.csv file2.csv

file3.csv file4.csv

(and so on)

There's no reason why a particular file can't appear more than once. So you could have:

file1.csv file2.csv

file1.csv file3.csv

file2.csv file3.csv

file4.csv file5.csv

(etc)

Joe Wilson11y ago

Thank you for your answer, by the way, In some lines you have mentioned file 1, file 2 , but I will have more than 2 files and as I said before I will use them as the vectors of graph so please guide me that How can I use more than two files for being vectors of graph.

Vulpes11y ago

To make life easier, I've put all the code in a single file:

#include

using namespace std;

typedef map< pair, double>::const_iterator clm_it;

class Graph

{

private:

int nNodes;

int nEdges;

bool isDirected;

map< pair, double > link_map;

public:

Graph( const int& nodes, const bool& directed );

~Graph();

int V() const;

int E() const;

bool directed() const;

void insert( const string& s, const string& t, const double& weight );

void remove( const string& s, const string& t );

bool edge( const string& s, const string& t);

clm_it getEdge( const string& s, const string& t);

void show() const;

};

Graph::Graph( const int& nodes, const bool& directed )

{

nNodes = nodes;

nEdges = 0;

isDirected = directed;

}

Graph::~Graph()

{}

clm_it Graph::getEdge( const string& s, const string&t )

{

pair p( s, t );

clm_it mit = link_map.find( p );

return mit;

}

// Check if link exists between end nodes

bool Graph::edge( const string& s, const string& t)

{

return getEdge( s, t ) != link_map.end();

}

// Add a link: map node pair with weight

void Graph::insert( const string& s, const string& t, const double& weight )

{

pair p1( s, t );

pair p2( t, s );

link_map[ p1 ] = weight;

if ( !isDirected )

{

link_map[ p2 ] = weight;

}

nEdges++;

}

// Remove selected link - remove both directions

// if graph is not directed

void Graph::remove( const string& s, const string& t )

{

pair p1( s, t );

map< pair, double>::iterator mit = link_map.find( p1 );

link_map.erase( mit );

if ( !isDirected )

{

pair p2( t, s );

mit = link_map.find( p2 );

link_map.erase( mit );

}

nEdges--;

}

// Print the network topology

void Graph::show() const

{

clm_it mit = link_map.begin();

for ( ; mit != link_map.end(); ++ mit )

{

pair p = (*mit).first;

cout << p.first << " " << p.second << " " << (*mit).second << std::endl;

}

// Return true if graph is directed; false otherwose

bool Graph::directed() const

{

return isDirected;

}

// Return number of network nodes

int Graph::V() const

{

return nNodes;

}

// Return number of edges

int Graph::E() const

{

return nEdges;

}

struct TAGFREQ

{

string tag;

int freq;

} tagfreq;

struct NODE

{

string file1;

string file2;

double f;

} node;

bool compare_bytag (const TAGFREQ& first, const TAGFREQ& second)

{

return first.tag < second.tag; // sorts into ascending 'ASCII' order by tag

}

int main()

{

list tagfreqs, tagfreqs2;

list::iterator it, it2, start;

list nodes;

list::iterator nit;

int first_sum_freq;

int second_sum_freq;

int first_qty_same;

int second_qty_same;

int num_same;

string line, file1, file2;

size_t pos;

ifstream infiles("files.csv"); // load files.csv

while (infiles.good()) // while there are still lines in the file

{

getline(infiles,line); // get a line from the file

pos = line.find_first_of(' '); // look for space

if (pos == string::npos) continue; // skip if no space

file1 = line.substr(0, pos); // set file1 to text before space

file2 = line.substr(pos + 1); // set file2 to text after space

tagfreqs.clear(); // clear list of tags/frequencies for file1

tagfreqs2.clear(); // ditto for file2

first_sum_freq = 0;

second_sum_freq = 0;

first_qty_same = 0;

second_qty_same = 0;

num_same = 0;

ifstream infile(file1.c_str()); // load file1 in respect of current line

while (infile.good()) // while file1 still has lines

{

getline(infile,line); // get a line from file1

pos = line.find_first_of(' '); // look for space

if (pos == string::npos) continue; // skip if no space

tagfreq.tag = line.substr(0, pos); // set tag to text before space

tagfreq.freq = atoi(line.substr(pos + 1).c_str()); // set freq to rest of text, converted to int

tagfreqs.push_back(tagfreq); // add these values to the list for file1

}

infile.close(); // close file1

tagfreqs.sort(compare_bytag); // sort the list for file1 by tag

ifstream infile2(file2.c_str()); // load file2 in respect of this line

while (infile2.good()) // while file2 still has lines

{

getline(infile2,line); // get a line from the file

pos = line.find_first_of(' '); // look for space

if (pos == string::npos) continue; // skip if no space

tagfreq.tag = line.substr(0, pos); // set tag to text before space

tagfreq.freq = atoi(line.substr(pos + 1).c_str()); // set freq to rest of text converted to int

tagfreqs2.push_back(tagfreq); // add these values to list for file2

}

infile2.close(); // close file2

tagfreqs2.sort(compare_bytag); // sort the list for file2 by tag

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++)

first_sum_freq += it->freq; // iterate through file1 list and sum the frequencies

for(it = tagfreqs2.begin(); it != tagfreqs2.end(); it++)

second_sum_freq += it->freq; // iterate through file2 list and sum the frequencies

start = tagfreqs2.begin(); // set 'start' initially to beginning of file2 list

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++) // iterate through file1 list

{

for(it2 = start; it2 != tagfreqs2.end(); it2++) // iterate through file2 list

{

if(it->tag == it2->tag) // if the tags of the corresponding list elements are the same

{

first_qty_same += it->freq; // increase total frequency of elements which are same for file1

second_qty_same += it2->freq; // ditto for file2

num_same++; // increment the total number which are the same

start = ++it2; // increment 'start' so we don't go over same element again

break; // loop file1 list iterator

}

double average = (double)(first_qty_same + second_qty_same) / (first_sum_freq + second_sum_freq); // work out average

double f = (double)num_same / (tagfreqs.size() + tagfreqs2.size() - num_same) * average; // work out 'f'

node.file1 = file1; // set node's file1 field to file1 string variable

node.file2 = file2; // set node's file2 field to file2 string variable

node.f = f; //set node's f field to f double variable

nodes.push_back(node); // add these values to nodes list

}

// check it worked

cout << "The list contains" << endl << endl;

for(nit = nodes.begin(); nit != nodes.end(); nit++) // iterate through nodes list

{

cout << nit->file1 << ", " << nit->file2 << ", " << nit->f << endl;

}

// add to graph

Graph G(nodes.size(), false);

for(nit = nodes.begin(); nit != nodes.end(); nit++)

{

G.insert(nit->file1, nit->file2, nit->f);;

}

cout << endl << "The graph contains" << endl << endl;

G.show();

return 0;

}

Wth regard to understanding map and pair objects, I'd look at these links:

http://www.cplusplus.com/reference/map/map/

http://www.cplusplus.com/reference/utility/pair/

Joe Wilson11y ago

Thank you very much for your favor, by the way, is it possible to remove graph header because the compiler gives error and I don't understand about mapping please before I use the code I want to know something about map and about pair objects, please suggest some website in order to study about them. And please give comment to the code comprehensively.

Vulpes11y ago

OK, I've done what I can to comment the graph code if it's not otherwise self-explanatory. Just ask if there's anything which isn't clear:

/* Graph.cpp */

#include

#include "Graph.h" // include graph header file

using namespace std;

// create a graph for a given number of nodes

// and specify whether edges are to be directed or not

Graph::Graph( const int& nodes, const bool& directed )

{

nNodes = nodes;

nEdges = 0; // number of edges set to zero initially

isDirected = directed;

}

Graph::~Graph() // destructor

{}

// get the edge between two particular nodes

clm_it Graph::getEdge( const string& s, const string&t )

{

pair p( s, t ); // create pair object from nodes

// search map for a key equal to this pair and return iterator to it

// or iterator to map_end if key not found

clm_it mit = link_map.find( p );

return mit; // return edge i.e. iterator to pair

}

// Check if link exists between end nodes

bool Graph::edge( const string& s, const string& t)

{

return getEdge( s, t ) != link_map.end(); // true if edge found

}

// Add a link: map node pair with weight

void Graph::insert( const string& s, const string& t, const double& weight )

{

// create pairs in both directions

pair p1( s, t );

pair p2( t, s );

link_map[ p1 ] = weight; // map first pair to the weight

if ( !isDirected ) // if edge not directed

{

link_map[ p2 ] = weight; // map the second pair to the weight also

}

nEdges++; // increment number of edges

}

// Remove selected link - remove both directions

// if graph is not directed

void Graph::remove( const string& s, const string& t )

{

pair p1( s, t ); // create pair

// search map for a key equal to this pair and return iterator to it

map< pair, double>::iterator mit = link_map.find( p1 );

link_map.erase( mit ); // remove this element from the map

if ( !isDirected ) // if edge not directed

{

pair p2( t, s ); // create 'opposite' pair

mit = link_map.find( p2 ); // find it

link_map.erase( mit ); // remove it

}

nEdges--; // decrement number of edges

}

// Print the network topology

void Graph::show() const

{

clm_it mit = link_map.begin();

for ( ; mit != link_map.end(); ++ mit ) // iterate through map

{

pair p = (*mit).first; // get each pair in turn

// print it out with corresponding value
// note that de-referencing iterator returns the key which is a pair object

cout << p.first << " " << p.second << " " << (*mit).second << std::endl;

}

// Return true if graph is directed; false otherwose

bool Graph::directed() const

{

return isDirected;

}

// Return number of network nodes

int Graph::V() const

{

return nNodes;

}

// Return number of edges

int Graph::E() const

{

return nEdges;

}

/* code in main() for creating and populating graph */

// add to graph

Graph G(nodes.size(), false); // create undirected graph for nodes we have

for(nit = nodes.begin(); nit != nodes.end(); nit++) // iterate through nodes

{

// insert file1, file2 and the function value f into the graph

G.insert(nit->file1, nit->file2, nit->f);;

}

cout << endl << "The graph contains" << endl << endl;

G.show(); // display graph elements

Joe Wilson11y ago

Thank you veru much for your comprehensive answer, I am in your debt again, by the way, since I will explain the code to someone , I must use comments for some main lines, for example, give comment about creating graph which is new for me. Please do me a favor and give comments for the code.

Vulpes11y ago

OK, I've had a look to see if I could find an 'understandable' C++ implementation of a graph and I've found one here right at the end after "An alternative Graph class":

http://www.technical-recipes.com/2012/modelling-networks-as-graphs/

You'll see that rather than using an adjacency matrix or list which is the usual basis for implementing a graph, this code uses a map instead. This is how I'd probably have done it myself as it neatly ties together each node pair and the weight of the edge between them. Moreover, you can specify whether the edges are to be directed or undirected - I've assumed you'll want the latter here.

Better still, this code isn't from a copyright book and the author has kindly donated it to the public domain so we can use it as we wish.

The only change I've made to the code is to use a pair of strings rather than a pair of ints so the whole thing now is as follows:

/* Graph.h */

#include

using namespace std;

typedef map< pair, double>::const_iterator clm_it;

class Graph

{

private:

int nNodes;

int nEdges;

bool isDirected;

map< pair, double > link_map;

public:

Graph( const int& nodes, const bool& directed );

~Graph();

int V() const;

int E() const;

bool directed() const;

void insert( const string& s, const string& t, const double& weight );

void remove( const string& s, const string& t );

bool edge( const string& s, const string& t);

clm_it getEdge( const string& s, const string& t);

void show() const;

};

/* Graph.cpp */

#include

#include "Graph.h"

using namespace std;

Graph::Graph( const int& nodes, const bool& directed )

{

nNodes = nodes;

nEdges = 0;

isDirected = directed;

}

Graph::~Graph()

{}

clm_it Graph::getEdge( const string& s, const string&t )

{

pair p( s, t );

clm_it mit = link_map.find( p );

return mit;

}

// Check if link exists between end nodes

bool Graph::edge( const string& s, const string& t)

{

return getEdge( s, t ) != link_map.end();

}

// Add a link: map node pair with weight

void Graph::insert( const string& s, const string& t, const double& weight )

{

pair p1( s, t );

pair p2( t, s );

link_map[ p1 ] = weight;

if ( !isDirected )

{

link_map[ p2 ] = weight;

}

nEdges++;

}

// Remove selected link - remove both directions

// if graph is not directed

void Graph::remove( const string& s, const string& t )

{

pair p1( s, t );

map< pair, double>::iterator mit = link_map.find( p1 );

link_map.erase( mit );

if ( !isDirected )

{

pair p2( t, s );

mit = link_map.find( p2 );

link_map.erase( mit );

}

nEdges--;

}

// Print the network topology

void Graph::show() const

{

clm_it mit = link_map.begin();

for ( ; mit != link_map.end(); ++ mit )

{

pair p = (*mit).first;

cout << p.first << " " << p.second << " " << (*mit).second << std::endl;

}

// Return true if graph is directed; false otherwose

bool Graph::directed() const

{

return isDirected;

}

// Return number of network nodes

int Graph::V() const

{

return nNodes;

}

// Return number of edges

int Graph::E() const

{

return nEdges;

}

/* joe_wilson_graph.cpp or whatever you've called it */

#include

#include "Graph.h"

using namespace std;

struct TAGFREQ

{

string tag;

int freq;

} tagfreq;

struct NODE

{

string file1;

string file2;

double f;

} node;

bool compare_bytag (const TAGFREQ& first, const TAGFREQ& second)

{

return first.tag < second.tag;

}

int main()

{

list tagfreqs, tagfreqs2;

list::iterator it, it2, start;

list nodes;

list::iterator nit;

int first_sum_freq;

int second_sum_freq;

int first_qty_same;

int second_qty_same;

int num_same;

string line, file1, file2;

size_t pos;

ifstream infiles("files.csv");

while (infiles.good())

{

getline(infiles,line);

pos = line.find_first_of(' '); // look for space

if (pos == string::npos) continue; // skip if no space

file1 = line.substr(0, pos);

file2 = line.substr(pos + 1);

tagfreqs.clear();

tagfreqs2.clear();

first_sum_freq = 0;

second_sum_freq = 0;

first_qty_same = 0;

second_qty_same = 0;

num_same = 0;

ifstream infile(file1.c_str());

while (infile.good())

{

getline(infile,line);

pos = line.find_first_of(' '); // look for space

if (pos == string::npos) continue; // skip if no space

tagfreq.tag = line.substr(0, pos);

tagfreq.freq = atoi(line.substr(pos + 1).c_str());

tagfreqs.push_back(tagfreq);

}

infile.close();

tagfreqs.sort(compare_bytag);

ifstream infile2(file2.c_str());

while (infile2.good())

{

getline(infile2,line);

pos = line.find_first_of(' '); // look for space

if (pos == string::npos) continue; // skip if no space

tagfreq.tag = line.substr(0, pos);

tagfreq.freq = atoi(line.substr(pos + 1).c_str());

tagfreqs2.push_back(tagfreq);

}

infile2.close();

tagfreqs2.sort(compare_bytag);

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++)

first_sum_freq += it->freq;

for(it = tagfreqs2.begin(); it != tagfreqs2.end(); it++)

second_sum_freq += it->freq;

start = tagfreqs2.begin();

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++)

{

for(it2 = start; it2 != tagfreqs2.end(); it2++)

{

if(it->tag == it2->tag)

{

first_qty_same += it->freq;

second_qty_same += it2->freq;

num_same++;

start = ++it2;

break;

}

double average = (double)(first_qty_same + second_qty_same) /

(first_sum_freq + second_sum_freq);

double f = (double)num_same / (tagfreqs.size() + tagfreqs2.size() -

num_same) * average;

node.file1 = file1;

node.file2 = file2;

node.f = f;

nodes.push_back(node);

}

// check it worked

cout << "The list contains" << endl << endl;

for(nit = nodes.begin(); nit != nodes.end(); nit++)

{

cout << nit->file1 << ", " << nit->file2 << ", " << nit->f << endl;

}

// add to graph

Graph G(nodes.size(), false);

for(nit = nodes.begin(); nit != nodes.end(); nit++)

{

G.insert(nit->file1, nit->file2, nit->f);;

}

cout << endl << "The graph contains" << endl << endl;

G.show();

return 0;

}

Joe Wilson11y ago

Thank you for your answer. I looked for how to design a graph but the answers are so complex and I couldn't mix the graph codes with the current code you had posted me. Please help me to design a graph according to the code you sent me.

Vulpes11y ago

I've changed the code so that it now deals with multiple pairs of files.

It's assumed that the pairs of file names are contained in a file called files.csv, with each pair on a separate line separated by a space i.e:

file1.csv file2.csv
file3.csv file4.csv
(and so on)

#include

using namespace std;

struct TAGFREQ

{

string tag;

int freq;

} tagfreq;

struct NODE

{

string file1;

string file2;

double f;

} node;

bool compare_bytag (const TAGFREQ& first, const TAGFREQ& second)

{

return first.tag < second.tag;

}

int main()

{

list tagfreqs, tagfreqs2;

list::iterator it, it2, start;

list nodes;

list::iterator nit;

int first_sum_freq;

int second_sum_freq;

int first_qty_same;

int second_qty_same;

int num_same;

string line, file1, file2;

size_t pos;

ifstream infiles("files.csv");

while (infiles.good())

{

getline(infiles,line);

pos = line.find_first_of(' '); // look for space

if (pos == string::npos) continue; // skip if no space

file1 = line.substr(0, pos);

file2 = line.substr(pos + 1);

tagfreqs.clear();

tagfreqs2.clear();

first_sum_freq = 0;

second_sum_freq = 0;

first_qty_same = 0;

second_qty_same = 0;

num_same = 0;

ifstream infile(file1.c_str());

while (infile.good())

{

getline(infile,line);

pos = line.find_first_of(' '); // look for space

if (pos == string::npos) continue; // skip if no space

tagfreq.tag = line.substr(0, pos);

tagfreq.freq = atoi(line.substr(pos + 1).c_str());

tagfreqs.push_back(tagfreq);

}

infile.close();

tagfreqs.sort(compare_bytag);

ifstream infile2(file2.c_str());

while (infile2.good())

{

getline(infile2,line);

pos = line.find_first_of(' '); // look for space

if (pos == string::npos) continue; // skip if no space

tagfreq.tag = line.substr(0, pos);

tagfreq.freq = atoi(line.substr(pos + 1).c_str());

tagfreqs2.push_back(tagfreq);

}

infile2.close();

tagfreqs2.sort(compare_bytag);

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++)

first_sum_freq += it->freq;

for(it = tagfreqs2.begin(); it != tagfreqs2.end(); it++)

second_sum_freq += it->freq;

start = tagfreqs2.begin();

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++)

{

for(it2 = start; it2 != tagfreqs2.end(); it2++)

{

if(it->tag == it2->tag)

{

first_qty_same += it->freq;

second_qty_same += it2->freq;

num_same++;

start = ++it2;

break;

}

double average = (double)(first_qty_same + second_qty_same) / (first_sum_freq + second_sum_freq);

double f = (double)num_same / (tagfreqs.size() + tagfreqs2.size() - num_same) * average;

node.file1 = file1;

node.file2 = file2;

node.f = f;

nodes.push_back(node);

}

// check it worked

for(nit = nodes.begin(); nit != nodes.end(); nit++)

{

cout << nit->file1 << ", " << nit->file2 << ", " << nit->f << endl;

}

return 0;

}

You'll see that I've added the results (i.e. the two file names and the value of 'f') to a linked list of structs which I've called NODE for want of a better name.

You can now add this data to your graph. As there's no graph class in the C++ standard library, I haven't attempted to do this myself but, if you don't have one already, there should be plenty of implementations available on the Internet and there might be one in the BOOST library if you have that.

Joe Wilson11y ago

Thank you very much for your answer, and Is it possible to expand this code to more than 2 files and create a graph which vectors are the files and the edge of the graph equals the amount of F(F i , F j) method, If it isn't possible please suggest a pathway to show the graph in it after design it.

Vulpes11y ago

OK, I've altered the program to read and process 2 .csv files which it's assumed look like this:

/* file1.csv */

joiuh 12

@62jj 10

k6235 2

99ui* 3

00Qyu67 9

*8455 7

/* file2.csv */

00Qyu67 20

NY%%%20 1

UWCN10 13

89PO* 6

$$CS40 11

@62jj 56

k6235 10

As you said you wanted linked lists, I've used std::list rather than std::vector since the latter is not implemented as a linked list:

#include

using namespace std;

struct TAGFREQ

{

string tag;

int freq;

} tagfreq;

bool compare_bytag (const TAGFREQ& first, const TAGFREQ& second)

{

return first.tag < second.tag;

}

int main()

{

list tagfreqs, tagfreqs2;

list::iterator it, it2, start;

int first_sum_freq = 0;

int second_sum_freq = 0;

int first_qty_same = 0;

int second_qty_same = 0;

int num_same = 0;

string line;

size_t pos;

ifstream infile("file1.csv");

while (infile.good())

{

getline(infile,line);

pos = line.find_first_of(' '); // look for space

if (pos == string::npos) continue; // skip if no space

tagfreq.tag = line.substr(0, pos);

tagfreq.freq = atoi(line.substr(pos + 1).c_str());

tagfreqs.push_back(tagfreq);

}

infile.close();

tagfreqs.sort(compare_bytag);

ifstream infile2("file2.csv");

while (infile2.good())

{

getline(infile2,line);

pos = line.find_first_of(' '); // look for space

if (pos == string::npos) continue; // skip if no space

tagfreq.tag = line.substr(0, pos);

tagfreq.freq = atoi(line.substr(pos + 1).c_str());

tagfreqs2.push_back(tagfreq);

}

infile2.close();

tagfreqs2.sort(compare_bytag);

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++)

first_sum_freq += it->freq;

for(it = tagfreqs2.begin(); it != tagfreqs2.end(); it++)

second_sum_freq += it->freq;

start = tagfreqs2.begin();

for(it = tagfreqs.begin(); it != tagfreqs.end(); it++)

{

for(it2 = start; it2 != tagfreqs2.end(); it2++)

{

if(it->tag == it2->tag)

{

first_qty_same += it->freq;

second_qty_same += it2->freq;

num_same++;

start = ++it2;

break;

}

double average = (double)(first_qty_same + second_qty_same) / (first_sum_freq + second_sum_freq);

cout << "Average of similar tags of the two HTML files = " << average << endl;

double f = (double)num_same / (tagfreqs.size() + tagfreqs2.size() - num_same) * average;

cout << "F ( File1,File2 ) = " << f << endl;

return 0;

}

The output is the same as before, namely:

Average of similar tags of the two HTML files = 0.66875

F ( File1,File2 ) = 0.200625

Joe Wilson11y ago

I myself interest in working with HTML and accessing HTML files in C++ , but the presented program is related to the files which have tags that the post fix of them is csv , so first I must do the current project then follow my interests. So please help me to do that.

Vulpes11y ago

Well, I was wondering before how you managed to have an HTML file with an invalid tag such as <99ui>.

So are you saying that they're just ordinary text files that look something like below with each 'tag' on a different line?

joiuh

@62jj

k6235

joiuh

00Qyu67

(etc)

Joe Wilson11y ago

Thank you for your answer. I gave you a comprehensive explanation of what I am going to do below.

I want to design a graph which vectors are the files that I have given before, and to allocate a value to edge of vectors so I use F( f1,f2 ) function's result that I explained before which had been calculated by the same tags of two file . So,first I must access to text files tags next use link list to find the same tags of files .Then use F( f1,f2 ) function.
By the way, The files are text files instead of HTML files , and as I said before the tags are strings.

Vulpes11y ago

Try this.

Unless the HTML files and the resulting list of tags are large, you're unlikely to see much performance improvement from sorting the associated arrays first though I've included some code for a selection sort anyway:

#include

using namespace std;

void sort(string tags[], int freqs[], int size)

{

int start, index, min_index, freq;

string tag;

for(start = 0; start < (size - 1); start++)

{

min_index = start;

tag = tags[start];

freq = freqs[start];

for(index = start + 1; index < size; index++)

{

if(tags[index] < tag)

{

tag = tags[index];

freq = freqs[index];

min_index = index;

}

tags[min_index] = tags[start];

freqs[min_index] = freqs[start];

tags[start] = tag;

freqs[start] = freq;

}

int main()

{

string first_tag[] = {"joiuh", "@62jj", "k6235", "99ui*", "00Qyu67", "*8455"};

int first_freq[] = {12, 10, 2, 3, 9, 7};

int first_size = sizeof(first_freq)/sizeof(first_freq[0]);

sort(first_tag, first_freq, first_size);

int first_sum_freq = 0;

string second_tag[] = {"00Qyu67", "NY%%%20", "UWCN10", "89PO*", "$$CS40", "@62jj", "k6235"};

int second_freq[] = {20, 1, 13, 6, 11, 56, 10};

int second_size = sizeof(second_freq)/sizeof(second_freq[0]);

sort(second_tag, second_freq, second_size);

int second_sum_freq = 0;

int first_qty_same = 0;

int second_qty_same = 0;

int num_same = 0;

int start = 0;

int i, j;

for(i = 0; i < first_size; i++) first_sum_freq += first_freq[i];

for(i = 0; i < second_size; i++) second_sum_freq += second_freq[i];

for(i = 0; i < first_size; i++)

{

for(j = start; j < second_size; j++)

{

if(first_tag[i] == second_tag[j])

{

first_qty_same += first_freq[i];

second_qty_same += second_freq[j];

num_same++;

start = j + 1;

break;

}

double average = (double)(first_qty_same + second_qty_same) / (first_sum_freq + second_sum_freq);

cout << "Average of similar tags of the two HTML files = " << average << endl;

double f = (double)num_same / (first_size + second_size - num_same) * average;

cout << "F ( File1,File2 ) = " << f << endl;

return 0;

}

The output is:

Average of similar tags of the two HTML files = 0.66875

F ( File1,File2 ) = 0.200625

00Qyu67	20
NY%%%20	1
UWCN10	13
89PO*	6
$$CS40	11
@62jj	56
k6235	10