Its doenst clean my textbox? What happen?

Israel

Hi!

I write this code to start always with a capital letter in my textbox. its works!
But what happen? When I click on my button to clean my textbox (or combobox). I receive this message: Index was outside the bounds of the array. What happen?

Code to have the first capital letter:

private void txtdesignation_TextChanged(object sender, EventArgs e)

{

char[] v = txtdesignation.Text.ToCharArray();

string s = v[0].ToString().ToUpper();

for (int b = 1; b < v.Length; b++)

s += v[b].ToString().ToLower();

txtdesignation.Text = s;

txtdesignation.Select(txtdesignation.Text.Length, 0);

}

Code to clean my textbox:
txtdesignation.Text = "";

6 Replies

Know the answer? Post it — somebody with the same question will find it here.

Michal Habalcik11y ago
Accepted answer
yeah, forgot to add ")"
if (!String.IsNullOrEmpty(txtDesignation.Text)){
Israel11y ago
@Michael

Now its works!

Vulpes and Michael, your codes works perfectly.
Many thanx!
Israel11y ago
@kunal

Your code is working but its bugging here: if (v.Length > 0). when I am trying to rewrite on the same textbox. Its gives the same error like this: Index was outside the bounds of the array

@Michael
Your code is sturking here:
if (!String.IsNullOrEmpty(txtDesignation.Text){

@Vupes
Your code is working without problem.
Michal Habalcik11y ago
is such scenario, my favourite approach is to check the text value to null and empty like this

private void txtdesignation_TextChanged(object sender, EventArgs e)
{
if (!String.IsNullOrEmpty(txtDesignation.Text){
          char[] v = txtdesignation.Text.ToCharArray();
          string s = v[0].ToString().ToUpper();
          for (int b = 1; b < v.Length; b++)
        s += v[b].ToString().ToLower();
          txtdesignation.Text = s;
          txtdesignation.Select(txtdesignation.Text.Length, 0);
                }
}
Kunal Vaishya11y ago
Vulpes is right and you can also do this

            char[] v = txtdesignation.Text.ToCharArray();
            if (v.Length > 0)
            {
                s = v[0].ToString().ToUpper();
                for (int b = 1; b < v.Length; b++)
                    s += v[b].ToString().ToLower();
                txtdesignation.Text = s;
                txtdesignation.Select(txtdesignation.Text.Length, 0);
            }
Vulpes11y ago
When you clear the textbox it causes the TextChanged event to fire.

You then get an exception on this line because there isn't a first character:

string s = v[0].ToString().ToUpper();

To avoid this problem, just add the highlighted line:

private void txtdesignation_TextChanged(object sender, EventArgs e)
{
if(txtDesignation.Text == "") return;
char[] v = txtdesignation.Text.ToCharArray();
string s = v[0].ToString().ToUpper();
for (int b = 1; b < v.Length; b++)
s += v[b].ToString().ToLower();
txtdesignation.Text = s;
txtdesignation.Select(txtdesignation.Text.Length, 0);
}