List of stringbuilders from stringbuilder's lines

hi first post here
i am a little unsure of the code iv'e written as...
im pretty noob with the stringbuilder class

my app will rely on as few gc collections as possible text can be a problem
but i have specific problem were
i need to pull appended lines from a stringbuilder object
put it into a list or array of stringbuilders
keep the original and modify the list elements lengths to shorten them

the real problem is im unsure if this is ok what im doing
or if there is a better way already

public static List StringBuilderSplit(StringBuilder sb_text)
{
List sb_list = new List();
sb_list.Add(new StringBuilder());
char line_break_char = '\n';
if (false == char.TryParse(Environment.NewLine, out line_break_char)) { line_break_char = '\n'; }
//
int sbli = 0;
for (int i = 0; i < sb_text.Length; i++)
{
if (sb_text[i].CompareTo(line_break_char) != 0)
{
sb_list[sbli].Append(sb_text[i]);
}
else
{
sb_list.Add(new StringBuilder());
sbli++;
}
}
return sb_list;
}

1 Reply

Know the answer? Post it — somebody with the same question will find it here.

Vulpes12y ago
Well, I don't think what you've done will work properly if Environment.NewLine returns "\r\n" which is usually the case in Windows. The StringBuilders for each line except the last will contain the additional non-printing character '\r'.

Although these things are to some extent a matter of taste, I'd have done it like this:

public static List StringBuilderSplit(StringBuilder sb_text)
{
List sb_list = new List();
string s = sb_text.ToString();
string[] lines = s.Split(new[]{"\r\n", "\r", "\n"}, StringSplitOptions.None);
foreach(string line in lines)
{
sb_list.Add(new StringBuilder(line));
}
return sb_list;
}