processing time high in window service

tarun janveja

hi,

i am using window server in c#.net in which i am sending sme data to client via http request it takes 5-6 minutes to process 2000 numbers. is there some way to decrease this processing time as i have to send 1,00,000 to 2,00,000 request to client via http.please suggest some alternative way to decrease processing time. currently i am using datareader to process the number.

7 Replies

Know the answer? Post it — somebody with the same question will find it here.

Gokhul Varman9y ago
PLease refer the link for detailed explantion:https://support.microsoft.com/en-us/help/884776/how-to-configure-the-windows-time-service-against-a-large-time-offset
0
Amit Gupta9y ago
Hey

As you are using WebRequest synchronously, it will take its time (network bandwith) to complete its work, you can run this as asynchronously to make your work flawlessly

https://stackoverflow.com/questions/18207730/how-to-make-ordinary-webrequest-async-and-awaitable

Or

You can make use of WebClient class that has built-in functionality to work asynchronously.

I ll recommend you to make use of asynchronously.

Good Luck !!
0
tarun janveja9y ago
hi amit / Nilesh,
string apiUrl = "3 party url";//eg- 192.168.1.0/abc?a= rdr[0].ToString();
string redirect_url = getDirectUrl(apiUrl);
before these two first line there is on more while loop which is sending 2000 request in datareader for processing in one go.if datarader has row than in apiurl (line 1 above) variable url will be composed and in rediect url http request is send.can you please tell me how much number should be put in datareader in one go .currently i am putting 500 number in datareader.
0
Amit Gupta9y ago
Hey Tarun

I found some below points that cause your application for slow performance, modifying will slightly boost its performance:

1. Your Sql Connection are opening/closing in a loop, that cause huge decrease in performance, instead you can build the query and execute it after loop ends
var _number = "";
while (rdr.Read())
                    {
//_number = rdr[0].ToString();
                         string apiUrl = "3 party url";
                         string redirect_url = getDirectUrl(apiUrl);


                       /* SqlCommand cmd2 = new SqlCommand("delete from table where number='" + rdr[0].ToString() + "'", conn2);
                        conn2.Open();
                        cmd2.ExecuteNonQuery();
                        conn2.Close(); */

                        _number += rdr[0] + ",";
                    }
if(_number.Length>0)
{
_number = _number.Substring(0,_number.Length -1);
// Now execute your query
var cmd2 = new SqlCommand(string.Format("delete from table where number in ({0})", _number);
}
2. As you are making web request but I cannot found any variable usage for that, does it require only to read and no further use then I suggest you to call it asynchronously, so that it will not block your executing thread.
-1
Nilesh Shah9y ago
Tarun, your code is not following most basic guidelines of writing efficient code.

I have seen your attached code and here are couple of suggestions:

1) What's the use of these lines? I dont see the variables used anywhere in your code.
string apiUrl = "3 party url";
string redirect_url = getDirectUrl(apiUrl);
Either remove those entirely or keep them out of while loop, if everytime you are going to pass the same value to it.
2) You are opening, closing connection in each iteration of the loop, which is very costly operation
SqlCommand cmd2 = new SqlCommand("delete from table where number='" + rdr[0].ToString() + "'", conn2);
                        conn2.Open();
                        cmd2.ExecuteNonQuery();
                        conn2.Close();
Also firing delete query in loop is too a costly operation.
remove this entire logic from loop, get the Ids in an array, then once you have all Ids, outside of loop create a delete query with IN clause and fire a single delete command.

this will significantly increase performance.
-1
tarun janveja9y ago
hi Amit,

please find attach code, for refrence in each request reader is processing 2000 request.
0
Amit Gupta9y ago
Can you share your code for evaluation?.
+1