showing sql command not properly ended

i have to search the employee details by loanid. the details are available in 3tables. i have used join query to display but it shows error kindly solve my problem.

c# coding.

try

{

//Search Employee Details

Oracle.DataAccess.Client.OracleConnection cn = new Oracle.DataAccess.Client.OracleConnection();

cn.ConnectionString = "user id=system; password=system;";

Oracle.DataAccess.Client.OracleCommand cmd = new Oracle.DataAccess.Client.OracleCommand();

cmd.Connection = cn;

//cn = new Oracle.DataAccess.Client.OracleConnection();

cmd.CommandText = " select deposit.loanid, form1.empedoj, form1.empshare, sharecapital.shareint, sharecapital.loandt, sharecapital.loandeduc, sharecapital.dividend, sharecapital.sharetot from form1, deposit , sharecapital where deposit.loanid(+) = sharecapital.loanid = '" + txtlnid.Text.Trim() + "'"; // shows sql command not properly ended

Oracle.DataAccess.Client.OracleDataAdapter ada = new Oracle.DataAccess.Client.OracleDataAdapter(cmd);

System.Data.DataTable dt = new DataTable();

dt.Clear();

ada.Fill(dt);

//Display in Textbox

if (dt.Rows.Count > 0)

{

txtlnid.Text = dt.Rows[0].ItemArray[0].ToString();

admdate.Text = dt.Rows[0].ItemArray[1].ToString();

txtadmamt.Text = dt.Rows[0].ItemArray[2].ToString();

txtadmint.Text = dt.Rows[0].ItemArray[3].ToString();

loandt.Text = dt.Rows[0].ItemArray[4].ToString();

txtlnamt.Text = dt.Rows[0].ItemArray[5].ToString();

txtlnint.Text = dt.Rows[0].ItemArray[6].ToString();

txtsctot.Text = dt.Rows[0].ItemArray[7].ToString();

}

if (cn.State == ConnectionState.Closed)

{

cn.Open();

}

string str;

str = cmd.ExecuteScalar().ToString();

if (str != null)

{

MessageBox.Show("Record Found");

}

else

{

MessageBox.Show("ID not Match");

}

catch (Exception ex)

{

MessageBox.Show(ex.Message);

}

6 Replies

Know the answer? Post it — somebody with the same question will find it here.

LOGANATHAN V15y ago
i have learned both articles but i couldn't find my needs. i think this is very hectic. just modify my coding if you can
Suthish Nair15y ago
Article Article
LOGANATHAN V15y ago
can you tell me clearly how to define parameterized queries. i want to learn about this so tell me.
Suthish Nair15y ago
This the bad way of coding for sql commands. Always use parameterized queries.
LOGANATHAN V15y ago
(+) condition is outer join condition
Vulpes15y ago
I don't understand what the (+) is doing in there after deposit.loanid but try the following:

cmd.CommandText = "select deposit.loanid, form1.empedoj, form1.empshare, sharecapital.shareint, sharecapital.loandt, sharecapital.loandeduc, sharecapital.dividend, sharecapital.sharetot from form1, deposit, sharecapital where deposit.loanid = sharecapital.loanid and sharecapital.loanid = '" + txtlnid.Text.Trim() + "'";