Table not updating

Eduard Szigeti

I have this code that I try to fill a table in a databse.

I push the ok button, I receive no error but nothing is in my table.

can anyone tell me what could be wrong?

Thanks

private void button1_Click(object sender, EventArgs e)

{

string conection = @" Data Source = (LocalDB)\MSSQLLocalDB; AttachDbFilename = C:\Edy\Visual Studio\Last planner system\Last planner system\planning data.mdf";

using (SqlConnection con = new SqlConnection(conection))

con.Open();

SqlCommand cmd = new SqlCommand("INSERT INTO (Project name) values (Name, Starting date, End date, Description ");

cmd.Parameters.Add("Name", SqlDbType.NVarChar).Value = txtName.Text;

cmd.Parameters.Add("Starting date ", SqlDbType.Date).Value = txtStartDate.Text;

cmd.Parameters.Add("End date", SqlDbType.Date).Value = TxtEndDate.Text;

cmd.Parameters.Add("Description", SqlDbType.Text).Value = txtDescription.Text;

using (SqlConnection con1 = new SqlConnection(conection))

con1.Close();

MessageBox.Show("Done!!!");

8 Replies

Know the answer? Post it — somebody with the same question will find it here.

Rijwan Ansari5y ago
@Eduard Szigeti

Are you still getting error?
Jignesh Kumar5y ago
Hi,

You missed cmd.ExecuteNonQuery();

Please refer this link,
https://www.aspsnippets.com/Articles/ExecuteNonQuery-Insert-Update-and-Delete-examples-in-C-and-VBNet.aspx
Rijwan Ansari5y ago
Also I have found that you are missing closing bracket in command ("INSERT INTO (Project name) values (@Name, @Startingdate, @Enddate, @Description)")
SqlCommand cmd = new SqlCommand("INSERT INTO (Project name) values (@Name, @Startingdate, @Enddate, @Description)", con); ///complete query with closing bracket and add con.
Regards
Rijwan
Sachin Singh5y ago
you have not initialized the connection simply add it to the command constructor and it will work
private void button1_Click(object sender, EventArgs e)
{
string conection = @" Data Source = (LocalDB)\MSSQLLocalDB; AttachDbFilename = C:\Edy\Visual Studio\Last planner system\Last planner system\planning data.mdf";
using (SqlConnection con = new SqlConnection(conection))
con.Open();
SqlCommand cmd = new SqlCommand("INSERT INTO (Project name) values (Name, Starting date, End date, Description ",con);// Notice Here
cmd.Parameters.Add("Name", SqlDbType.NVarChar).Value = txtName.Text;
cmd.Parameters.Add("Starting date ", SqlDbType.Date).Value = txtStartDate.Text;
cmd.Parameters.Add("End date", SqlDbType.Date).Value = TxtEndDate.Text;
cmd.Parameters.Add("Description", SqlDbType.Text).Value = txtDescription.Text;
using (SqlConnection con1 = new SqlConnection(conection))
con1.Close();
MessageBox.Show("Done!!!");
Rijwan Ansari5y ago
We use @ in parameterize command or query so add @ in your parameters command. Also remove white space in parameters.

Simply update your sql command and parameters. Also I have found that you are missing closing bracket in command ("INSERT INTO (Project name) values (@Name, @Startingdate, @Enddate, @Description)")
private void button1_Click(object sender, EventArgs e)

{

string conection = @" Data Source = (LocalDB)\MSSQLLocalDB; AttachDbFilename = C:\Edy\Visual Studio\Last planner system\Last planner system\planning data.mdf";

using (SqlConnection con = new SqlConnection(conection))

con.Open();

SqlCommand cmd = new SqlCommand("INSERT INTO (Project name) values (@Name, @Startingdate, @Enddate, @Description)", con); ///complete query with closing and add con.

cmd.Parameters.Add("Name", SqlDbType.NVarChar).Value = txtName.Text;

cmd.Parameters.Add("Startingdate ", SqlDbType.Date).Value = txtStartDate.Text;

cmd.Parameters.Add("Enddate", SqlDbType.Date).Value = TxtEndDate.Text;

cmd.Parameters.Add("Description", SqlDbType.Text).Value = txtDescription.Text;

using (SqlConnection con1 = new SqlConnection(conection))

con1.Close();

MessageBox.Show("Done!!!");
Regards

Rijwan
Jose Hernandez5y ago
I think you need to add the SqlConnection object in your SqlCommand initialization as follows
SqlCommand cmd = new SqlCommand("INSERT INTO tableName values (@Name, @StartingDate, @EndDate, @Description", con);//con is your SqlConnection variable.
Eduard Szigeti5y ago
Thank you for your answer.
But I keep on receiving this error
Sachin Singh5y ago
your column name must be same as in database table and at last use cmd.ExecuteNonQuery();
private void button1_Click(object sender, EventArgs e)
{
string conection = @" Data Source = (LocalDB)\MSSQLLocalDB; AttachDbFilename = C:\Edy\Visual Studio\Last planner system\Last planner system\planning data.mdf";
using (SqlConnection con = new SqlConnection(conection))
{
con.Open();
SqlCommand cmd = new SqlCommand("INSERT INTO tableName values (@Name, @StartingDate, @EndDate, @Description ");
cmd.Parameters.Add("Name", SqlDbType.NVarChar).Value = txtName.Text; // columns must be same as in DB
cmd.Parameters.Add("StartingDate ", SqlDbType.Date).Value = txtStartDate.Text;// columns must be same as in DB
cmd.Parameters.Add("EndDate", SqlDbType.Date).Value = TxtEndDate.Text;// columns must be same as in DB
cmd.Parameters.Add("Description", SqlDbType.Text).Value = txtDescription.Text;// columns must be same as in DB
cmd.ExecuteNonQuery();

MessageBox.Show("Done!!!");
}
}