Writing and then reading a binary- inconsistency/incorrect

Sahil Dev

public void WritingABinaryBun() ///Writing
{
System.IO.FileStream wFile;
wFile = new FileStream(Path.Combine(OuputsPath, "SC03Brick201.bun"), FileMode.Create);
byte[] bytes = BitConverter.GetBytes(-1);
if (BitConverter.IsLittleEndian) Array.Reverse(bytes);
wFile.Write(bytes, 0, bytes.Length);
bytes = BitConverter.GetBytes(10);
if (BitConverter.IsLittleEndian) Array.Reverse(bytes);
wFile.Write(bytes, 0, bytes.Length);
bytes = BitConverter.GetBytes(164);
if (BitConverter.IsLittleEndian) Array.Reverse(bytes);
wFile.Write(bytes, 0, bytes.Length);
}
public void ReadingABinaryBun() //Reading
{
using (BinaryReader b = new BinaryReader(File.Open(Path.Combine(InputsPath, "SC03Brick201.bun"), FileMode.Open)))
{
int pos = 0;
int length = (int)b.BaseStream.Length;
//long length1 = (long)b.BaseStream.Length;
while (pos < length)
{
int v = b.ReadInt32();
//double v1 = b.ReadDouble();
pos += sizeof(int);
}
}
}

Below are 2 code snippets (which are a concise form of my code) which I'm using for writing and reading a binary file.

As you see, I have written 3 integer values into a binary file.

But when I read the same file through the second code snippet, I see only the foirst integer value of -1 is correctly read in.

Can anybody please help em understand why is it so?

I am using C#

6 Replies

Know the answer? Post it — somebody with the same question will find it here.

Midhun Tp10y ago
Accepted answer
Ok. Your code will work fine if you comment below line during writing -
if (BitConverter.IsLittleEndian) Array.Reverse(bytes);
Sahil Dev10y ago
Thank you very much. I will find out the exact reason for doing that. You have been v helpful/
Midhun Tp10y ago
I think he must have used opposite condition for that.

if (!BitConverter.IsLittleEndian) Array.Reverse(bytes);
I don't have much knowledge about them. They are something related to storage of memory in computers. You can refer below link for more details -
http://www.codeease.com/big-endian-and-little-endian-and-bitconverter.html
Sahil Dev10y ago
yes, it does, thanks a lot.
I'm not sure whythe old developer has put that. Any idea?
Sahil Dev10y ago
Yes, I know. BinaryWriter gives correct values.
But there is a lot of existing code whichis as you have in my first snippet.
Why cannot I use the first one?
Midhun Tp10y ago
Hi,
You can use BinaryWriter for writing to binary file.
public void WritingABinaryBun() ///Writing
{
System.IO.FileStream wFile;
wFile = new FileStream(Path.Combine(OuputsPath, "SC03Brick201.bun"), FileMode.Create);
BinaryWriter w = new BinaryWriter(wFile);
w.Write((int)-1);
w.Write((int)10);
w.Write((int)164);
w.Close();
wFile.Close();
}
This will give you correct values while reading the file.