C# Choose a return method ActionResult

Andrew Mystery

11y1.1k.NET

Hello all,

I am working on a MVC project, I currently finished three different excel sheets and depending on the type of insurance the user selects a certain default excel sheet format should be used for that insurance.

Currently I can only select one format in the return statement. What I was trying to do is have an if condition depending the string context to decide what excel format to use.

public ActionResult GenerateTripLog(int driverId, int vehicleId, int typeId, int customerId)

{

try

{

var results = (from s in db.usp_TripLog(driverId, vehicleId, typeId, customerId, sDate, eDate)

select s).ToList();

var driver = new DriverRepository(GetCurrentUser()).GetDriver(driverId);

var iType = db.insurancetypes.SingleOrDefault(c => c.id == typeId);

var tenant = GetTenant(GetCurrentUser());

var period = "All";

var driverSignature =

(from s in driver.driveravailabilityevents

where

orderby s.createdon descending

select s.signature).FirstOrDefault();

object[] filterStrs =

{

tenant == null ? "All" : tenant.tenantname,

period,

driver == null || driver.person == null ? "All" : driver.person.fullname,

iType == null ? "All" : iType.name,

driverSignature

};

//THIS IS WHAT I WAS TRYING TO DO THE SELECTION

string insuranceType = Convert.ToString(iType);

if(insuranceType == "FAMILY CARE")

{

return TripLogSpreadsheet(results, filterStrs);

}

else if(insuranceType == "BELLIN")

{

return BELLINLogSpreadsheet(results, filterStrs);

}

//return TripLogSpreadsheet(results, filterStrs);

}

catch (Exception ex)

{

ViewData["errormessage"] = ex.Message;

return View("Error");

}

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Francis Susaimichael11y ago
This is because you have return some views if "insurance type" equal to "Family care" or "bellin". What will happen if the "insurance type" is not fall in the above 2 category. As per your code it won't return any view. To avoid this you should code like below:

if(insuranceType == "FAMILY CARE")
{
return TripLogSpreadsheet(results, filterStrs);
}
else if(insuranceType == "BELLIN")
{
return BELLINLogSpreadsheet(results, filterStrs);
}
else
{
return View(); // return a default view
}
Now your code runs fine. For more info related this specific error, refer the below stack overflow discussion:

http://stackoverflow.com/questions/19903404/c-sharp-error-not-all-code-paths-return-a-value
Hope this helps
0
Andrew Mystery11y ago
My issue is my method that GenerateTripLog() wants to return a single value, when I have my 'if' condition it will return a value depending on the condition, While the if is being used because the returns are in the if the method throws an error because it says not all paths return a value for the method.
0
Shuvojit Halder11y ago
In try block after else if part you should use else condition and there you return view or after else if part you should return a view.
0
Jignesh Trivedi11y ago
Hi,

What issue are you facing?
0