C# linked list

Richard Brennan

I have a linked list program that complies but does not work as expected. Can some one have a look at it? The code is attached.

Regards

Ricahrd.

2 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes15y ago
I don't know whether it's the only problem but an adjustment is needed in one of the overloads of the add() method of your LinkedList class:

   public bool add(int position, object newEntry)
   {
   Node tmp = headNode;
   if (position >= 1)
   {
   Node newNode = new Node(newEntry);
   //Places entry at the start of the list if position = 1
   if (isEmpty() || position == 1)
   {
   newNode.setNextNode(tmp);
   headNode = newNode;
   return true;
   }
   else
   //add at the position sent
   {
   //move to the position 1 before position needed
   for (int i = 1; i < (position - 1) && tmp != null; i++) // should start from 1 rather than 0
   {
   tmp = tmp.getNextNode();
   }
   //check position is not out side the last entry
   if (tmp == null)
   {
   return false;
   }
   newNode.setNextNode(tmp.getNextNode());
   tmp.setNextNode(newNode);
   return true;
   }
   }
   else
   {
   return false;
   }
   }
Sam Hobbs15y ago
Can you please descibe the problem a little bit more? I know that will take more of your time but I think people are more likely to help if they have an idea of the problem before downloading the code. Anything you can do to make it easier for someone to help you will correspondingly increase the chance you will get help.