Checkergame continuing

Adam

So here is code for .exe and below it for dll. When u start it, and press enter on some symbol and move it across another, the symbol u have moved across, disappear.

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using ClassLibrary1;

namespace Checkers
{
    class Checkers
    {

        static Saveboard Board;
        static char[,] Area;
        static char[,] Area2;

        static void DrawBoard(bool firstTime)
        {
      //only need to do some things the first time the board is drawn

      const int X = 8;
      const int Y = 8;
      int num = 8;

      if (firstTime) Console.Clear();

      // save cursor position
      int origRow = Console.CursorTop;
      int origCol = Console.CursorLeft;

      // reset to 0,0
      Console.SetCursorPosition(0, 0);

      for (int i = 0; i < X; i++)
      {
         for (int y = 0; y < Y; y++)
         {
             Console.Write(Area[i, y]);
         }
         if (firstTime)
         {
             Console.WriteLine(num);
             num--;
         }
         else
         {
            Console.WriteLine();
         }
      }

      if (firstTime) Console.WriteLine("ABCDEFGH");

      // restore cursor postion
      Console.CursorTop = origRow;
      Console.CursorLeft = origCol;
   }

        public static void Keys()
        {
            bool redraw = false;
            int col = 0;
            int row = 0;

            while (true)
            {
                var ch = Console.ReadKey().Key;

                switch (ch)
                {

                    case ConsoleKey.RightArrow:

                        Area = Board.MoveRight(out col, out row, out redraw);
                        break;

                    case ConsoleKey.DownArrow:

                        Area = Board.MoveDown(out col, out row, out redraw);
                        break;

                    case ConsoleKey.LeftArrow:

                        Area = Board.MoveLeft(out col, out row, out redraw);
                        break;
                    case ConsoleKey.UpArrow:

                        Area = Board.MoveUp(out col, out row, out redraw);
                        break;

                    case ConsoleKey.Enter:

                        Area = Board.EnterPressed(out col, out row, out redraw);
                        break;
                }

                if (redraw) DrawBoard(false);
                Console.SetCursorPosition(col, row); // in case it's not in the right position following the move
            }
        }

        static void Main()
        {
            Board = new Saveboard();
            Area = Board.InitializeBoard();
            Area2 = Board.Checkerboard();
            DrawBoard(true);
            Console.ReadKey(true);
            Keys();
        }
    }
}

Code for dll:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace ClassLibrary1
{
    public class Saveboard
    {
        const int X = 8;
        const int Y = 8;
        char[,] Area = new char[X, Y];
        char[,] Area2 = new char[X, Y];
        int switcher = 0;
        char Symbol = (char)5;
        char Symbol2 = (char)6;
        bool pick = true;
        int xpos = 0;
        int ypos = 0;

        public char[,] InitializeBoard()
        {

            for (int i = 0; i < X; i++)
            {
                for (int y = 0; y < Y; y++)
                {
                    if (switcher % 2 == 0)
                        Area[i, y] = 'X';
                    else
                        Area[i, y] = 'Y';
                    switcher++;
                }
            }
            Area[0, 1] = Symbol;
            Area[0, 3] = Symbol;
            Area[0, 5] = Symbol;
            Area[0, 7] = Symbol;
            Area[1, 0] = Symbol;
            Area[1, 2] = Symbol;
            Area[1, 4] = Symbol;
            Area[1, 6] = Symbol;
            Area[2, 1] = Symbol;
            Area[2, 3] = Symbol;
            Area[2, 5] = Symbol;
            Area[2, 7] = Symbol;
            Area[4, 1] = Symbol2;
            Area[4, 4] = Symbol2;
            Area[5, 2] = Symbol2;

            return Area;
        }

        public char[,] Checkerboard()
        {
            for (int i = 0; i < X; i++)
            {
                for (int y = 0; y < Y; y++)
                {
                    if (switcher % 2 == 0)
                        Area2[i, y] = 'X';
                    else
                        Area2[i, y] = 'Y';
                    switcher++;
                }
                switcher++;
            }
            return Area2;
        }

        public char[,] MoveRight(out int col, out int row, out bool redraw)
        {
            if (xpos + 1 == X)
            {
                redraw = true;
            }
            else if (pick)
            {
                xpos++;
                redraw = true;
            }
            else
            {
                Area[ypos, xpos] = Area2[ypos, xpos];
                xpos++;
                redraw = true;
                Area[ypos, xpos] = Symbol;
            }
            col = xpos;
            row = ypos;
            return Area;
            }

        public char[,] MoveDown(out int col, out int row, out bool redraw)
        {
            if (ypos + 1 == Y)
            {
                redraw = true;
            }
            else if (pick == true)
            {
                ypos++;
                redraw = true;
            }
            else
            {
                Area[ypos, xpos] = Area2[ypos, xpos];
                ypos++;;
                redraw = true;
                Area[ypos, xpos] = Symbol;
            }
            col = xpos;
            row = ypos;
            return Area;
        }

        public char[,] MoveLeft(out int col, out int row, out bool redraw)
        {
            if (xpos - 1 < 0)
            {
                redraw = true;
            }
            else if (pick == true)
            {
                xpos--;
                redraw = true;
            }
            else
            {
                Area[ypos, xpos] = Area2[ypos, xpos];
                xpos--;
                redraw = true;
                Area[ypos, xpos] = Symbol;
            }
            col = xpos;
            row = ypos;
            return Area;
        }

        public char[,] MoveUp(out int col, out int row, out bool redraw)
        {
            if (ypos - 1 < 0)
            {
                redraw = true;
            }
            else if (pick == true)
            {
                ypos--;
                redraw = true;
            }
            else
            {
                Area[ypos, xpos] = Area2[ypos, xpos];
                ypos--;
                Area[ypos, xpos] = Symbol;
                redraw = true;
            }
            col = xpos;
            row = ypos;
            return Area;
        }

              public char[,] EnterPressed(out int col, out int row, out bool redraw)
              {
                  if (pick == true && Area[ypos, xpos] == Symbol)
                  {
                      redraw = false;
                      pick = false;
                  }
                  else if (pick == false && Area2[ypos, xpos] != Symbol)
                  {

                      redraw = true;
                      Area[ypos, xpos] = Symbol;
                      pick = true;
                  }
                  else
                  redraw = false;
                  col = xpos;
                  row = ypos;
                  return Area;
              }
        }
    }

37 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes15y ago
What I'd like to know is why you weren't told all this to start with?

It's impossible to write a sensible program without proper instructions (we've already had to refactor the project into an exe/dll combination) and the stuff they're asking you to do now seems to bear little relation to the actual problem!

Binary serialization is easy enough. You just need to stick the Serializable attribute on the Saveboard class:

[Serializable]
public class Saveboard
{
// etc
}

You'll then need to add Save() and Load() methods to the .exe (you can't really do it now from the dll):

// add these using directives to the others
using System.Runtime.Serialization.Formatters.Binary;
using System.IO;

// add these methods to the Checkers class

static void Save()
{
BinaryFormatter formatter = new BinaryFormatter();
using (FileStream fs = File.Create("saveboard.bin"))
formatter.Serialize(fs, Board);
}

static void Load()
{
BinaryFormatter formatter = new BinaryFormatter();
using(FileStream fs = File.OpenRead("saveboard.bin"))
Board = (Saveboard) formatter.Deserialize(fs);
}

Generic collections are stuff like List where you have a dynamic list of some type T which can be anything you like such as int as char. However, I don't see any obvious opportunity for using it in this project - all we need are two dimensional 'fixed' arrays.

Iterators iterate through some collection and, whilst they're not difficult to write, I can't see any opportunity to use a custom iterator in this project.

A class with events - you seldom bother with events in a console application and it's hard to see why we need one in this project.

However, the last one - reading the game settings from an XML file using the XmlDocument class - is the daftest of all because it's inconsistent with using the binary formatter to serialize the state of the game to disk! An XML file is a text file, not a binary file.

However, the good news is that none of this should affect what you're already doing very much. You might as well plough on with that and then we'll see if we can somehow build all this stuff in when you've finished it.

Again it would be a good idea to start a new thread and post the entire program (exe and dll) as it currently stands as you've added so many new variables that I'm now totally lost with it :(
Adam15y ago
Hm I ve just learned that I shoul Save game throw 'Binary Serialization' I have no idea what it is. Then I should use these things: generic colletions, exceptions with its own class for representing my own exception, own iterator, own class with Events and Reading the game settings from XML file using the XmlDocument class. Can I still use somethink of this?? Please answer me I have only one week to deathline :(
Adam15y ago
1)Yes that was the problem. Thanks. But now Ive another. When Symbol (player1) is on position e.g. Area[6,4] and I press Down arrow, cursor moves to possible position, but then when Iam pressing down arrow, it dont respond. And next: when e.g. player2 is on position [1,4], so when he steps on next line he changes to Queen, but on the next line is figurine of player1, so program automaticly ll see condition that he has to jump over figurine, and there is no more board. So i want fix it with condition if(ypos - 2 < 0) {....} and it works. but ale where there isnt figurine og player1, so he should step there normally but it do the same if there player1 be. take a look pls, its just part of the code:

if (xpos + 1 == X || xpos + 2 == X || ypos - 2 < 0)
{
if (Area[ypos - 1, xpos - 1] == Symbol)
{
ypos--; xpos--;
que5 = false;
}
ypos--;
xpos--;
que2 = true;
que3 = false;
}
else if (Area[ypos - 1, xpos + 1] == Symbol)
{
ypos--;
xpos++;
ypos--;
xpos++;
que4 = false;
que2 = false;
}
else
{
ypos--;
xpos++;
que2 = false;
}
2)Can you pls check my Save method because it doesnt work, but there are any error, only during Game, if I press 'S' it throws Error (Object reference not set to an instance of an object):
in .exe Ive added:
static Functions Func;

case ConsoleKey.S:
Area = Func.Save();
break;

In new DLL(Functions) is this:

using ClassLibrary1;

namespace ClassLibrary3
{
public class Functions : Saveboard
{
char[,] Area3 = new char[X, Y];

public char[,] Save()
{
for (int i = 0; i < X; i++)
{
for (int y = 0; y < Y; y++)
{
Area3[i, y] = Area[i, y];
}
}
return Area3;
}
}
}
Vulpes15y ago
I think the problem lies in this block of code in the MoveDown() method

if (dir == true && arr == true) // when arr is true, it means that you can move this arrow only from start cursor position, because if you move with queen UP , you cant move down, till cursor will be at start position and all dir's are for moving with cursor, you are pressing Down arrow and cursor changes position when you can move
{
if (xpos + 1 == X)
{
redraw = true;
}
else if (Area[ypos + 1, xpos + 1] == Symbol2)
{
ypos++;
xpos++;
dir4 = false;
}
ypos++;
xpos++;
dir = false;
dir2 = false;
}

Even if (xpos +1 == X), you're still incrementing ypos and xpos which is going to cause an out of bounds exception.

This isn't an exception you want to catch - you need to prevent it happening in the first place.

As I said in my previous post, you won't need to rewrite the dll when you convert this application to Windows Forms but you will need to rewrite the .exe completely. As you'll probably be using the mouse rather than the keyboard to select pieces directly, you may need to add some methods to the dll but it's no good worrying about all that now - just try and finish the console application first.
Adam15y ago
Unhandled exception: System.IndexOutOfRangeException: index was outside of bounders of the array. How can I fix it?? I know that with Exceptooions try&catch but i dont know how. I want to, that if curosr moves outside the board it set cursor to next posibble position. If I want to do it in Windows form, will I write a lot of new code?? I really dont know how should I start do it for windows form
Vulpes15y ago
Windows forms programming is totally different to console programming and I wouldn't even think about that until you've got this to work on the console.

The idea, of course, is that the same .dll can be used whatever the UI which is why we've been careful to confine the UI aspects to the .exe.

The Save, Load and Moveback methods don't need to know anything about the UI so these methods should be put in the .dll and then called from the .exe.

What error are you getting when the cursor moves off the board?
Adam15y ago
Yes Ive done it. But I have still problem with error which is thrown when cursor move out of board. Do u know how I can fix it?? And when I ll do methods for Save, Load, and Moveback, can I do they in new dll ?? And how shoul I do it for Windows Form?? I want do it the easiest way. Can I do it similar to console? that I will take information from DLL?? I am totaly beginner about Windows form can u advice me some topic or somethink about it?? THX
Vulpes15y ago
You should do it in the same dll. If you don't then there will be no way to synchronize the state of the board when each player moves pieces.

The methods will all need an additional parameter (int player) to specify which player is making the move so the class in the dll knows which end of the board the player is playing from and so can decide whether the move is legal or not.

I'd specify from the outset that player 1 will always play in one direction and player 2 in the other.
Adam15y ago
If I do it for Player 2, should I do it in new DLL or still in the same one ???
Adam15y ago
OK so if you press on figurine you can choose place to save with DOWN arrow, and when you press on Queen figurine you can choose place to save with DOWN and UP arrows, But when cursor moves out of board it throws error, and I dont know how to fix it.

public char[,] MoveRight(out int col, out int row, out bool redraw) //just moves with cursor
        {
            if (xpos + 1 == X)
            {
                redraw = true;
            }
            else if (pick)
            {
                xpos++;
                redraw = true;
            }
            else
               redraw = true;
            col = xpos;
            row = ypos;
            return Area;
            }

public char[,] MoveDown(out int col, out int row, out bool redraw)
        {
            if (ypos + 1 == Y) // Ive tried to fix my problem
            {
                redraw = true;
            }
            else if (pick == true)
            {
                ypos++;
                redraw = true;
            }
            else //pick = false
            {
                if (dir == true && arr == true) // when arr is true, it means that you can move this arrow only from start cursor position, because if you move with queen UP , you cant move down, till cursor will be at start position and all dir's are for moving with cursor, you are pressing Down arrow and cursor changes position when you cna move
                {
                    if (xpos + 1 == X)
                    {
                        redraw = true;
                    }
                    else if (Area[ypos + 1, xpos + 1] == Symbol2)
                    {
                        ypos++;
                        xpos++;
                        dir4 = false;
                    }
                    ypos++;
                    xpos++;
                    dir = false;
                    dir2 = false;
                }
                else if (dir2 == false)
                {
                    if (Area[ypos, xpos - 2] == Symbol2)
                    {
                        ypos++;
                        xpos--;
                        dir5 = false;
                        dir3 = false;
                    }
                    else if (dir4 == false)
                    {
                        ypos--;
                        xpos--;
                        dir4 = true;
                    }
                    xpos--;
                    xpos--;
                    dir2 = true;
                    dir3 = false;
                }
                else if (dir3 == false)
                {
                    if (dir5 == false)
                    {
                        ypos--;
                        xpos++;
                        dir5 = true;
                    }
                    ypos--;
                    xpos++;
                    dir3 = true;
                    dir = true;
                }
                redraw = true;
            }

            col = xpos;
            row = ypos;
            return Area;
        }

public char[,] MoveLeft(out int col, out int row, out bool redraw) //just moves with cursor
{
if (xpos - 1 < 0 )
{
redraw = true;
}
else if (pick == true)
{
xpos--;
redraw = true;
}
else
redraw = true;
col = xpos;
row = ypos;
return Area;
}

        public char[,] MoveUp(out int col, out int row, out bool redraw)
        {
            if (ypos - 1 < 0)
            {
                redraw = true;
            }
            else if (pick == true)
            {
                ypos--;
                redraw = true;
            }
            else
            if(dir == true && queen == false) // when queen is false, program know that you want to move with queen
            {
                if (que == true) // que is similar to dir, just to other direction
                {
                    if (Area[ypos - 1, xpos + 1] == Symbol2)
                    {
                        ypos--;
                        xpos++;
                        que4 = false;
                    }
                    ypos--;
                    xpos++;
                    arr = false;
                    que = false;
                    que2 = false;
                }
                else if (que2 == false)
                {
                    if (Area[ypos, xpos - 2] == Symbol2)
                    {
                        ypos--;
                        xpos--;
                        que5 = false;
                        que3 = false;
                    }
                    else if (que4 == false)
                    {
                        ypos++;
                        xpos--;
                        dir4 = true;
                    }
                    xpos--;
                    xpos--;
                    arr = false;
                    que2 = true;
                    que3 = false;
                }
                else if (que3 == false)
                {
                    if (que5 == false)
                    {
                        ypos++;
                        xpos++;
                        dir5 = true;
                    }
                    ypos++;
                    xpos++;
                    arr = true;
                    que3 = true;
                    que = true;
                }
            }// pick = false
                redraw = true;
            col = xpos;
            row = ypos;
            return Area;
        }

public char[,] EnterPressed(out int col, out int row, out bool redraw, out bool choose)
              {
                  if (pick == true && Area[ypos, xpos] == Symbol)
                  {
                          Area[ypos, xpos] = Area2[ypos, xpos];
                          redraw = true;
                          pick = false;
                          dir = true;
                  }
                  else if (pick == true && Area[ypos, xpos] == Symbol3)
                  {
                      Area[ypos, xpos] = Area2[ypos, xpos];
                      redraw = true;
                      pick = false;
                      dir = true;
                      que = true;
                      queen = false;
                  }
                  else if (pick == false && Area[ypos, xpos] == 'Y') // want to SAVE figurine
                  {
                      if (dir5 == false && Area[ypos - 1, xpos + 1] == Symbol2)
                      {
                          Area[ypos - 1, xpos + 1] = Area2[ypos, xpos];
                          if(queen == false)
                            Area[ypos, xpos] = Symbol3;
                          else
                            Area[ypos, xpos] = Symbol;
                      }
                      else if (dir4 == false && (Area[ypos - 1, xpos - 1] == Symbol2))
                      {
                          Area[ypos - 1, xpos - 1] = Area2[ypos, xpos];
                          if (queen == false)
                              Area[ypos, xpos] = Symbol3;
                          else
                              Area[ypos, xpos] = Symbol;
                      }
                      else if (que4 == false && (Area[ypos + 1, xpos - 1] == Symbol2))
                      {
                          Area[ypos + 1, xpos - 1] = Area2[ypos, xpos];
                          Area[ypos, xpos] = Symbol3;
                      }
                      else if (que5 == false && (Area[ypos - 1, xpos - 1] == Symbol2))
                      {
                          Area[ypos + 1, xpos - 1] = Area2[ypos, xpos];
                          Area[ypos, xpos] = Symbol3;
                      }
                      else if (ypos == 7 && Area[ypos, xpos] == 'Y')
                      {
                          Area[ypos, xpos] = Symbol3;
                      }
                      else
                      {
                          if (queen == false)
                          {
                              Area[ypos, xpos] = Symbol3;
                              queen = true;
                          }
                          else
                              Area[ypos, xpos] = Symbol;
                      }
                      queen = true; // after save position I set all to initial state
                      arr = true;
                      pick = true;
                      dir2 = true;
                      dir3 = true;
                      dir4 = true;
                      dir5 = true;
                      que2 = true;
                      que3 = true;
                      que4 = true;
                      que5 = true;
                      redraw = true;
                  }
                  else
                      redraw = false;
                  choose = pick;
                  col = xpos;
                  row = ypos;
                  return Area;
              }
        }
Vulpes15y ago
There are essentially three forms of if statement:

1. No 'else:

if (someCondition) DoSomething();

2. Single 'else':

if (someCondition)
DoSomething();
else
DoSomethingElse();

3. if/else if/else ladder:

if (someCondition)
DoSomething();
else if (someCondition2)
DoSomething2();
else
DoSomethingElse();

The third form can have as many 'else ifs' as you like and needn't have an 'else' at all.

I don't really understand your last post. Can you post what the code looks like now (just the arrows and enter) in the light of that.
Adam15y ago
Forget code what Ive written before. Now I only press Down Arrow and it gradually changes posible moves. Look at this pls: When I've got this condition
else if (Area[ypos + 1, xpos + 1] == Symbol2)
{
ypos++;
xpos++;
dir4 = false;
}

But when Iam at e.g. Area[4,7] so it is a edge of board, and this condition has to look at position xpos + 1, what is out of board, it throws me exception. How can I write somethink like, try this: Area[ypos + 1, xpos + 1] = square in board, and if no, it moves with cursor e.g. xpos--; ?? Can I write it with try& catch some way?? thx
Adam15y ago
I really dont know how to correct it, I have even dir3 but I cant still get the jist of it. And I'd like to ask one question. If I want to use e.g. 5 if's, so when I souch write 'if' , 'else if' and else, When should I write if, if, if and only one else if etc. ?? thx
Vulpes15y ago
I'll have to have a careful look at the whole thing, in the light of the changes you've made, when I've more time.

But, my initial reaction to the current problem is that, when you set 'dir2' you'll need to introduce another bool variable so you know whether right was pressed before left or vice versa.
Adam15y ago
I know where is the problem. When I press Right and after it Left, it sets dir and dir2 to false, so then when I press Up it move to RightUp instead LeftUp, because of this condition which is more importenetn: if (dir == false && dir2 == false). DO u know how can I correct it??

public char[,] MoveUp(out int col, out int row, out bool redraw)
        {
            if (ypos - 1 < 0)
            {
                redraw = true;
            }
            else if (pick == true)
            {
                ypos--;
                redraw = true;
            }
            else
            {
                if (dir == false && dir2 == false)
                {
                    ypos--;
                    xpos++;
                    dir2 = true;
                    dir = true;
                }
                else if (dir == false)
                {
                    ypos--;
                    xpos--;
                    dir = true;
                }
                redraw = true;
            }
            col = xpos;
            row = ypos;
            return Area;
        }
Adam15y ago
When you press right or left arrow you cant press it again, only if you press Up arrow before. Up arrow returns you back to the position when was the figurine. It is because when you press enter on some figurine then move left, And after that you realize that you want to move another figurine, you can still move cursor back,Up, and save it and move with another symbol.
Vulpes15y ago
So, if you've chosen a figurine, then pressing the right arrow will move diagonally right and pressing the left arrow will move diagonally left.

Pressing the down array will have no effect but what's the up arrow supposed to be doing - cancelling the previous move?
Adam15y ago
Start position of dir & dir2 = true

So when you look into MoveRight method in DLL, when pick = false and into it is dir = true. It couse that cursor moves (ypos++, xpos++) and dir= false. So you cant again press Right arrow. In method MoveUp , it again set dir to true, so you can press right again. And MoveLeft has dir2 extra. Because dir is only for move(ypos++;xpos++;)
and dir2 is for move (ypos++;xpos--;). But in MoveLeft are two 'dir's so when you move with figurine to area for example Area[6, 0] and than again left, but there is no more squares, and then Up + Right+Up, it moves cursor double xpos++, so I think that this is bcause of some mixed of true&false. And this is what I dont know how correct it. It is all because when pick = false, you can move with cursor only to position when you really can save symbol.
Vulpes15y ago
I'm sorry but you've lost me completely.

What do 'dir' and 'dir2' signify and what are they set to initially?
Adam15y ago
So Ive made it like this(below code). It works good but when I am on the left edge of the board and press left , up and rigt arrow it throws me 1 square to right, I dont know why. For right edge its the same. I think that sometimes the all bools condition are mixed and it works bad. Can u pls see on this code ? thx

public char[,] MoveRight(out int col, out int row, out bool redraw)
        {
            if (xpos + 1 == X)
            {
                redraw = true;
            }
            else if (pick)
            {
                xpos++;
                redraw = true;
            }
            else
            {
                if (dir == true)
                {
                    ypos++;
                    xpos++;
                    dir = false;
                }
                redraw = true;
            }
            col = xpos;
            row = ypos;
            return Area;
            }

        public char[,] MoveDown(out int col, out int row, out bool redraw)
        {
            if (ypos + 1 == Y)
            {
                redraw = true;
            }
            else if (pick == true)
            {
                ypos++;
                redraw = true;
            }
            else
                redraw = true;
            col = xpos;
            row = ypos;
            return Area;
        }

        public char[,] MoveLeft(out int col, out int row, out bool redraw)
        {
            if (xpos - 1 < 0)
            {
                redraw = true;
            }
            else if (pick == true)
            {
                xpos--;
                redraw = true;
            }
            else
            {
                if (dir == true)
                {
                    ypos++;
                    xpos--;
                    dir = false;
                    dir2 = false;
                }
                redraw = true;
            }
            col = xpos;
            row = ypos;
            return Area;
        }

        public char[,] MoveUp(out int col, out int row, out bool redraw)
        {
            if (ypos - 1 < 0)
            {
                redraw = true;
            }
            else if (pick == true)
            {
                ypos--;
                redraw = true;
            }
            else
            {
                if (dir == false && dir2 == false)
                {
                    ypos--;
                    xpos++;
                    dir2 = true;
                    dir = true;
                }
                else if (dir == false)
                {
                    ypos--;
                    xpos--;
                    dir = true;
                }
                redraw = true;
            }
            col = xpos;
            row = ypos;
            return Area;
        }

              public char[,] EnterPressed(out int col, out int row, out bool redraw, out bool choose)
              {
                  if (pick == true && Area[ypos, xpos] == Symbol)
                  {
                          Area[ypos, xpos] = Area2[ypos, xpos];
                          redraw = true;
                          pick = false;
                          dir = true;
                  }
                  else if (pick == false )
                  {
                              Area[ypos, xpos] = Symbol;
                              pick = true;
                              redraw = true;
                  }
                  else
                    redraw = false;
                  choose = pick;
                  col = xpos;
                  row = ypos;
                  return Area;
              }
        }
    }
Adam15y ago
I just realize now that it isnt good way because I maybe can move only one move forward but to right and left no.... but I ll leave my previous post here.
Adam15y ago
I think that if you want to do only diagonal move it just should have condition that Figurine can stand only to square where is 'Y' symbol. And when figueirne can stand only on 'Y' it ensure diagonal move, dont u think?? That the way I ve wanted to do it because now I dont know the condition how to secure that figurine could be save only one square forward because only Queen can move more than one moves forward at once.
Below is piece of code of Enter when it 'works' but not at all, but I think it is good way to do:

else if (pick == false && Area[ypos, xpos] == 'Y')
{
if (ypos < 4)
{
Area[ypos, xpos] = Symbol;
pick = true;
redraw = true;
}
else
redraw = true;

But its good line only for 3 line on checkerboard, i dont know how can I write this: if figurine is from 3th line, then ypos has to be < 4. Have u got any idea how to write it please?? this is way how to do that but it is too concrete, dont u have any idea how similiar condition write for all figurine??
Vulpes15y ago
If you press '4', the figurine would move diagonally forward to the left and if you press '5' diagonally forward to the right.

If you press '4' again (without the opponent moving in the meantime) it would be an illegal move and nothing would happen.

As I understand the rules of the game, a piece can't move back unless it's a king in which case '1' would move back to the left or '2' to the right. I assume you aren't going to allow a player to cancel a move once it's been made but, if you are, we'd need to allocate another key to do that and would also need to 'remember' the last move so that it could be cancelled out.

I really don't know how else you can do it without using separate keys because it's hard to see how you can represent diagonal moves when the cursor can only move left, right, up and down. How could it move back for instance?
Adam15y ago
I dont understand it. So if I press 4, it moves forvard diagonaly, what if I press it two times? It would be wrong move because figurine can move only one place forvard. So tell me if I understand it. So if you press 4 it moves cursor to right diagonal place and when I press 4 for the second time it wouldnt work? And what if I press 4 and then I ll want to move back and do another move? I press 2? I dont know. Do you think it is more easy way?? I would rather do it only on arrows with some conditional, but maybe your way is more easy and I dont understand it yet.
I also want to thanks you a lot because you re really helping me and sometimes I think I bother you, so sorry but I have to done this game.
Vulpes15y ago
I'd be inclined to only use the cursor keys to select a piece to move.

To actually move a piece, I'd dedicate a block of 4 keys (say in the numeric keypad) to move a piece diagonally. So, pressing 4 would move it diagonally forward to the left and pressing 5 would move it diagonally forward to the right. For kings (or queens as you call them) pressing 1 or 2 would move the king backwards to the left or right. If this resulted in you landing on top of an opposing piece, then the piece would be captured and your piece would move to a further square in the same direction.

All this would be done programatically - you'd place the piece in the correct position and set the cursor position accordingly. So you'd need four more methods:

1. MoveDiagLeft
2. MoveDiagRight
3. BackDiagLeft
4. BackDiagRight

You could write an explanation under the board so the player knows which key does what.
Adam15y ago
OK it is clear now. If you have some free time, can u please answer my other questions above? thanks
Vulpes15y ago
It needs to be a static field because all the methods in the Checkers class are static and so they can't use instance fields.

As we only need to pass 'choose' to the EnterPressed() method, this means that we have to store its value in the meantime because, even if we're just calling the 'arrow' methods, we might need to redraw the board and this now requires knowledge of whether 'choose' is true or false.

We don't need to bother storing row, col and redraw as these are always returned by all five methods.
Adam15y ago
Nice thanks it works good. But I dont understand why there is static bool choose = true; why it has to be static?? and why should I write it when col, row and redraw is also out parameters, the same, but they dont need line like this (static bool choose = true;)
Vulpes15y ago
Oh, one other change in the EnterPressed event (I'm not going to disturb my previous post as I'll lose all the highlighting!):

   if (pick == true && Area[ypos, xpos] == Symbol)
{
Area[ypos, xpos] = Area2[ypos, xpos];
redraw = true; // as we're changing pick
pick = false;
}

and when a redraw is done after pick is set to false, we'll need another change in the DrawBoard() method of the .exe:

   Console.SetCursorPosition(0, 10); // now moved outside the 'if'
   if (choose)
{
Console.WriteLine("Choose your figurine");
}
else
   {
Console.WriteLine(" "); // remove prompt
}
Vulpes15y ago
I'll just deal with the 'Choose your figurine' point for now and try and get back on the others later today.

In the dll, introduce another 'out' parameter called 'choose' in the EnterPressed() method:

public char[,] EnterPressed(out int col, out int row, out bool redraw, out bool choose)
{
  if (pick == true && Area[ypos, xpos] == Symbol)
  {
  Area[ypos, xpos] = Area2[ypos, xpos];
  redraw = false;
  pick = false;
  }
  else if (pick == false && Area[ypos, xpos] == 'Y')
  {

  redraw = true;
  Area[ypos, xpos] = Symbol;
  pick = true;
  }
  else
  redraw = false;
  col = xpos;
  row = ypos;
  choose = pick;
  return Area;
}

I think this is the only place where 'pick' can be changed so you shouldn't need to do anything for the arrow keys.

Now in the .exe, you'll need a few changes which I've highlighted as follows:

namespace Checkers
{
   class Checkers
   {

   static Saveboard Board;
   static char[,] Area;
   static bool choose = true;

   static void DrawBoard(bool firstTime)
   {
   //only need to do some things the first time the board is drawn

   const int X = 8;
   const int Y = 8;
   int num = 8;

   if (firstTime) Console.Clear();

   // save cursor position
   int origRow = Console.CursorTop;
   int origCol = Console.CursorLeft;

   // reset to 0,0
   Console.SetCursorPosition(0, 0);

   for (int i = 0; i < X; i++)
   {
   for (int y = 0; y < Y; y++)
   {
   Console.Write(Area[i, y]);
   }
   if (firstTime)
   {
   Console.WriteLine(num);
   num--;
   }
   else
   {
   Console.WriteLine();
   }
   }

   if (firstTime) Console.WriteLine("ABCDEFGH");

   if (choose)
   {
   Console.SetCursorPosition(0, 10);
   Console.WriteLine("Choose your figurine");
   }
   // restore cursor postion
   Console.CursorTop = origRow;
   Console.CursorLeft = origCol;
   }

   public static void Keys()
   {
   bool redraw = false;
   int col = 0;
   int row = 0;

   while (true)
   {
   var ch = Console.ReadKey().Key;

   switch (ch)
   {

   case ConsoleKey.RightArrow:

   Area = Board.MoveRight(out col, out row, out redraw);
   break;

   case ConsoleKey.DownArrow:

   Area = Board.MoveDown(out col, out row, out redraw);
   break;

   case ConsoleKey.LeftArrow:

   Area = Board.MoveLeft(out col, out row, out redraw);
   break;
   case ConsoleKey.UpArrow:

   Area = Board.MoveUp(out col, out row, out redraw);
   break;

   case ConsoleKey.Enter:

   Area = Board.EnterPressed(out col, out row, out redraw, out choose);
   break;
   }

   if (redraw) DrawBoard(false);
   Console.SetCursorPosition(col, row); // in case it's not in the right position following the move
   }
   }

   static void Main()
   {
   Board = new Saveboard();
   Area = Board.InitializeBoard();
   DrawBoard(true);
   Console.ReadKey(true);
   Keys();
   }
   }
}
Adam15y ago
I though that it woulg be condition like if(Area[ypos,xpos] == Area[ypos+1,xpos]) but it doeasnt work.Can u see some mistake why?I want save Symbols only to Area[ypos + 1,xpos], somethink like If Area[2,xpos] == Symbol , Symbol could save only in Area[3,xpos] but it doestn work
Adam15y ago
Ive done it another way.That I dont draw symbol where I move with cursor. Just mark symbol which u want move with, and then u press enter to square where you want to save the symbol. It works good. But now I want to write some lines when pick is true and false. For example when pick is true I want to write line:'Choose your figurine' under the board. But u said me that I cant add lines like Console.Writeline to DLL. So how can I do it? and Ive also added that symbols can only stand on squares where is 'Y'. It ensure me that symbols can move only at diagonals. But I dont know how to ensure that symboles can move only one square forward, because only Queen can move more. And What I have really no idea is how can I eat enemys figurine(some condition like, if there is a enemys figurine infornt of me, I can move forvard 2 squares and his figurine will disappear). I think the code will be all in method EnterPressed when pick is false. Really thanks. Below is how the code lookes now(just changed parts):

void Checkerboard()
{
for (int i = 0; i < X; i++)
{
for (int y = 0; y < Y; y++)
{
if (switcher % 2 == 0)
Area2[i, y] = 'X';
else
Area2[i, y] = 'Y';
switcher++;
}
switcher++;
}

}

For all arrows the same change

public char[,] MoveRight(out int col, out int row, out bool redraw)
{
if (xpos + 1 == X)
{
redraw = true;
}
else if (pick)
{
xpos++;
redraw = true;
}
else
{
xpos++;
redraw = true;
}
col = xpos;
row = ypos;
return Area;
}

public char[,] EnterPressed(out int col, out int row, out bool redraw)
{
if (pick == true && Area[ypos, xpos] == Symbol)
{
Area[ypos, xpos] = Area2[ypos, xpos];
redraw = false;
pick = false;
}
else if (pick == false && Area[ypos, xpos] == 'Y')
{

redraw = true;
Area[ypos, xpos] = Symbol;
pick = true;
}
else
redraw = false;
col = xpos;
row = ypos;
return Area;
}
Vulpes15y ago
I just don't know how you can do it unless Area2, or some array, stores the state of the board before the move.

The problem is that the current square already contains 'Symbol' so when you move it, there's no way of telling whether or not there was another Symbol already there without consulting Array2. Perhaps you need three arrays - the initial state, the state when symbols are added or permanently moved and the current state as the cursor is moved around?
Adam15y ago
I think that Area2 shoul be just clear board, because when it is like now, there only exist initial board, so i cant 'coninue playing' game.I think that the problem is somewhere in else condition when pick = false, it works good until it steps into square when is symbol, so Area2 shouldnt equal Area when cursor step on square with symbol. So where is square with Symbol it should redraw just Area or somethink like this. Have u got any idea? Or can you correct my idea
Vulpes15y ago
The reason it's not working when you delete Board.Checkerboard() is because that line is simultaneosly initializing Array2 in the dll. If you change it as follows, then it should still work, though it may not solve the other problems - still, one step at a time :)

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using ClassLibrary1;

namespace Checkers
{
   class Checkers
   {

   static Saveboard Board;
   static char[,] Area;
   static char[,] Area2; // delete this line

   static void DrawBoard(bool firstTime)
   {
   //only need to do some things the first time the board is drawn

   const int X = 8;
   const int Y = 8;
   int num = 8;

   if (firstTime) Console.Clear();

   // save cursor position
   int origRow = Console.CursorTop;
   int origCol = Console.CursorLeft;

   // reset to 0,0
   Console.SetCursorPosition(0, 0);

   for (int i = 0; i < X; i++)
   {
   for (int y = 0; y < Y; y++)
   {
   Console.Write(Area[i, y]);
   }
   if (firstTime)
   {
   Console.WriteLine(num);
   num--;
   }
   else
   {
   Console.WriteLine();
   }
   }

   if (firstTime) Console.WriteLine("ABCDEFGH");

   // restore cursor postion
   Console.CursorTop = origRow;
   Console.CursorLeft = origCol;
   }

   public static void Keys()
   {
   bool redraw = false;
   int col = 0;
   int row = 0;

   while (true)
   {
   var ch = Console.ReadKey().Key;

   switch (ch)
   {

   case ConsoleKey.RightArrow:

   Area = Board.MoveRight(out col, out row, out redraw);
   break;

   case ConsoleKey.DownArrow:

   Area = Board.MoveDown(out col, out row, out redraw);
   break;

   case ConsoleKey.LeftArrow:

   Area = Board.MoveLeft(out col, out row, out redraw);
   break;
   case ConsoleKey.UpArrow:

   Area = Board.MoveUp(out col, out row, out redraw);
   break;

   case ConsoleKey.Enter:

   Area = Board.EnterPressed(out col, out row, out redraw);
   break;
   }

   if (redraw) DrawBoard(false);
   Console.SetCursorPosition(col, row); // in case it's not in the right position following the move
   }
   }

   static void Main()
   {
   Board = new Saveboard();
   Area = Board.InitializeBoard();
   Area2 = Board.Checkerboard(); // delete this line
   DrawBoard(true);
   Console.ReadKey(true);
   Keys();
   }
   }
}

Code for dll:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace ClassLibrary1
{
   public class Saveboard
   {
   const int X = 8;
   const int Y = 8;
   char[,] Area = new char[X, Y];
   char[,] Area2 = new char[X, Y];
   int switcher = 0;
   char Symbol = (char)5;
   char Symbol2 = (char)6;
   bool pick = true;
   int xpos = 0;
   int ypos = 0;

   public char[,] InitializeBoard()
   {

   for (int i = 0; i < X; i++)
   {
   for (int y = 0; y < Y; y++)
   {
   if (switcher % 2 == 0)
   Area[i, y] = 'X';
   else
   Area[i, y] = 'Y';
   switcher++;
   }
   }
   Area[0, 1] = Symbol;
   Area[0, 3] = Symbol;
   Area[0, 5] = Symbol;
   Area[0, 7] = Symbol;
   Area[1, 0] = Symbol;
   Area[1, 2] = Symbol;
   Area[1, 4] = Symbol;
   Area[1, 6] = Symbol;
   Area[2, 1] = Symbol;
   Area[2, 3] = Symbol;
   Area[2, 5] = Symbol;
   Area[2, 7] = Symbol;
   Area[4, 1] = Symbol2;
   Area[4, 4] = Symbol2;
   Area[5, 2] = Symbol2;
   Checkerboard(); // insert this line

   return Area;
   }

   public void Checkerboard() // this method has been changed
   {
   for (int i = 0; i < X; i++)
   {
   for (int y = 0; y < Y; y++)
   {
   Area2[i, y] = Area[i, y];
   }
   }
   }

   public char[,] MoveRight(out int col, out int row, out bool redraw)
   {
   if (xpos + 1 == X)
   {
   redraw = true;
   }
   else if (pick)
   {
   xpos++;
   redraw = true;
   }
   else
   {
   Area[ypos, xpos] = Area2[ypos, xpos];
   xpos++;
   redraw = true;
   Area[ypos, xpos] = Symbol;
   }
   col = xpos;
   row = ypos;
   return Area;
   }

   public char[,] MoveDown(out int col, out int row, out bool redraw)
   {
   if (ypos + 1 == Y)
   {
   redraw = true;
   }
   else if (pick == true)
   {
   ypos++;
   redraw = true;
   }
   else
   {
   Area[ypos, xpos] = Area2[ypos, xpos];
   ypos++;;
   redraw = true;
   Area[ypos, xpos] = Symbol;
   }
   col = xpos;
   row = ypos;
   return Area;
   }

   public char[,] MoveLeft(out int col, out int row, out bool redraw)
   {
   if (xpos - 1 < 0)
   {
   redraw = true;
   }
   else if (pick == true)
   {
   xpos--;
   redraw = true;
   }
   else
   {
   Area[ypos, xpos] = Area2[ypos, xpos];
   xpos--;
   redraw = true;
   Area[ypos, xpos] = Symbol;
   }
   col = xpos;
   row = ypos;
   return Area;
   }

   public char[,] MoveUp(out int col, out int row, out bool redraw)
   {
   if (ypos - 1 < 0)
   {
   redraw = true;
   }
   else if (pick == true)
   {
   ypos--;
   redraw = true;
   }
   else
   {
   Area[ypos, xpos] = Area2[ypos, xpos];
   ypos--;
   Area[ypos, xpos] = Symbol;
   redraw = true;
   }
   col = xpos;
   row = ypos;
   return Area;
   }

   public char[,] EnterPressed(out int col, out int row, out bool redraw)
   {
   if (pick == true && Area[ypos, xpos] == Symbol)
   {
   redraw = false;
   pick = false;
   }
   else if (pick == false && Area2[ypos, xpos] != Symbol)
   {

   redraw = true;
   Area[ypos, xpos] = Symbol;
   pick = true;
   }
   else
   redraw = false;
   col = xpos;
   row = ypos;
   return Area;
   }
   }
   }
Adam15y ago
If i delete Area2 = Board.Checkerboard(); from .exe it doesnt work. When I press enter and move it lefts enpty squares behind curosr. And when I make Area2 the same az Area, the problem still exist, it still deletes symbols. I don't know why it is happening becouse before when I did without dll it works. Can u pls see at the old code, without dll, what is different? I really dont know. Old code is below.

void Checkerboard()
        {
            Cursor();
            for (int i = 0; i < X; i++)
            {
                for (int y = 0; y < Y; y++)
                {
                    if (switcher % 2 == 0)
                        Area[i, y] = 'X';
                    else
                        Area[i, y] = 'Y';
                    switcher++;
                    Area[0, 1] = Symbol;
                    Area[0, 3] = Symbol;
                    Area[0, 5] = Symbol;
                    Area[0, 7] = Symbol;
                    Area[1, 0] = Symbol;
                    Area[1, 2] = Symbol;
                    Area[1, 4] = Symbol;
                    Area[1, 6] = Symbol;
                    Area[2, 1] = Symbol;
                    Area[2, 3] = Symbol;
                    Area[2, 5] = Symbol;
                    Area[2, 7] = Symbol;
                    Area[4, 1] = Symbol2;
                    Area[4, 4] = Symbol2;
                    Area[5, 2] = Symbol2;

                    Console.Write(Area[i, y]);
                }
                Console.WriteLine(num);
                num--;
                switcher++;
            }
            Console.WriteLine("ABCDEFGH");
        }

        void Checkerboard2()
        {
            for (int i = 0; i < X; i++)
            {
                for (int y = 0; y < Y; y++)
                {
                    if (switcher % 2 == 0)
                        Area2[i, y] = 'X';
                    else
                        Area2[i, y] = 'Y';
                    switcher++;
                }
                switcher++;
            }

        }

        void Cursor()
        {
            bool saveCursorVisibile;
            int saveCursorSize;

            Console.CursorVisible = true;
            saveCursorVisibile = Console.CursorVisible;
            saveCursorSize = Console.CursorSize;
            Console.CursorSize = 100;
        }

        void Keys()
        {
            while (true)
            {

                var ch = Console.ReadKey().Key;
                switch (ch)
                {

                    case ConsoleKey.Enter:
                        {
                            if (Area[ypos, xpos] == Symbol && pick == false)
                            {
                                pick = true;
                                Area[ypos, xpos] = Area2[ypos, xpos];
                            }
                            else if (Area[ypos, xpos] != Symbol && pick == true)
                            {
                                Area[ypos, xpos] = Symbol;
                                pick = false;
                            }
                            break;
                        }
                    case ConsoleKey.UpArrow:
                        {
                            if (ypos - 1 < 0)
                            {
                                Console.SetCursorPosition(xpos, ypos);
                                Console.Write(Area[ypos, xpos]);
                                break;
                            }

                            Console.SetCursorPosition(xpos, ypos);
                            Console.Write(Area[ypos, xpos]);
                            ypos--;
                            break;
                        }
                    case ConsoleKey.DownArrow:
                        {
                            if (ypos + 1 == Y)
                            {
                                Console.SetCursorPosition(xpos, ypos);
                                Console.Write(Area[ypos, xpos]);
                                break;
                            }

                            Console.SetCursorPosition(xpos, ypos);
                            Console.Write(Area[ypos, xpos]);
                            ypos++;
                            break;
                        }
                    case ConsoleKey.LeftArrow:
                        {
                            if (xpos - 1 < 0)
                            {
                                Console.SetCursorPosition(xpos, ypos);
                                Console.Write(Area[ypos, xpos]);
                                break;
                            }

                            Console.SetCursorPosition(xpos, ypos);
                            Console.Write(Area[ypos, xpos]);
                            xpos--;
                            break;
                        }
                    case ConsoleKey.RightArrow:
                        {
                            if (xpos + 1 == X)
                            {
                            Console.SetCursorPosition(xpos, ypos);
                            Console.Write(Area[ypos, xpos]);
                            break;
                            }

                                Console.SetCursorPosition(xpos, ypos);
                                Console.Write(Area[ypos, xpos]);
                            xpos++;
                            break;
                        }
                }
                Console.SetCursorPosition(xpos, ypos);
                if (pick == true)
                {
                    Console.Write(Symbol);
                    Console.SetCursorPosition(xpos, ypos);
                }
            }
Vulpes15y ago
The problem seems to be that, when Area2 is used to restore a particular square, it doesn't 'know' whether there was a symbol there before because it's only been initialized to the board without any symbols on.

So, I'd have thought that Area2 should reflect the initial state of Area.

Also, the exe doesn't need to know anything about Area2 - this is purely for the dll's use - though it's not doing any harm as it stands.