Different approach for a repetitive task

Guest User

I'm looking for an alternative towards a process that takes too much code and generates significant overhead...

This code fills in a Chartview (LineChart) and in order to display the progression of 6 different "Areas" it runs a query 6 times and add the series 6 times...

public static void FillLineChart(ChartView chartView, CheckedDropDownList checkedDropDown, string dateFrom, string dateTo)
{
foreach (var i in checkedDropDown.CheckedItems)
{
var iindex = i.RowIndex + 1;
if (iindex == 1)
{
LineSeries crime = new LineSeries();
FunctionsDAL cr = new FunctionsDAL();
foreach (var caseType in cr.ListCases(1, dateFrom, dateTo))
{
crime.DataPoints.Add(new CategoricalDataPoint(caseType.IncrementalTotal,
CultureInfo.CurrentCulture.DateTimeFormat.GetMonthName(caseType.MonthNum)));
}
chartView.Series.Add(crime);
crime.LegendTitle = "Crime";
crime.Spline = true;
}
else if (iindex == 2)
{
}
else if (iindex == 3)
{
}
// The same 3 more times
}
}

How could I shorten up this process? or is this the way is supposed to be working?

Regards.

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Guest User10y ago
I just managed to reduce the code to a few lines:
publicstaticvoidTest(RadChartViewchartView,RadCheckedDropDownListcheckedDropDown,stringdateFrom,stringdateTo)
{
foreach(variincheckedDropDown.CheckedItems)
{
LineSerieslineSeries=newLineSeries();
foreach(varcaseTypeinFunctionsDAL.AmountsPerCase(i.Index+1,dateFrom,dateTo))
{
lineSeries.DataPoints.Add(newCategoricalDataPoint(caseType.IncrementalTotal,CultureInfo.CurrentCulture.DateTimeFormat.GetMonthName(caseType.MonthNum)));
}
chartView.Series.Add(lineSeries);
lineSeries.LegendTitle=i.ToString();
lineSeries.Spline=true;
}
}
theLizard10y ago
The only thing that is different that I see is the LegendTitle, in this case you could instead of using foreach you could use a for loop but this would depend on the consistency of your iindex ( var iindex = i.RowIndex + 1;)
string[] title = new string[] { "Crime", "Social", "Civil" };

for (int i = 0; i < c.CheckedItems.Count; i++)
{
LineSeriescrime = newLineSeries();
FunctionsDALcr = newFunctionsDAL();
foreach (varcaseTypeincr.ListCases(1,dateFrom,dateTo))
{
crime.DataPoints.Add(newCategoricalDataPoint(caseType.IncrementalTotal,
CultureInfo.CurrentCulture.DateTimeFormat.GetMonthName(caseType.MonthNum)));
}
chartView.Series.Add(crime);
crime.LegendTitle = titil[i];
crime.Spline = true;
}
This approach would eliminate any else if you have.
Guest User10y ago
Well its just exactly the same:
foreach(variincheckedDropDown.CheckedItems)
{
    variindex=i.RowIndex+1;
    if(iindex==1)
    {
        LineSeriescrime=newLineSeries();
        FunctionsDALcr=newFunctionsDAL();
        foreach(varcaseTypeincr.ListCases(1,dateFrom,dateTo))
        {
            crime.DataPoints.Add(newCategoricalDataPoint(caseType.IncrementalTotal,
            CultureInfo.CurrentCulture.DateTimeFormat.GetMonthName(caseType.MonthNum)));
        }
        chartView.Series.Add(crime);
        crime.LegendTitle="Crime";
        crime.Spline=true;
    }
    elseif(iindex==2)
    {
        LineSeriessocial=newLineSeries();
        FunctionsDALso=newFunctionsDAL();
        foreach(varcaseTypeinso.ListCases(1,dateFrom,dateTo))
        {
            social.DataPoints.Add(newCategoricalDataPoint(caseType.IncrementalTotal,
            CultureInfo.CurrentCulture.DateTimeFormat.GetMonthName(caseType.MonthNum)));
        }
        chartView.Series.Add(social);
        social.LegendTitle="Social";
        social.Spline=true;
    }
    elseif(iindex==3)
    {
        LineSeriescivil=newLineSeries();
        FunctionsDALci=newFunctionsDAL();
        foreach(varcaseTypeinci.ListCases(1,dateFrom,dateTo))
        {
            civil.DataPoints.Add(newCategoricalDataPoint(caseType.IncrementalTotal,
            CultureInfo.CurrentCulture.DateTimeFormat.GetMonthName(caseType.MonthNum)));
        }
        chartView.Series.Add(civil);
        civil.LegendTitle="Civil";
        civil.Spline=true;
    }

    [...]

}
Nitin Sontakke10y ago
Hello,
May be you should have also given the code for iindex == 2 so that we would know what is common (and hence repeated) and what is different and then give a solution.