How can I make this more simple?

Jason Akkerman

I have these two methods and as you can see it is just repeated code. How can I merge these into one method and pass an object type as a parameter?

 private void addButton (string Text, Point Location, Size Size)
        {
            Button b = new Button();

            b.Name = Text;
            b.Text = Text;

            b.Location = Location;
            b.Size = Size;

            this.Controls.Add(b);
        }

        private void addLabel(string Text, Point Location, Size Size)
        {
            Label l = new Label();

            l.Name = Text;
            l.Text = Text;

            l.Location = Location;
            l.Size = Size;

            this.Controls.Add(l);
        }

Thanks in advance. =)

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Sam Hobbs16y ago
Accepted answer
Buttons and Labels are Controls. So the additional parameter would be a Control type. Then to call the function, you might have to do a cast: I forget if that would be necessary so just try calling the function with a Button or Label and if the compiler complains that they are not a Control then cast them to be a Control.
Sam Hobbs16y ago
I am happy to help and thank you for understanding what I meant.
Jason Akkerman16y ago
Thanks Sam, that works. No casting needed as Button and Label inherit from Control. (polymorphism right?)

addControl("TEST", new Point(450, 10), new Size(100, 25), new Button());

private void addControl(string Text, Point Location, Size Size, Control C)
        {
            C.Name = Text;
            C.Text = Text;

            C.Location = Location;
            C.Size = Size;

            this.Controls.Add(C);
        }
Manikavelu Velayutham16y ago
private void addButtonOrLabel(string Text, Point Location, Size Size, bool Isbutton)
        {

Control ctl = new Control();
if (Isbutton!=true)
ctl = new Label();
else
ctl = new Button();

            ctl.Name = Text;
            ctl.Text = Text;

            ctl.Location = Location;
            ctl.Size = Size;

            this.Controls.Add(ctl);
        }