Need help with checkers game

Adam

Hi, I need advice for my game checkers please. Below is my code. When you pull enter you choose figurine and you can move with it on checkerboard and then save it to new position. It worked good with figurine on start position Area[0,0], but when I add new figurine on position Area[0,2] it disappear when cursor crosses it. Why it works only with figurine on position [0,0] ??

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace Checkers
{
class Checkers
{
const int X = 8;
const int Y = 8;
int switcher = 0;
int num = 8;
int xpos = 0;
int ypos = 0;
bool pick = false;
char[,] Area = new char[X, Y];
char[,] Area2 = new char[X, Y];
char Symbol = (char)5;

void Checkerboard()
{
Cursor();
for (int i = 0; i < X; i++)
{
for (int y = 0; y < Y; y++)
{
if (switcher % 2 == 0)
Area[i, y] = 'X';
else
Area[i, y] = 'Y';
switcher++;
Area[0, 0] = Symbol;
Area[0, 2] = Symbol;
Console.Write(Area[i, y]);
}
Console.WriteLine(num);
num--;
switcher++;
}
Console.WriteLine("ABCDEFGH");
if (pick == false)
Console.Write("Vyber figurku");
if(pick==true)
Console.Write("Vyber misto a uloz");
}

void Checkerboard2()
{
for (int i = 0; i < X; i++)
{
for (int y = 0; y < Y; y++)
{
if (switcher % 2 == 0)
Area2[i, y] = 'X';
else
Area2[i, y] = 'Y';
switcher++;
}
switcher++;
}

}

void Cursor()
{
bool saveCursorVisibile;
int saveCursorSize;

Console.CursorVisible = true;
saveCursorVisibile = Console.CursorVisible;
saveCursorSize = Console.CursorSize;
Console.CursorSize = 100;
}

void Keys()
{
while (true)
{

var ch = Console.ReadKey().Key;
switch (ch)
{

case ConsoleKey.Enter:
if (Area[xpos, ypos] == Symbol && pick == false)
{
pick = true;
}
if (Area[xpos, ypos] != Symbol && pick == true)
{
Area[xpos, ypos] = Symbol;
pick = false;
}
break;

case ConsoleKey.UpArrow:
{
if (ypos - 1 < 0)
break;

Console.SetCursorPosition(xpos, ypos);
Console.Write(Area[xpos, ypos]);
ypos--;
break;
}
case ConsoleKey.DownArrow:
{
if (ypos + 1 == Y)
break;

Console.SetCursorPosition(xpos, ypos);
Console.Write(Area[xpos, ypos]);
ypos++;
break;
}
case ConsoleKey.LeftArrow:
{
if (xpos - 1 < 0)
break;

Console.SetCursorPosition(xpos, ypos);
Console.Write(Area[xpos, ypos]);
xpos--;
break;
}
case ConsoleKey.RightArrow:
{
if (xpos + 1 == X)
break;

Console.SetCursorPosition(xpos, ypos);
Console.Write(Area[xpos, ypos]);
xpos++;
break;
}
}
Console.SetCursorPosition(xpos, ypos);
if (pick == true)
{
Area[xpos, ypos] = Area2[xpos, ypos];
Console.Write(Symbol);
Console.SetCursorPosition(xpos, ypos);
}
}
}

static void Main()
{
Console.Clear();
Checkers check = new Checkers();
check.Checkerboard();
check.Checkerboard2();
Console.SetCursorPosition(0, 0);
check.Keys();
}
}
}

42 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes15y ago
I don't think there's ever been a correct answer; there's always been some problem which an attempt to solve has led to another problem and so on.

So, I wouldn't bother marking anything as a 'correct answer'.
Adam15y ago
OK should I mark correct answer ? If yes , write somethink like that all answers are correct and I ll mark it.
Vulpes15y ago
Adam,

I think it would be a good idea if your started a new thread and posted the code you have so far for the dll and exe.

This thread has become so long that it's virtually impossible now for anyone to figure out anything!
Adam15y ago
yes this problem is for every arrow. when I move arrows to every diretion it just replace cursor and anythink is good. But when the cursor is on Symbol and I press Enter, it draws Symbol just when the cursor is, rest of the board is the same, some its also OK. But when I move with Symbol to the square where is another Symbol, and move next, it deletes the symbol when I ve been before, but Symbol is still in curosr so its OK, there is just the one problem that it deletes symbols that I acrossed. Maybe u should know that Area2 is just board without Symbols, just checkerboard.
Vulpes15y ago
Well, I'll tell you what I think is happening in the 'else' clause (when you're not at the left edge of the board and pick is false):

1. You're resetting the currrent square (before the move) to what it was at the start of the game.
2. You're moving left (by decrementing xpos).
3. You're setting redraw to true.
4. You're setting the current square (after the move) to 'Symbol'.

On the face of it, that seems OK to me. I can't see how you can be deleting everything because you're always restoring the current square before making the move.

Are you sure that the problem doesn't lie in one of the other cursor movement routines?
Adam15y ago
OK now it doesnt replicate symboles, it goes good, but now it delete when Symbol stand to onother. So when I go to evry square in board, at the end the is only one symbol becouse it 's deleted everything. can u help me to solve it pls? Below is code of one of the arrows:
I think problem is somewhere in else condition, and I dont understand if I change order of lines it works differently. Why? the return gives back only Aray.

public char[,] MoveLeft(out int col, out int row, out bool redraw)
{
if (xpos - 1 < 0)
{
redraw = true;
}
else if (pick == true)
{
xpos--;
redraw = true;
}
else
{
Area[ypos, xpos] = Area2[ypos, xpos];
xpos--;
redraw = true;
Area[ypos, xpos] = Symbol;
}
col = xpos;
row = ypos;
return Area;
}
Suthish Nair15y ago
waw, a big thread.
Adam15y ago
I have made Area2 anet put Area[ypos, xpos] = Area2[ypos, xpos]; to Enter method. Now when I do one move, it works, but after second move it starts to copy symbol again. This symbol dont disappear. I ve tried to put this: Area[ypos, xpos] = Area2[ypos, xpos]; also to every arrow method but it doesnt work. Can u give me some advice pls? thx
Vulpes15y ago
As before, you'll need to have a second checkerboard, Area2, in the dll to store the opening postion of the board in case you need to restore this later - just populate it at the same time as you populate Area in the InitializeBoard() method.

To ensure the cursor doesn't go off the board, you'll need to modify the MoveRight method as follows. The exe should then put the cursor back in the correct place:

public char[,] MoveRight(out int col, out int row, out bool redraw)
{
   if (xpos + 1 == X)
   {
   col = xpos;
   row = ypos;
   redraw = false;
   }
   else if (pick)
   {
   xpos++;
   col = xpos;
   row = ypos;
   redraw = false;
   }
   else
   {
   xpos++;
   col = xpos;
   row = ypos;
   redraw = true;
   Area[xpos, ypos] = Symbol;
   }
   return Area;
}
Adam15y ago
How can I write somethink if it cant be somethink. I want to xpos never could be bigger then 8, for Right arrow.
because befeore, without dll, where it was bigger I jsut put there break; so how can I use break in if ?? and other problem is when I pull Enter it starts draw symbol to every place I move, before I had second chceckerboard so should I do it the same way or other? and if i shoul use the same way I've just tried to put code below to dll and in Enter method add Area[xpos,ypos] = Area2[xpos,ypos] and it doesnt work. Area2 maybe have to be created first somewhere but I dont know where exactly. thx

void Checkerboard2()
        {
            for (int i = 0; i < X; i++)
            {
                for (int y = 0; y < Y; y++)
                {
                    if (switcher % 2 == 0)
                        Area2[i, y] = 'X';
                    else
                        Area2[i, y] = 'Y';
                    switcher++;
                }
                switcher++;
            }

        }
Vulpes15y ago
It doesn't work there because the compiler can't be sure that you're assigning to the 'out' parameters in all possible code paths - this is because there's an 'else if' but no final 'if'. I'd do intead:

public char[,] EnterPressed(out int col, out int row, out bool redraw)
{
if (pick == true && Area[xpos, ypos] == Symbol)
{
redraw = false;
pick = false;
}
else if (pick == false && Area[xpos, ypos] != Symbol)
{
Area[xpos, ypos] = Symbol;
redraw = true;
pick = true;
}
else
{
redraw = false;
}
col = xpos; // cursor not moving
row = ypos; // ditto
return Area;
}

Checking that the cursor doesn't go off the board, should be done in the dll. If it has done, then you need to move it back by setting row and col to what they were before in the dll. The exe will then place the cursor back in the correct place.
Adam15y ago
I dont know why it doeastn work for Enter:
public char[,] EnterPressed(out int col, out int row, out bool redraw)
              {
                  if (pick == true && Area[xpos, ypos] == Symbol)
                  {
                      col = xpos;
                      row = ypos;
                      redraw = false;
                      pick = false;
                  }
                  else if (pick == false && Area[xpos, ypos] != Symbol)
                  {
                      col = xpos;
                      row = ypos;
                      Area[xpos, ypos] = Symbol;
                      redraw = true;
                      pick = true;
                  }
                  return Area;
              }

I think there is all what should be and second think when I press right arrow it does nothink just after second click it works. and the limit about border of board should be written in exe or in dll? I mean that the cursor stop on the last square of array. thx
Vulpes15y ago
You don't need to return the 'out' parameters, which is done automatically - you only need to return Area:

public char[,] MoveRight(out int col, out int row, out bool redraw)
{
    if (pick)
    {
     xpos++;
      col = xpos;
      row = ypos;
      redraw = false;
    }
    else
    {
      xpos++;
      col = xpos;
      row = ypos;
      redraw = true;
      Area[xpos, ypos] = Symbol;
    }
    return Area;
}

Also try to use if/else where possible rather than two if's as the compiler can then follow the possible code paths more easily.

The good news is that I think you're starting to get the jist of this :)
Adam15y ago
How can I return 4 values??
public char[,] MoveRight(out int col, out int row, out bool redraw)
        {
            if (pick == true)
            {
                xpos++;
                col = xpos;
                row = ypos;
                redraw = false;
                return ??;
            }
                if (pick == false)
                {
                    xpos++;
                    col = xpos;
                    row = ypos;
                    redraw = true;
                    Area[xpos, ypos] = Area[row, col] = Symbol;
                    return ??;
                }
            }

Error    1    'ClassLibrary1.Saveboard.MoveRight(out int, out int, out bool)': not all code paths return a value
Vulpes15y ago
When you need to return more than one value from a method, you can use 'out' parameters. These are variables which you pass to the method and the method has to assign something to them before it returns, otherwise you'll get a compiler error. The calling code will then be able to use those variables with the values they've been given.

So before the method returns, you have to make sure that all these have been assigned to:

row - the row position of the cursor
col - the column position of the cursor
redraw - whether the board needs redrawing or not

You always need to return the Area array (not just an element of it) whether the board needs redrawing or not.

The dll class also needs to keep track of where the cursor should be (use your xpos and ypos variables) and keep these synchronized with what it's passing back to the .exe. So, you should manipulate xpos and ypos first and then assign them to row and col.
Adam15y ago
Why there is out int col, I mean OUT? and I dont know waht shoul I return. I know that Area but how shoul I write it. This is my code for enter and right arrow:
public char[,] MoveRight(out int col, out int row, out bool redraw)
        {
            if (pick == true)
            {
                row++;
                return Area[row, col];

            }
            if (pick == false)
            {
                row++;
                Area[row, col] = Symbol;
            }
            redraw = true;
            return Area;
        }

        public char[,] EnterPressed(out int col, out int row, out bool redraw)
        {
            if (pick == true && Area[row, col] == Symbol)
            {
                pick = false;
            }
            if (pick == false && Area[row, col] != Symbol)
            {
                Area[row, col] = Symbol;
                redraw = true;
                pick = true;
            }
            return Area;
        }

There are errors like: - The out parameter 'col' must be assigned to before control leaves the current method
- Use of unassigned out parameter 'col'
- Cannot implicitly convert type 'char' to 'char[*,*]'
Can u please help me understand it? Thanks
Vulpes15y ago
The Keys method should still be in the .exe because it's interacting with the user but you'll need to rewrite it so that it can communicate moves to the class in the dll. Something like this:

   public static void Keys()
   {
   bool redraw;
   int col, row;

   while (true)
   {
   var ch = Console.ReadKey().Key;

   switch (ch)
   {
   case ConsoleKey.Enter:

   Area = Checkers.EnterPressed(out col, out row, out redraw);
   break;

   case ConsoleKey.RightArrow :

   Area = Checkers.MoveRight(out col, out row, out redraw);
   break;
   }

   if (redraw) DrawBoard(false);
   Console.SetCursorPosition(col, row); // in case it's not in the right position following the move
   }
   }

The class in the dll then needs to add the appropriate methods:

   public char[,] EnterPressed(out int col, out int row, out bool redraw)
   {
   // decide what changes (if any) are needed to Area
   // if a redraw is necessary set redraw to true, otherwise false
   // decide what should now be the col and row positions of the 'current' square and set these accordingly
   // return Area to caller
   }

   public char[,] MoveRight(out int col, out int row, out bool redraw)
   {
   // ditto
   }

You might find it easier to start again and think out these methods from scratch. As you're going to be redrawing the board after each move, then a lot of the previous complications should disappear.

You need to figure out what should be in each square of the board after a move left, right, up or down or pressing enter and set Area[i,j] to the appropriate character. You also need need to keep track of the 'current square' using your 'xpos and 'ypos' variables, whether 'pick' is on/off and update these following the move.
Adam15y ago
So every time when I move it shoul save to InitializeBoard() and then in .exe redraw the board. I put whole Keys() method to dll but I dont know how it shoul redraw in .exe because it is method without end there is still true. Can you please show me how to do it for RighArrow please? Below is part of the Key() method. thanks

public void Keys()
        {
            while (true)
            {

                var ch = Console.ReadKey().Key;
                switch (ch)
                {

                    case ConsoleKey.Enter:
                        {
                            if (Area[ypos, xpos] == Symbol && pick == false)
                            {
                                pick = true;
                                Area[ypos, xpos] = Area2[ypos, xpos];
                            }
                            else if (Area[ypos, xpos] != Symbol && pick == true)
                            {
                                Area[ypos, xpos] = Symbol;
                                pick = false;
                            }
                            break;
                        }


                    case ConsoleKey.RightArrow:
                        {
                            if (xpos + 1 == X)
                            {
                                Console.SetCursorPosition(xpos, ypos);
                                Console.Write(Area[ypos, xpos]);
                                break;
                            }

                            Console.SetCursorPosition(xpos, ypos);
                            Console.Write(Area[ypos, xpos]);
                            xpos++;
                            break;
                        }
                }
                Console.SetCursorPosition(xpos, ypos);
                if (pick == true)
                {
                    Console.Write(Symbol);
                    Console.SetCursorPosition(xpos, ypos);
                }
            }
        }
Vulpes15y ago
A static method is a method which applies to a class as a whole rather than to a particular instance of that class.

I used static methods and fields in the .exe so that you wouldn't have to bother creating an instance of the PlayCheckers class since (presumably) you'll only be creating one game at a time. However, if you're more comfortable using instance methods, then by all means do so.

The DrawBoard() method is designed not only to draw the board the first time but every time there's a move.

You only need one dll here. Every time there's a move, the .exe should communicate that move to the class in the dll (by calling an appropriate method) so that it can change the state of the array and pass it back to the .exe which will then redraw the board.

You therefore need to add some public methods to the class in the dll to cater for each possible move.

If you're developing this program in Visual Studio, then the "Press any key to continue ...." message should only appear when you "start without debugging" and I don't think there's a way to prevent it. It won't appear if you "start debugging" and you then need to add Console.ReadLine() or Console.ReadKey(true) to prevent the console from closing before you've read the output.
Adam15y ago
Can u explain me why you use static? I dont know the difference between static and normal methods. And Why do u use bool firstTime? it should work normally without bool, shouldnt it? Thank you a lot now I understand it. So now I will do DLL for movement and after every move I redraw board. So there will be another DLL with checkerboard to save current state of board? because this chceckerboard above is only for first state of checkerboard , for beginning of the game? I dont know if I shoul do DLL for each arrow separately or for all Keys() method. And can u please give me advice how to delete the line "Press any kay to continue..." in console. I ve made it through Console.Read(); but it isnt good i think.
Vulpes15y ago
All executable code needs to be within a method and shouldn't contain any Console.Write(Line)'s at all.

The class in the dll is to just keeping the state of the board and, each time a move is made, manipulating that state. When the state changes the array has to be passed back to the .exe so that it can redraw the board on the console or whatever surface is being used.

So all this needs to be inside an InitializeBoard() method, or whatever you want to call it:

// in the Check class of the dll

public char[,] InitializeBoard()
{
  for (int i = 0; i < X; i++)
  {
   for (int y = 0; y < Y; y++)
   {
   if (switcher % 2 == 0)
   Area[i, y] = 'X';
   else
   Area[i, y] = 'Y';
   switcher++;
   }
  }
  Area[0, 1] = Symbol;
  Area[0, 3] = Symbol;
  Area[0, 5] = Symbol;
  Area[0, 7] = Symbol;
  Area[1, 0] = Symbol;
  Area[1, 2] = Symbol;
  Area[1, 4] = Symbol;
  Area[1, 6] = Symbol;
  Area[2, 1] = Symbol;
  Area[2, 3] = Symbol;
  Area[2, 5] = Symbol;
  Area[2, 7] = Symbol;
  Area[4, 1] = Symbol2;
  Area[4, 4] = Symbol2;
  Area[5, 2] = Symbol2;

  return Area; // return array to caller
}

The .exe will now contain something like this:

using Checkerboard;

class PlayCheckers
{
   static Check Checkers; // use static field so available to all methods in class

   static char[,] Area; // ditto

   static void Main()
   {
   Checkers = new Check(); // create new Check object
   Area = Checkers.InitializeBoard(); // get initial state of board;
   DrawBoard(true); // draw initial board

   // code to get moves etc, relay to dll and redraw board when necessary
   }

   static void DrawBoard(bool firstTime)
   {
   //only need to do some things the first time the board is drawn

   const int X = 8;
   const int Y = 8;
   int num = 8;

   if (firstTime) Console.Clear();

   // save cursor position
   int origRow = Console.CursorTop
   int origCol = Console.CursorLeft

   // reset to 0,0
   Console.SetCursorPosition(0, 0);

   for (int i = 0; i < X; i++)
   {
   for (int y = 0; y < Y; y++)
   {
   Console.Write(Area[i, y]);
   }
   if (firstTime)
   {
   Console.WriteLine(num);
   num--;
   }
   else
   {
   Console.WriteLine();
   }
   }

   if (firstTime) Console.WriteLine("ABCDEFGH");

   // restore cursor postion
   Console.CursorTop = origRow;
   Console.CursorLeft = origCol;
   }

}

All the above is off the top of my head so don't be surprised if there are bugs.

So your Check class needs to have methods to manipulate the board for each possible move and return the state if it has changed
so that the .exe can redraw the board. The rules will be embedded in the way the methods in the dll work.

Are you getting the idea now?
Adam15y ago
So I shoul have DLL for: each arrow, Enter, checkerboard, cursor, const checkerboard, clear board, redraw board and for save current state of checkerboard??? And shere should I put rules later? thx
Adam15y ago
When I put Checkerboard to DLL it reports me 120 error... Dont know why. Below is my code in DLL

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace Checkerboard
{
    public class Check
    {
        const int X = 8;
        const int Y = 8;
        int switcher = 0;
        int num = 8;
        char[,] Area = new char[X, Y];
        char Symbol = (char)5;
        char Symbol2 = (char)6;
        //Cursor();
            for (int i = 0; i < X; i++)
            {
                for (int y = 0; y < Y; y++)
                {
                    if (switcher % 2 == 0)
                        Area[i, y] = 'X';
                    else
                        Area[i, y] = 'Y';
                    switcher++;
                    Area[0, 1] = Symbol;
                    Area[0, 3] = Symbol;
                    Area[0, 5] = Symbol;
                    Area[0, 7] = Symbol;
                    Area[1, 0] = Symbol;
                    Area[1, 2] = Symbol;
                    Area[1, 4] = Symbol;
                    Area[1, 6] = Symbol;
                    Area[2, 1] = Symbol;
                    Area[2, 3] = Symbol;
                    Area[2, 5] = Symbol;
                    Area[2, 7] = Symbol;
                    Area[4, 1] = Symbol2;
                    Area[4, 4] = Symbol2;
                    Area[5, 2] = Symbol2;

                    Console.Write(Area[i, y]);
                }
                Console.WriteLine(num);
                num--;
                switcher++;
            }
            Console.WriteLine("ABCDEFGH");
    }
}
Vulpes15y ago
I certainly wouldn't recommend that you ignore your prof, whether you think he's right or not. Redrawing the board after every move will be slow but, given the problems you've been having, should actually be easier to program!

So, I'd try and hive off the essence of the game (i.e. ignoring the UI aspects) into a dll as I illustrated in my previous post. I don't want to produce any code for this as you won't then get any benefit from thinking it out for yourself.

I'd then reprogram the console game using the dll to store and manipulate the state of the game but leaving the UI aspects (i.e. redrawing the board) to the exe.

Windows forms and console programming are completely different. With the former you're dealing with a graphical UI and with the latter a character based UI. Also Windows Forms applications are event driven - the program sits and waits for an event, processes it and waits for the next event. Console applications, on the other hand, generally 'poll' for console input, continually checking the input stream until keystrokes are received.

With modern tools such as the graphical designer in Visual Studio, writing Windows Forms applications is quite pleasant and they certainly look a lot better than console applications. There are many ways you could represent your checkerboard. One way would be to provide a grid of pictureboxes (a standard control used with WF) to represent the squares and then place images in these pictureboxes as the game progresses and pieces are moved. Once you've decided on a suitable UI, you can then use your dll to store and progress the state of the game.
Adam15y ago
OK I won't listen to prof I ll do it own way. So what can u recommend me? Can I finish my game in one class and then split it to Class librarys? and can u imply which code will be in DLLs? and after I finish it for console what will be different between console and windows form? I know there will be different in control, so for control there will be also DLL? I am confused. I dont know what exactly shoul I put into DLL. Can u show me some example, which code will be DLL? thanks
Vulpes15y ago
For how .dlls work, see this recent thread (http://www.c-sharpcorner.com/Forums/Thread/115173/using-dynamic-link-library-dll.aspx).

If you create a public class called CheckerBoard in your dll, then it will need a public property to expose the current state of the board as a rectangular array of characters.

You'll then need a public method (or methods) to process each move and change the state of the board accordingly and a method to clear the board may also be useful.

I think the .exe itself will need to provide an appropriate method to (re)draw the board as this will, of course, be completely different for console or windows forms applications though, frankly, any professional games programmer who found it necessary to redraw the whole board after each move would probably get the sack!
Adam15y ago
My prof. told me that it is only solution for Console application and I should split it to Class Librarys. And then just call it for Console and for Windows form applications. In console, every time when checkerboard is changed, console should draw new checkerboard with changes. Can you give me advice WHAT exactly I should put into Class Librarys, how to use them and explain me how it should work? thanks
Vulpes15y ago
Yes, you're right those two lines - although harmless - are superfluous and can be removed.

I was trying to do it slightly differently to start with and then forgot to remove them.
Adam15y ago
yes thanks it works. But lines: Console.SetCursorPosition(xpos, ypos); and continue; are useless, arent they? It works equally without them.
Vulpes15y ago
I see what you mean.

OK, let's have another go with this:

void Keys()
   {
   while (true)
   {

   var ch = Console.ReadKey().Key;
   switch (ch)
   {

   case ConsoleKey.Enter:
   if (Area[ypos, xpos] == Symbol && pick == false)
   {
   pick = true;
   Area[ypos, xpos] = Area2[ypos, xpos];
   Console.SetCursorPosition(xpos, ypos);
   continue;

   }
   else if (Area[ypos, xpos] != Symbol && pick == true)
   {
   Area[ypos, xpos] = Symbol;
   pick = false;
   }
   break;

   case ConsoleKey.UpArrow:
   {
   if (ypos - 1 < 0)
   break;

   Console.SetCursorPosition(xpos, ypos);
   Console.Write(Area[ypos, xpos]);
   ypos--;
   break;
   }
   case ConsoleKey.DownArrow:
   {
   if (ypos + 1 == Y)
   break;

   Console.SetCursorPosition(xpos, ypos);
   Console.Write(Area[ypos, xpos]);
   ypos++;
   break;
   }
   case ConsoleKey.LeftArrow:
   {
   if (xpos - 1 < 0)
   break;

   Console.SetCursorPosition(xpos, ypos);
   Console.Write(Area[ypos, xpos]);
   xpos--;
   break;
   }
   case ConsoleKey.RightArrow:
   {
   if (xpos + 1 == X)
   break;

   Console.SetCursorPosition(xpos, ypos);
   Console.Write(Area[ypos, xpos]);
   xpos++;
   break;
   }
   }
   Console.SetCursorPosition(xpos, ypos);
   if (pick && Area[ypos, xpos] != Symbol) // retain previous amendment
   {
   Area[ypos, xpos] = Area2[ypos, xpos];
   Console.Write(Symbol);
   Console.SetCursorPosition(xpos, ypos);
   }

   }
   }
Adam15y ago
I've tried somethink like this and: it works but it creats new (old) problem with replicateing symbols.
Vulpes15y ago
I think the highlighted alteration should fix it:

   if (pick == true && Area[ypos,xpos] != Symbol)
   {
   Area[ypos, xpos] = Area2[ypos, xpos];
   Console.Write(Symbol);
   Console.SetCursorPosition(xpos, ypos);
   }
Adam15y ago
yes:D but now when you move with figurine across other figurine, the second one disappear. do u know how to modify it?
Vulpes15y ago
It's just as well you added a second figurine as otherwise this error may never have surfaced.

When you only had one figurine, it was hidden by the symmetry of the board which, fortunately, was destroyed when you added the second one :)

What gave it away was when the second figurine which you'd placed at C8 started appearing at A6 when the cursor was moved over it - a real headscratcher ;)
Adam15y ago
ok thanks very much its clear now
Vulpes15y ago
It's to do with the way you've filled the arrays.

The first dimension of Area (and Area2) represents the row index and the second dimension represents the column index of the character.

Now, Console.SetColumnPosition sets the column position first and the row position second.

Also, when the cursor is moving down, the row index which you've represented by 'y' gets incremented.

when the cursor is moving to the right the column index which you've represented by 'x' gets incremented.

So, Console.SetColumnPosition(x, y) is correct.

However, Area[x,y] is wrong because the column and row dimensions are the other way around. To fix it, you therefore need to use Area[y,x].
Adam15y ago
hmm it works but its also weird. I cant understand why x and y shoul be like this not the other way round.
Suthish Nair: Ok so whole requirement is Game Checkers in console aplication, later in windows form. I put here each module because I want also do somethink instead copy whole correct code from forum and do nothing. I also want to program but it seems to be to hard for me, its true:D But its my homework to school.
Vulpes15y ago
After staring at this for a while, it's finally struck me what's wrong - in the Keys routine all the Area[x,y]'s are the wrong way around, they should be Area[y,x]'s !!

So, it should be:

void Keys()
{
while (true)
{

var ch = Console.ReadKey().Key;
switch (ch)
{

case ConsoleKey.Enter:
if (Area[ypos, xpos] == Symbol && pick == false)
{
pick = true;
}
else if (Area[ypos, xpos] != Symbol && pick == true)
{
Area[ypos, xpos] = Symbol;
pick = false;
}
break;

case ConsoleKey.UpArrow:
{
if (ypos - 1 < 0)
break;

Console.SetCursorPosition(xpos, ypos);
Console.Write(Area[ypos, xpos]);
ypos--;
break;
}
case ConsoleKey.DownArrow:
{
if (ypos + 1 == Y)
break;

Console.SetCursorPosition(xpos, ypos);
Console.Write(Area[ypos, xpos]);
ypos++;
break;
}
case ConsoleKey.LeftArrow:
{
if (xpos - 1 < 0)
break;

Console.SetCursorPosition(xpos, ypos);
Console.Write(Area[ypos, xpos]);
xpos--;
break;
}
case ConsoleKey.RightArrow:
{
if (xpos + 1 == X)
break;

Console.SetCursorPosition(xpos, ypos);
Console.Write(Area[ypos, xpos]);
xpos++;
break;
}
}
Console.SetCursorPosition(xpos, ypos);
if (pick == true)
{
Area[ypos, xpos] = Area2[ypos, xpos];
Console.Write(Symbol);
Console.SetCursorPosition(xpos, ypos);
}
}
}
Suthish Nair15y ago
Adam, can you put the whole and final requirement, then we can work on it. Instead of breaking up each module, that will be helpful.
Adam15y ago
now there is a problem when I choose 'clubs' and move across other 'clubs' the second clubs disappear. It shouldnt because it is second figurine and it should stay at checkerboard, when cursor with 'clubs' go across it. Dont know what to do next.
Suthish Nair15y ago
we helped to resolve your other two threads, this also.. :)
Adam15y ago
Now I add another figurine on position [1,0] and it behaves very weird. I dont know where is the problem