simple issue ? Windows forms ..

SUNIL GUTTA

When i am trying like this :

cmd.CommandText = "select LastName,FirstName,EmailAddress,MobilePhone from contactdetails where LastName = 'gutta' "; my code executing perfect when i am giving static data like gutta ...

BUT

I am getting no error .. .. ..

when i am trying like this ..

cmd.CommandText = "select LastName,FirstName,EmailAddress,MobilePhone from contactdetails where LastName = " + textBox1.Text ;

ERROR IS :

dr = cmd.ExecuteReader(); ------------------>

Invalid column name 'gutta'.

Regards

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes12y ago
Accepted answer
Assuming that textBox1 contains just gutta (without the enclosing single quotes) you'll need to add the single quotes yourself:

cmd.CommandText = "select LastName,FirstName,EmailAddress,MobilePhone from contactdetails where LastName = '" + textBox1.Text +"'";

Alternatively (and better) use a parameter:

cmd.CommandText = "select LastName,FirstName,EmailAddress,MobilePhone from contactdetails where LastName = @Name";
cmd.Parameters.AddWithValue("@Name", textBox1.Text);
SUNIL GUTTA12y ago
Ooops yes you are right .. :) Ty for helping .. sometimes my brain freezes darn
Vulpes12y ago
I'd imagine in the latter case that countryid is of INT type in the database and so doesn't need any surrounding single quotes.

Only strings and dates need quotes. Numbers don't.
SUNIL GUTTA12y ago
Hi mate

Ty so much your help Helps :)

I feel confused sometimes .. The same thing i used somewhere in cascading dropdownlists its working fine but here in the above senario its popping me error ..

MY LAST senario which didnt give me any sort of error is

cmd.CommandText = "select state,stateid from countrystate where countryid=" + DropDownList1.SelectedValue;

Any ideas y :)