taking time to load the data in combobox control.

Ankit Gupta

I am using window form with c#. At the time of page load it takes to much time to open the page.i am fetching the data in combobox at the time of page load.Anyone suggest me how to solve this problem.

43 Replies

Know the answer? Post it — somebody with the same question will find it here.

Amit Gupta8y ago
Accepted answer
Just swap the lines
CheckForIllegalCrossThreadCalls = false;
Thread th = new Thread(new ThreadStart(LoadData));
th.Start();

However, I could not able to understand the code, why you are filling the adapter again?
The above code will help you to fill the adapter on a seperate thread, You can use the above lke function yo load the data fr the rest of your code.
Ankit Gupta8y ago
@raj kiran how to share the screen session
Rajkiran Swain8y ago
Hey guys .for my suggestion , Instead of puting more time on conversation , it would be better please do thr screen sharing session and close the issue .
Ankit Gupta8y ago
@amit ok i understand what do you mean. sorry i will not ask you to teach me.
namespace WindowsFormsApplication1
{
    public partial class PrintForm : Form
    {
        public PrintForm()
        {
            InitializeComponent();

        }

        private void PrintForm_Load(object sender, EventArgs e)
        {
            // TODO: This line of code loads data into the 'dbExamDataSet1.tbl_branch_category' table. You can move, or remove it, as needed.
            //this.tbl_branch_categoryTableAdapter.Fill(this.dbExamDataSet1.tbl_branch_category);
            //this.session1.EnforceConstraints = false;
            //this.tbl_SessionTableAdapter.Fill(this.session1.tbl_Session);
            //this.studentSearchDataSet.EnforceConstraints = false;
            //this.tbl_studentTableAdapter.FillBy(this.studentSearchDataSet.tbl_student);
            //cbSearchBy.SelectedIndex = 0;

            Thread th = new Thread(new ThreadStart(LoadData));
            th.Start();
            CheckForIllegalCrossThreadCalls = false;


        }
                            public void  LoadData()

                        {
                            this.tbl_branch_categoryTableAdapter.Fill(this.dbExamDataSet1.tbl_branch_category);
                            this.session1.EnforceConstraints = false;
                            this.tbl_SessionTableAdapter.Fill(this.session1.tbl_Session);
                            this.studentSearchDataSet.EnforceConstraints = false;
                            this.tbl_studentTableAdapter.FillBy(this.studentSearchDataSet.tbl_student);
                            cbSearchBy.SelectedIndex = 0;


                           }




        private void fillByToolStripButton_Click(object sender, EventArgs e)
        {

        }

        private void cbStudentDetail_SelectedIndexChanged(object sender, EventArgs e)
        {


        }

        private void cbSearchBy_SelectedIndexChanged(object sender, EventArgs e)
        {
            if (cbSearchBy.Text.Equals("Name"))
            {
                this.tbl_studentTableAdapter.FillBy(this.studentSearchDataSet.tbl_student);
            }
            else
            {
                this.tbl_studentTableAdapter.FillByENO(this.studentSearchDataSet.tbl_student);
            }
        }

        private void cbSemYear_SelectedIndexChanged(object sender, EventArgs e)
        {
            if (this.cbSemYear.SelectedIndex >= 0 && tbRegistration.Text.Trim().Length > 0 || (this.cbSemYear.SelectedIndex >= 0 && tbSno.Text.Trim().Length > 0))
            {
                this.tbl_ResultTableAdapter.Fill(this.dbExamDataSet.tbl_Result, tbRegistration.Text, cbSemYear.SelectedValue.ToString());
                this.tbl_Result_DetailTableAdapter.Fill(this.marksResult.tbl_Result_Detail, tbSno.Text.ToString());

            }
            calculateMarks();

        }
        private void calculateMarks()
        {
            double num = 0.0;
            double num2 = 0.0;
            double num3 = 0.0;
            for (int i = 0; i < this.dgvMarksDetail.RowCount; i++)
            {

                    num += Convert.ToDouble(this.dgvMarksDetail.Rows[i].Cells["obtmarksDataGridViewTextBoxColumn"].Value);
                    num2 += Convert.ToDouble(this.dgvMarksDetail.Rows[i].Cells["maxMarksDataGridViewTextBoxColumn"].Value);
                    num3 += Convert.ToDouble(this.dgvMarksDetail.Rows[i].Cells["passingDataGridViewTextBoxColumn"].Value);

            }
            this.tbObtMarks.Text = num.ToString();
            this.tbMaxMarks.Text = num2.ToString();
            this.tbMinMarks.Text = num3.ToString();

        }

        private void cbExamSession_SelectedIndexChanged(object sender, EventArgs e)
        {



        }
        private void gridControls()
        {
            int row = 0;
            for (; row < dgvMarksDetail.RowCount; row++)
            {
                if (dgvMarksDetail.Rows[row].Cells["column1DataGridViewTextBoxColumn"].Value.ToString() == "True")
                {
                    dgvMarksDetail.Rows[row].Cells["selectSubject"].Value = true;
                    dgvMarksDetail.Rows[row].Cells["selectSubject"].ReadOnly = true;
                }
                else
                    dgvMarksDetail.Rows[row].Cells["selectSubject"].Value = false;
            }
        }

        private void btnLoadData_Click(object sender, EventArgs e)
        {
            //this.tbl_branch_categoryTableAdapter.Fill(this.dbExamDataSet1.tbl_branch_category);
            //this.session1.EnforceConstraints = false;
            //this.tbl_SessionTableAdapter.Fill(this.session1.tbl_Session);
            //this.studentSearchDataSet.EnforceConstraints = false;
            //this.tbl_studentTableAdapter.FillBy(this.studentSearchDataSet.tbl_student);
            //cbSearchBy.SelectedIndex = 0;
        }

        private void btnPrint_Click(object sender, EventArgs e)
        {
            //DAL.DAL dalObj = new DAL.DAL();
            //dalObj.ConnectionStr = MasterClass.conStr;
            //dalObj.OpenConnection();
            //string queryString = "select sum(obtmarks) from tbl_result_detail d where d.sno = '" + tbSno.Text + "'";
            //int marks = Convert.ToInt32(dalObj.ExecuteScalar(CommandType.Text, queryString));
            //dalObj.CloseConnection();
            //marksheet ms = new marksheet();
            //ParentForm mf = new ParentForm();
            //ms.MdiParent = mf;
            //ms.showMarksheet(tbRegistration.Text.Trim(), cbSemYear.text, Convert.ToInt32(cbExamSession.SelectedItem), amt_wrds.Module1.RupeesToWord(marks).ToString().Replace("Rupees", "").ToString(), tbSno.Text);
            //ms.Show();
            DAL.DAL dalObj = new DAL.DAL();
            dalObj.ConnectionStr = MasterClass.conStr;
            dalObj.OpenConnection();
            string queryString = "select sum(obtmarks) from tbl_result_detail d where d.sno = '" + tbSno.Text + "'";
            int marks = Convert.ToInt32(dalObj.ExecuteScalar(CommandType.Text, queryString));
            dalObj.CloseConnection();
            marksheet ms = new marksheet();
            ParentForm mf = new ParentForm();
            //ms.MdiParent = mf;
            ms.showMarksheet(tbRegistration.Text.Trim(), cbSemYear.Text.Trim(), Convert.ToInt32(cbExamSession.SelectedValue), amt_wrds.Module1.RupeesToWord(marks).ToString().Replace("Rupees", "").ToString(), tbSno.Text);
            ms.Show();
this is my cs file code. my application not working properly.
Amit Gupta8y ago
Please donot move out of the topic, if any thing you want to ask, you can send me a message, expanding the question will not a good practice, and no one can get helped by the issue you had posted (after reading so lengthy posts).

If you have another question, start a new thread or be brief to the answers posted by me or members.

It appreciated, that you find the correct syntax but I had commented to write that on constructor and not in between the methods.

If you still found any difficulty in implementing the code, then post that code file.cs page
Ankit Gupta8y ago
@amit gupta CheckForIllegalCrossThreadCalls = false; this is right syntax i think.
you have written (CheckForIllegalThreadCalls =false;)
Ankit Gupta8y ago
@amit gupta thats why amit i am asking you to teach me about the window and web application. I dont know how to do coding please help me amit.
Amit Gupta8y ago
@Ankit

Please read my answer carefully, I had clearly mentioned where to put CheckForIllegalThreadCalls.

You have to put void in LoadData() as mentioned in my answer.
Ankit Gupta8y ago
@amit gupta
Ankit Gupta8y ago
CheckForIllegalThreadCalls =false;
Ankit Gupta8y ago
@amit gupta what is the purpose of using this thread and how its works
Ankit Gupta8y ago
@amit gupta its still giving namespace error and method should return type error.
Ankit Gupta8y ago
@amit gupta you mean if we use latest tehnolgies then application performance is good. it means in old version vs dont give good performance.i appriciate your words but i mean to say if i am using vs 2010 my application performance will not improve.
Amit Gupta8y ago
@Ankit

If you want better performance, you must use the updated and current edge technologies.

Alternatively, you can use Threads which are available within your existing framework. This will make upto the satisfactory mark.
// Write the bellw line under the contructor
CheckForIllegalThreadCalls =false;

// Step 2
private  void PrintForm_Load(object sender, EventArgs e)
{
// you can show any status like loading data.... or progressbar
Thread th = new Thread(new ThreadStart(LoadData));
th.Start();


}

public void  LoadData()
{
this.tbl_branch_categoryTableAdapter.Fill(this.dbExamDataSet1.tbl_branch_category);
this.session1.EnforceConstraints = false;
this.tbl_SessionTableAdapter.Fill(this.session1.tbl_Session);
this.studentSearchDataSet.EnforceConstraints = false;
this.tbl_studentTableAdapter.FillBy(this.studentSearchDataSet.tbl_student);

cbSearchBy.SelectedIndex = 0;
}
Use System.Threading namespace

This is the last option that might increase the performance, because it is windows application, we have to use some threads for responsiveness of the application. Otherwise you must update your IDE and use the latest version of .Net Framework.

Good Luck
Ankit Gupta8y ago
@amit gupta .net framework not upgrade in vs2010. i dont have latest visual studio.there is otherway to increase the performance of window application.
Ankit Gupta8y ago
@ amit gupta there is no other way to improve the performance of application
Ankit Gupta8y ago
@amit gupta can you teach me about window and web applications. I want to develop the ERP for my office.
Amit Gupta8y ago
Vecause of using too much OLD IDE, it might not be available, try installing the latest version of .net framework from the offcial site and then updrade in VS. If it unable to upgrade then you must install the latest version of VS
Ankit Gupta8y ago
@ amit gupta can you help me to teach about window and web application.
Ankit Gupta8y ago
@amit gupta. Net framework not updated on vs 2010.how to update it now
Ankit Gupta8y ago
@amit gupta what is the use of this async and wait programming.
Ankit Gupta8y ago
@amit gupta can you teach me how to design database for software and window application. I am not good programmer.
Amit Gupta8y ago
Obviously, you need to upgrade the framework to 4.5 or higher
Ankit Gupta8y ago
@ amit gupta It means i have to upgrade the .net framework in visual studio 2010
Ankit Gupta8y ago
@amit gupta currently my .net framework is 4.0
Amit Gupta8y ago
Its await LoadData() not await.LoadData();

Make sure you have used .Net Framework 4.5 or above
Ankit Gupta8y ago
i have send the image. visual studio 2010 complier support "async" or not.
Ankit Gupta8y ago
error
Ankit Gupta8y ago
I am using visual studio 2010 ultimate.
Amit Gupta8y ago
@Ankit, rar file is corrupted. please show the error you are getting
Ankit Gupta8y ago
@amit gupta still giving error.
Amit Gupta8y ago
use System.Threading.Tasks

If you are using the latest version of Visual Studio then click on then Visual Studio itself add a namespace when clicked on the Bulb icon (CTRL+.) when selected on the class.
Ankit Gupta8y ago
@ amit gupta its giving Namespace error.
Ankit Gupta8y ago
I am using dataset and dataadapterto fill the data in combobox.
Amit Gupta8y ago
I could not able to find, how you bind the data with combobox but I code for fetching data using threading.
private async void PrintForm_Load(object sender, EventArgs e)
{
// you can show any status like loading data.... or progressbar
await LoadData();
cbSearchBy.SelectedIndex = 0;

}

public async LoadData()
{
    await Task.Run(()=>
    {
       this.tbl_branch_categoryTableAdapter.Fill(this.dbExamDataSet1.tbl_branch_category);
this.session1.EnforceConstraints = false;
this.tbl_SessionTableAdapter.Fill(this.session1.tbl_Session);
this.studentSearchDataSet.EnforceConstraints = false;
this.tbl_studentTableAdapter.FillBy(this.studentSearchDataSet.tbl_student);
    }));
}
Good Luck
Ankit Gupta8y ago
Can you tell me how to do that. I am not a good programmer.
Amit Gupta8y ago
Try loading your data in a background thread, use async/await programming
Rajkiran Swain8y ago
What is the query you have written ? could you please provide me ?
Ankit Gupta8y ago
Rajkiran its maybe due to database query or not proper designing of database
Rajkiran Swain8y ago
I reviewed your code and The code is seems good . I am not sure why perfermance issue occers in your application .
Ankit Gupta8y ago
Rajkiran Swain have you seen the code i have send you.
Ankit Gupta8y ago
private void PrintForm_Load(object sender, EventArgs e)
{
this.tbl_branch_categoryTableAdapter.Fill(this.dbExamDataSet1.tbl_branch_category);
this.session1.EnforceConstraints = false;
this.tbl_SessionTableAdapter.Fill(this.session1.tbl_Session);
this.studentSearchDataSet.EnforceConstraints = false;
this.tbl_studentTableAdapter.FillBy(this.studentSearchDataSet.tbl_student);
cbSearchBy.SelectedIndex = 0;
}
Rajkiran Swain8y ago
Could you please post your code ?