What about performance for this code?

Abdelrhman Abdo

foreach (var Cust in Customers)

{

using (Contex C)

{

c.customers.add(Cust);

c.savechanges();

}

3 Replies

Know the answer? Post it — somebody with the same question will find it here.

Veerendra Annigere7y ago
First save changes shouldn't be inside the loop.

Even after wrting it outside the loop. If you doing it in bulk (say more than 200) than its very bad.

try to write stored procedure. Write user defined table type parameter and do insert operation in stored proc.
Abdelrhman Abdo7y ago
what about this words

If you call it inside the loop, EF will write back the changes to the database for every single entity(and every entity will be in its own, separate transaction).

The other way around, you'll make all your changes and EF will write them back all at once after the loop (in one single transaction for all entities together).

As a general rule of thumb (without actually seeing your code) try to have as few calls to .SaveChanges() as possible.

One call with 50 changes is typically much better / faster / more efficient than 50 calls for 1 change each.
Amit Gupta7y ago
I will be surprised if your code compiles. Anyway coming to your question, saving changes under loop will slightly decrease the performance, just add all the customers inside the loop and save it outside the loop's body.