C# Code Microsoft Foundational Course

Hey everyone I'm starting my journey in game devlopment so i decided to learn C# so i started with the Microsoft Foundational Course which has been great so far but I did the guided project to calculate and print students grades and I was wondering why they chose to do their code the way they did and if mine was "worse" or wrong. I know their are multiple ways to get to the same outcome. Any advice is welcomed. Thanks in advance.

Their code:

int currentAssignments = 5;

int sophia1 = 93;
int sophia2 = 87;
int sophia3 = 98;
int sophia4 = 95;
int sophia5 = 100;

int nicolas1 = 80;
int nicolas2 = 83;
int nicolas3 = 82;
int nicolas4 = 88;
int nicolas5 = 85;

int zahirah1 = 84;
int zahirah2 = 96;
int zahirah3 = 73;
int zahirah4 = 85;
int zahirah5 = 79;

int jeong1 = 90;
int jeong2 = 92;
int jeong3 = 98;
int jeong4 = 100;
int jeong5 = 97;

int sophiaSum = sophia1 + sophia2 + sophia3 + sophia4 + sophia5;
int nicolasSum = nicolas1 + nicolas2 + nicolas3 + nicolas4 + nicolas5;
int zahirahSum = zahirah1 + zahirah2 + zahirah3 + zahirah4 + zahirah5;
int jeongSum = jeong1 + jeong2 + jeong3 + jeong4 + jeong5;

decimal sophiaScore = (decimal) sophiaSum / currentAssignments;
decimal nicolasScore = (decimal) nicolasSum / currentAssignments;
decimal zahirahScore = (decimal) zahirahSum / currentAssignments;
decimal jeongScore = (decimal) jeongSum / currentAssignments;

Console.WriteLine("Student\t\tGrade\n");
Console.WriteLine("Sophia:\t\t" + sophiaScore + "\tA");
Console.WriteLine("Nicolas:\t" + nicolasScore + "\tB");
Console.WriteLine("Zahirah:\t" + zahirahScore + "\tB");
Console.WriteLine("Jeong:\t\t" + jeongScore + "\tA");

Their Output:

Student Grade

Sophia: 94.6 A
Nicolas: 83.6 B
Zahirah: 83.4 B
Jeong: 95.4 A

My Code:

int currentAssignments = 5;

int sophia1 = 93;
int sophia2 = 87;
int sophia3 = 98;
int sophia4 = 95;
int sophia5 = 100;

int nicolas1 = 80;
int nicolas2 = 83;
int nicolas3 = 82;
int nicolas4 = 88;
int nicolas5 = 85;

int zahirah1 = 84;
int zahirah2 = 96;
int zahirah3 = 73;
int zahirah4 = 85;
int zahirah5 = 79;

int jeong1 = 90;
int jeong2 = 92;
int jeong3 = 98;
int jeong4 = 100;
int jeong5 = 97;

// Students names
string s = "Student\t\tGrade\n\nSophia:\t\t";
string n = "Nicolas:\t";
string z = "Zahirah:\t";
string j = "Jeong:\t\t";

// Gets students averages then converts them to decimals
decimal sophiaGrade = (decimal) (sophia1 + sophia2 + sophia3 + sophia4 + sophia5) / currentAssignments;
decimal nicolasGrade = (decimal) (nicolas1 + nicolas2 + nicolas3 + nicolas4 + nicolas5) / currentAssignments;
decimal zahirahGrade = (decimal) (zahirah1 + zahirah2 + zahirah3 + zahirah4 + zahirah5) /  currentAssignments;
decimal jeongGrade = (decimal) (jeong1 + jeong2 + jeong3 + jeong4 + jeong5) /   currentAssignments;

// Combines names and grades
string sC = s + sophiaGrade ;
string nC = n + nicolasGrade ;
string zC = z + zahirahGrade ;
string jC = j + jeongGrade ;

// Outputs two columns with students names, grades, letter grades
Console.WriteLine(sC + "\tA\n" + nC + "\tB\n" + zC + "\tB\n" + jC + "\tA" );

My Output:

Student Grade

Sophia: 94.6 A
Nicolas: 83.6 B
Zahirah: 83.4 B
Jeong: 95.4 A

Hello !

Your version isn’t worse I think t’s just a different style. The sample is more like a verbose to teach variables, arithmetic, casting, and Console.WriteLine without introducing arrays, loops, or LINQ yet. Your code compresses a few steps which is fine, but both copies the same drawback since you have a lot of repeated values and hard-coded letter grades.

using System;
using System.Linq;

class Program
{
    static void Main()
    {
        var students = new (string Name, int[] Scores)[]
        {
            ("Sophia",  new[] { 93, 87, 98, 95, 100 }),
            ("Nicolas", new[] { 80, 83, 82, 88, 85 }),
            ("Zahirah", new[] { 84, 96, 73, 85, 79 }),
            ("Jeong",   new[] { 90, 92, 98, 100, 97 })
        };

        Console.WriteLine($"{"Student",-10}{"Avg",8}  Letter");

        foreach (var (name, scores) in students)
        {
            decimal avg = scores.Sum() / (decimal)scores.Length;

            string letter = avg switch
            {
                >= 90m => "A",
                >= 80m => "B",
                >= 70m => "C",
                >= 60m => "D",
                _      => "F"
            };

            Console.WriteLine($"{name,-10}{avg,8:F1}  {letter}");
        }
    }
}

2 Replies

Know the answer? Post it — somebody with the same question will find it here.

Kannan K1y ago
It is a Nice start, few improvements or guidelines you can use

1. try to use collections (array/list/dictionary) instead of creating variables for every value

2. instead of manual string concatenation explore interpolation

Amira Bedhiafi1y ago