C# stackover flow problem

Anuj Kumar

Dear Expert

I am new in C# also in window app development.

It is my first App.

I am try to develop a universal windows app in C#, My app use a recursive function due to this function there is System Stack overflow exception.

In recursive function i am reading (.xml) file, to read all node of this file i call it recursively after reading 6-7 node it give System Stack overflow exception.

My function is like :

Class read

{

ReadNode(IXmlNode node, FileName);

}

ReadNode(IXmlNode node, FileName)

{

// reade node data

IXmlNode ChildNode= node.Child;

while(ChildNode)

{

ReadNode(ChildNode, FileName) ;

ChildNode =ChildNode.NextSibling;

}

Is there is any solution to solve this System Stack overflow exception without changing my recursive function.

This recursive function work well in a Dialog base window Application in visual studio2010 in VC++;

Thanks in Advance

2 Replies

Know the answer? Post it — somebody with the same question will find it here.

Afzaal Ahmad Zeeshan10y ago
Accepted answer
There won't be any other way around. I have also written a book about "Data Structures and Algorithms", which will be released soon on C# Corner. And in that guide I have talked that Stack Overflow errors are very prone if you use recursion and I have also mentioned that you should "ignore" using recursive patterns. Instead, use loops.

In your case, you can ignore by removing the parameters to the function call. Instead, use a static field and then use that field in the function. This would remove the necessity of using the stack pushing, that can help you to minimize the stack overflow.
```
private IXmlNode node { get; set; }
private string FileName { get; set; } // I hope the type is string. 
 
void ReadNode() {
    // get the XML node
 
    IXmlNode ChildNode = node.Child; 
    while (ChildNode != null) {
          // Update the values for fields 
         ReadNode(); 
         ChildNode = ChildNode.NextSibling; 
    } 
} 
```
This way, you would get rid of the parameters and instead you will get the result in a field that can be static or not.
Anuj Kumar10y ago
Thanks Afzaal for your reply.

Your answer solved my problem.
Thanks