Card war game

Prime b

The problem:

thank you!~

As you can see the program is massive and ridiculously hard, I have been trying to do this program for last few days , but unsuccessful. Someone please help me

18 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes14y ago
Accepted answer
It's not as difficult as it looks:

/*
Suppose:

1 to 4 denotes Ace
5 to 8 denotes Deuce
...
45 to 48 denotes Queen
49 to 52 denotes King
*/

using System;

class War
{
static int[] deck = new int[52]; // all zero by default
static int lastCardIndex = 0;
static char[] cards = {'A', '2', '3', '4', '5', '6', '7', '8', '9', 'T', 'J', 'Q', 'K'};
static Random rand = new Random();

static void Main()
{
int totalComputer = 0; // records total points for computer
int totalPlayer = 0; // ditto for player
string result = null;

FillDeck();
Console.Clear();

// 26 deals
for(int i = 0; i < 26; i++)
{
int computer = SelectCard() - 1;
int player = SelectCard() - 1;

if (computer > player)
{
result = "Computer gets 2 points";
totalComputer += 2;
}
else if (computer < player)
{
result = "Player gets 2 points";
totalPlayer += 2;
}
else
{
result = "1 point each";
totalComputer += 1;
totalPlayer += 1;
}

Console.WriteLine("Deal {0, 2}: Computer '{1}' - Player '{2}' : {3}", i+1, cards[computer], cards[player], result);
}

Console.WriteLine();
Console.WriteLine("Computer's total score : {0}", totalComputer);
Console.WriteLine("Player's total score : {0}", totalPlayer);

if (totalComputer > totalPlayer)
{
result = "Computer wins!";
}
else if (totalComputer < totalPlayer)
{
result = "Player wins!";
}
else
{
result = "It's a draw!";
}

Console.WriteLine();
Console.WriteLine(result);
Console.ReadKey();
}

static void FillDeck()
{
for(int i = 0; i < 52; i++)
{
while(true)
{
int num = rand.Next(1, 53); // get number between 1 and 52 inclusive
if (Array.IndexOf(deck, num) == -1) // not already used
{
deck[i] = num;
break;
}
}
}
}

static int SelectCard()
{
int num = deck[lastCardIndex];
lastCardIndex++;
return (num - 1) / 4 + 1;
}
}
Prime b14y ago
Ah makes a lot more sense. Now i will try to rewrite the program my self
Vulpes14y ago
Don't forget that it's the remainder (not the result of the division itself) which determines the suit.

So, (13 -1) % 4 = 0 which is clubs.

(16 - 1) % 4 = 3 would be spades.
Prime b14y ago
hmm okay, so {"clubs", "diamonds", "hearts", "spades"};
0 represent clubs, 1 diamonds , 2 hearts, and 3 spades? so if the numbers is 13 it will be 13-1/4 = 3 which is spades?
Vulpes14y ago
Yes, the modulo operator '%' means the remainder after dividing the dividend by the divisor.

So, (3 - 1) % 4 = 2 because if you divide 2 by 4, you get 0 with a remainder of 2.

Similarly, (14-1) % 4 = 1 because if you divide 13 by 4, you get 3 with a remainder of 1.

You're right that, if the divisor is greater than the dividend, the result of the modulo operation will be the dividend.
Prime b14y ago
Neither, 'num' will be in a random order.

If num is 1, the index of the suit is: (1 - 1) % 4 = 0 which is clubs.

If num is 3, the index of the suit is: (3 - 1) % 4 = 2 whic is hearts.

If num is 5, the index of the suit is: (5 - 1) % 4 = 0 which is clubs again.

So if num is 3 its going to be (3-1) % 4 = 2/4 which = 1/2? why in your case its 2? or it doesnt work that way, Its going to be just 2 which will be hearts
If the number is 14 its going to be (14-1) % 4 = 13 % 4 which is 3 and remainder is 1 which is diamonds?

So if the divisor is greater than dividend then answer will be dividend?
Vulpes14y ago
Neither, 'num' will be in a random order.

If num is 1, the index of the suit is: (1 - 1) % 4 = 0 which is clubs.

If num is 3, the index of the suit is: (3 - 1) % 4 = 2 whic is hearts.

If num is 5, the index of the suit is: (5 - 1) % 4 = 0 which is clubs again.

And so on.
Prime b14y ago
ok, so suit = suit[(num-1) %4] , does computer go in increasing order such as it num = 1,2,3,4,5,etc ; or it goes in decreasing order 52,51,50,49,etc?
Vulpes14y ago
Taking those 3 questions in the same order:

1. Before we can deal the cards, we need to fill the deck in a random way (equivalent to shuffling it).

2. Having obtained a random number between 1 and 52, we then check to see whether it's already in the deck. If it isn't in the deck, Array.IndexOf returns -1 and so we then add it in the next postion. We carry on like this until all 52 cards have been placed in the deck.

3. We draw successive cards from the deck each time SelectCard is called, starting at index 0. The remainder after deducting one and dividing by 4 from the card's value, tells use what suit it is - a remainder of 0 is clubs, 1 diamonds and so forth. We place the string value of the suit in the output parameter.

We then return the value of the card (between 1 and 13) to the caller of the method.
Prime b14y ago
So i have questions

class War
{
static int[] deck = new int[52]; // all zero by default
static int lastCardIndex = 0;
static string[] cards = {"Ace", "2", "3", "4", "5", "6", "7", "8", "9", "10", "Jack", "Queen", "King"};
static string[] suits = {"clubs", "diamonds", "hearts", "spades"};
static Random rand = new Random();

static void Main()
{
int totalComputer = 0; // records total points for computer
int totalPlayer = 0; // ditto for player

FillDeck();                      Why did you put FillDeck() here?
Console.Clear();

// 26 deals
for(int i = 0; i < 26; i++)
{
string computerSuit;
int computer = SelectCard(out computerSuit) - 1;
string playerSuit;
int player = SelectCard(out playerSuit) - 1;

if (computer > player)
{
totalComputer += 2;
}
else if (computer < player)
{
totalPlayer += 2;
}
else
{
totalComputer += 1;
totalPlayer += 1;
}

Console.WriteLine("Deal # {0}", i + 1);
Console.WriteLine(" Computer has {0} of {1}", cards[computer], computerSuit);
Console.WriteLine(" Player has {0} of {1}", cards[player], playerSuit);
Console.WriteLine("Computer Score is {0}", totalComputer);
Console.WriteLine("Player Score is {0}", totalPlayer);
Console.WriteLine();
Console.ReadKey();
}
}

static void FillDeck()
{
for(int i = 0; i < 52; i++)
{
while(true)
{
int num = rand.Next(1, 53); // get number between 1 and 52 inclusive
if (Array.IndexOf(deck, num) == -1) // not already used                                  Here, Array.IndexOf(deck,num) == -1 , this goes through the 52 array numbers and then places it in the num? and - 1 subtracts that number from 52 numbers so it wont be used again?
{
deck[i] = num; Then the number that was in num goes it to the deck [ but why do you write index in front of deck?]
break;
}
}
}
}

static int SelectCard(out string suit)
{
int num = deck[lastCardIndex]; Then here the [lastCardIndex] has zero value and it places it in the deck which assigns it to num? But why?
lastCardIndex++;
suit = suits[(num - 1) % 4];            And this math, num -1? so its like 52-1 = 51. Then you divide 51 by 4, but really is modulus so you get the remainder out of that number, but how does that remainder helps you?
return (num - 1) / 4 + 1;               and then here, return, where do it return to ?
}
}
Vulpes14y ago
Not everyone has an aptitude for programming but, even if you decide to do something else as a career, it will give you an appreciation of what it takes these days to build decent software, a useful insight into today's IT dominated world :)
Prime b14y ago
Awesome thank you vulpes!
I uninstall all my video games.....Selling my expensive video card, downloaded more books in C sharp. Otherwise I wont practice programming, and to be honest I am not sure if I like programming. If you ask me to go play video games I will do that right away, but if you ask me to program i will procrastinate. Its either addiction to video games or its just i like video games more than programming.
Vulpes14y ago
You'll need to add an extra array for the suits and change the 'cards' array so it now contains strings rather than single chars.

You'll also need to pass the suit back from the SelectCard() method - you can use an 'out' parameter for this.

So, it's not difficult to alter it so it looks like the image.

I've also made it now so that you have to press a key to see the next deal:

/*
suppose:

1 to 4 denotes Ace of clubs, diamonds, hearts, spades
5 to 8 denotes Deuce etc.
...
45 to 48 denotes Queen etc.
49 to 52 denotes King etc.
*/

using System;

class War
{
static int[] deck = new int[52]; // all zero by default
static int lastCardIndex = 0;
static string[] cards = {"Ace", "2", "3", "4", "5", "6", "7", "8", "9", "10", "Jack", "Queen", "King"};
static string[] suits = {"clubs", "diamonds", "hearts", "spades"};
static Random rand = new Random();

static void Main()
{
int totalComputer = 0; // records total points for computer
int totalPlayer = 0; // ditto for player

FillDeck();
Console.Clear();

// 26 deals
for(int i = 0; i < 26; i++)
{
string computerSuit;
int computer = SelectCard(out computerSuit) - 1;
string playerSuit;
int player = SelectCard(out playerSuit) - 1;

if (computer > player)
{
totalComputer += 2;
}
else if (computer < player)
{
totalPlayer += 2;
}
else
{
totalComputer += 1;
totalPlayer += 1;
}

Console.WriteLine("Deal # {0}", i + 1);
Console.WriteLine(" Computer has {0} of {1}", cards[computer], computerSuit);
Console.WriteLine(" Player has {0} of {1}", cards[player], playerSuit);
Console.WriteLine("Computer Score is {0}", totalComputer);
Console.WriteLine("Player Score is {0}", totalPlayer);
Console.WriteLine();
Console.ReadKey();
}
}

static void FillDeck()
{
for(int i = 0; i < 52; i++)
{
while(true)
{
int num = rand.Next(1, 53); // get number between 1 and 52 inclusive
if (Array.IndexOf(deck, num) == -1) // not already used
{
deck[i] = num;
break;
}
}
}
}

static int SelectCard(out string suit)
{
int num = deck[lastCardIndex];
lastCardIndex++;
suit = suits[(num - 1) % 4];
return (num - 1) / 4 + 1;
}
}
Prime b14y ago
You know what vuples you are correct, this morning when i woke up, i realized the number is 52 so the range has to be 1-53 to include 52. So yeah i changed that back.

But the only problem that i still have is that I want to make it look like this http://imageshack.us/f/10/50156655.png/

I imagine that I have to add another array, but after that i am lost
And then I can work on the GUI part
Vulpes14y ago
There are two points you're missing:

1. The Random.Next method produces a random number between (inclusive) the lower bound and (exclusive) the upper bound. So to get a number between 1 and 52, you have specify arguments of 1 and 53 to the method.

2. When I select a card for the computer and the player, I reduce the result by one. This doesn't affect the comparison but I I did it so there would then be a direct mapping between the cards array (zero based) and the selected card.

So, the program does in fact work fine :)
Prime b14y ago
Vulpes, it doesnt work
first I found mistake i highlighted yellow , it should be 0,52 not 1,53, otherwise its out of range. And then if I change it the program runs but its black screen

/*
Suppose:

1 to 4 denotes Ace
5 to 8 denotes Deuce
...
45 to 48 denotes Queen
49 to 52 denotes King
*/

using System;

class War
{
static int[] deck = new int[52]; // all zero by default
static int lastCardIndex = 0;
static char[] cards = {'A', '2', '3', '4', '5', '6', '7', '8', '9', 'T', 'J', 'Q', 'K'};
static Random rand = new Random();

static void Main()
{
int totalComputer = 0; // records total points for computer
int totalPlayer = 0; // ditto for player
string result = null;

FillDeck();
Console.Clear();

// 26 deals
for(int i = 0; i < 26; i++)
{
int computer = SelectCard() - 1;
int player = SelectCard() - 1;

if (computer > player)
{
result = "Computer gets 2 points";
totalComputer += 2;
}
else if (computer < player)
{
result = "Player gets 2 points";
totalPlayer += 2;
}
else
{
result = "1 point each";
totalComputer += 1;
totalPlayer += 1;
}

Console.WriteLine("Deal {0, 2}: Computer '{1}' - Player '{2}' : {3}", i+1, cards[computer], cards[player], result);
}

Console.WriteLine();
Console.WriteLine("Computer's total score : {0}", totalComputer);
Console.WriteLine("Player's total score : {0}", totalPlayer);

if (totalComputer > totalPlayer)
{
result = "Computer wins!";
}
else if (totalComputer < totalPlayer)
{
result = "Player wins!";
}
else
{
result = "It's a draw!";
}

Console.WriteLine();
Console.WriteLine(result);
Console.ReadKey();
}

static void FillDeck()
{
for(int i = 0; i < 52; i++)
{
while(true)
{
int num = rand.Next(1, 53); // get number between 1 and 52 inclusive
if (Array.IndexOf(deck, num) == -1) // not already used
{
deck[i] = num;
break;
}
}
}
}

static int SelectCard()
{
int num = deck[lastCardIndex];
lastCardIndex++;
return (num - 1) / 4 + 1;
}
}
Prime b14y ago
Vulpes could you look at this please

http://www.c-sharpcorner.com/Forums/Thread/156565/who-could-help-me.aspx
Prime b14y ago
Vulpes you are just a genius