Click Button causes App to exit?

D Lng

14y1.8kC#

Hi,

I have pasted some code below for two button actions to perform a calculation, the first button action causes the app to exit in the emulator, the second button action works good.
Any ideas please?
Thank you.

Code:
namespace WindowsPhoneApplication11
{
    public partial class PanoramaPage1 : PhoneApplicationPage
    {
        public PanoramaPage1()
        {
            InitializeComponent();
        }
// This button action crashes the app
private void btnGetAvail_Click(object sender, RoutedEventArgs e)
{
var compdown = Convert.ToDouble(tbundown) - Convert.ToDouble(tbplandown);
var shiftact = Convert.ToDouble(tbshift);
var not = shiftact - compdown;
var avail = not / shiftact * 100;
var availr = Math.Round(avail,2);
tbAvail.Text = availr + "%";
}

// This button action works good.
private void btnGetOEE_Click(object sender, RoutedEventArgs e)

{

//var total = Convert.ToDouble(tbYield.Text) * Convert.ToDouble(tbAvailability.Text) * Convert.ToDouble(tbPerformance.Text)* 100;
var total = Convert.ToDouble(tbYield.Text) * Convert.ToDouble(tbAvailability.Text) * Convert.ToDouble(tbPerformance.Text)* 100;
var rounded = Math.Round(total,2);
tbOEE.Text = rounded + "%";
        }
}
}

7 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes14y ago
Accepted answer
As 'availr' is a local variable it won't be available to other button_Click handlers unless you store it somewhere.

However, as it's already displayed in tbAvail, you could just remove the "%" from the end and parse it back to a double for the next calculation:

var availr = Convert.ToDouble(tbAvail.Text.Replace("%", ""));
Vulpes14y ago
One thing you could do is to move all the code which updates tbAvail into a separate method.

You could then handle the TextChanged events for the three other textboxes on which it depends: tbundown, tbplandown and tbshift.

Each time the text changes in these textboxes, you could then call the method to update tbAvail.

However, possible problems here include invalid input and whether the phone would be able to respond quickly enough as it would need to update on each key press.
D Lng14y ago
ok nice, ill try that when I get to it.
Oh, one last thing, what is the command for ( tbAvail.Text ) to update automatically without having to click a button? Is that doable?
D Lng14y ago
Just on a sidenote....is it difficult to pass the result from that calculation ( availr ) into a textbox in a different calculation i.e (tbAvailability.Text) in the second button calc?Im getting to that, so i thought I would preempt the issue.
Thanks
Vulpes14y ago
This is easily done.

I did it myself the other day and it took me a while to realize what the problem was :)
D Lng14y ago
My friend, thank you. It needed some fresh eyes, and you delivered. :P
Excuse my novice skills, I have just started learning this , less than 2 days, so sometimes cannot see the obvious stuff.

Thanks again.
I may be back with another problem soon . :P
Vulpes14y ago
Could this be the problem?

private void btnGetAvail_Click(object sender, RoutedEventArgs e)
{
var compdown = Convert.ToDouble(tbundown.Text) - Convert.ToDouble(tbplandown.Text);
var shiftact = Convert.ToDouble(tbshift.Text);
var not = shiftact - compdown;
var avail = not / shiftact * 100;
var availr = Math.Round(avail,2);
tbAvail.Text = availr + "%";
}