Error Ado.Net/ Sql/C# need help please

Question

Exception Details: System.Data.SqlClient.SqlException: Incorrect syntax near '='. Line 25: da = new SqlDataAdapter(strQuery, con); Line 26: DataSet ds = new DataSet(); Line 27: da.Fill(ds,"Students"); Line 28: Line 29:ViewState["Sql_Query"] = strQuery; i didnt understand why i am getting this error and how do i solve it? my Codes: string strQuery = "Select * from tblStudent where ID = " + txtID.Text; da = new SqlDataAdapter(strQuery, con); DataSet ds = new DataSet(); da.Fill(ds,"Students");

Vincent Maverick Durano · Answer

First off - You should be concerned about your application's security. Appending the TextBox value directly into your SQL query is a BIG "no no" because that can lead you to SQL Injection attack , use should Parameterized query instead for security and more cleaner codes. Second - Since you are only dealing with a single table from your database then you should use DataTable and not DataSet. Here's a quick example: protected void BindGrid(){ DataTable dt = new DataTable(); using(SqlConnection connection = new SqlConnection("YOUR CONNECTION STRING HERE")){ string sql = "Select * from tblStudent where ID = @ID"; using(SqlCommand cmd = new SqlCommand(sql,connection)){ connection.Open(); cmd.Parameters.AddWithValue("@ID", Convert.ToInt32(txtID.Text)); using(SqlDataAdapter ad = new SqlDataAdapter(cmd)){; ad.Fill(dt); //check if the query returns any data if (dt.Rows.Count > 0) { GridView1.DataSource = dt; GridView1.DataBind(); } else{ //No records found } } } } } protected void Page_Load(object sender, EventArgs e){ if(!IsPostback) BindGrid(); }

Khargesh Rajput · Answer

string strQuery = "Select * from tblStudent where ID = " + txtID.Text; debug your code here Select * from tblStudent where ID = " + Convert.ToInt32(txtID.Text);// if id int or Select * from tblStudent where ID = '" + txtID.Text+"'"; best way is debug code and check strquery copy and paste in sql and execute if your query is wrong then edit it

Gaurav Singh · Answer

thank you

Gaurav Singh · Answer

ID is int, primary key and identity. i am trying to get ID as an input from user in the txtID box control to generate rest of the records on the other controls respectively. thank you for the response.

Syed Shanu · Answer

Try like this da.Fill(ds); or da.Fill(ds,"tblStudent");

Error Ado.Net/ Sql/C# need help please

Answers (5)