error in C# code : Must declare the scalar variable image

pooja nirmalkar

10y2.5kC# Corner

{

string image_name = "";

SqlCommand cmd1 = new SqlCommand("Select Image from Slider_Data where Section=@Section", con);

cmd1.Parameters.AddWithValue("@Section", ddlsection.SelectedValue);

con.Open();

SqlDataReader dr = cmd1.ExecuteReader();

if (dr.Read())

{

image_name = dr["Image"].ToString();

}

cmd1.Parameters.AddWithValue("@Image", image_name);

con.Close();

}

cmd.Parameters.AddWithValue("@Description",CKEditorControl.Text);

con.Open();

int i = cmd.ExecuteNonQuery();

if (i == 1)

{

Response.Write("");

}

con.Close();

}

catch(Exception ex)

{

Response.Write(ex.Message);

}

10 Replies

Know the answer? Post it — somebody with the same question will find it here.

Ravi Patel10y ago
Accepted answer
cmd = new SqlCommand("Update Slider_Data set Heading=@Heading, Caption=@Caption, Image=@Image, Description=@Description",con);
cmd.Parameters.AddWithValue("@Section", ddlsection.SelectedValue);
cmd.Parameters.AddWithValue("@Heading", Txt_Head.Text);
cmd.Parameters.AddWithValue("@Caption",Txt_Cap.Text);
if (FileUpload1.HasFile)
{
con.Open();
FileUpload1.SaveAs(Server.MapPath("~/Slider_Uploads" + FileUpload1.PostedFile.FileName));
cmd.Parameters.AddWithValue("@Image", FileUpload1.PostedFile.FileName);
cmd.ExecuteNonQuery();
con.close()
}
else
{
string image_name = "";
SqlCommand cmd1 = new SqlCommand("Select Image from Slider_Data where Section=@Section", con);
cmd1.Parameters.AddWithValue("@Section", ddlsection.SelectedValue);
con.Open();
SqlDataReader dr = cmd1.ExecuteReader();
if (dr.Read())
{
image_name = dr["Image"].ToString();
con.close();
}
con.open();
cmd 2= new SqlCommand("Update Slider_Data set Image=@Image",con); // write where condition in update query otherwise it will update all row
cmd2.Parameters.AddWithValue("@Image", image_name);
cmd.ExecuteNonQuery();
con.Close();
}
Nishant Mittal10y ago
HI

u need to accept all the comments..

cheers.. :)
pooja nirmalkar10y ago
Thanks Everyone:-)

Error solved...Actually i was using cmd1 instead of cmd
Raja T10y ago
Hi Pooja,

cmd = new SqlCommand("Update Slider_Data set Heading=@Heading, Caption=@Caption, Image=@Image, Description=@Description", con);
cmd.Parameters.AddWithValue("@Section", ddlsection.SelectedValue);
cmd.Parameters.AddWithValue("@Heading", Txt_Head.Text);
cmd.Parameters.AddWithValue("@Caption", Txt_Cap.Text);
if (FileUpload1.HasFile)
{
FileUpload1.SaveAs(Server.MapPath("~/Slider_Uploads" + FileUpload1.PostedFile.FileName));
cmd.Parameters.AddWithValue("@Image", FileUpload1.PostedFile.FileName);
}
else
{
string image_name = "";
SqlCommand cmd1 = new SqlCommand("Select Image from Slider_Data where Section=@Section", con);
cmd1.Parameters.AddWithValue("@Section", ddlsection.SelectedValue);
con.Open();
SqlDataReader dr = cmd1.ExecuteReader();
if (dr.Read())
{
image_name = dr["Image"].ToString();
}
cmd1.Parameters.AddWithValue("@Image", image_name);
con.Close();
}

above code please confirm

1 ) where is declare @Description

2) why adding two times "cmd1.Parameters.AddWithValue("@Section", ddlsection.SelectedValue);"
pooja nirmalkar10y ago
cmd1.Parameters.AddWithValue("@Image", image_name);

it will work for the else part for sending the same value of image to the database when image is not updated.
Ravi Patel10y ago
Hi ,
try this
cmd = new SqlCommand("Update Slider_Data set Heading=@Heading, Caption=@Caption, Image=@Image, Description=@Description",con);
cmd.Parameters.AddWithValue("@Section", ddlsection.SelectedValue);
cmd.Parameters.AddWithValue("@Heading", Txt_Head.Text);
cmd.Parameters.AddWithValue("@Caption",Txt_Cap.Text);
if (FileUpload1.HasFile)
{
con.Open();
FileUpload1.SaveAs(Server.MapPath("~/Slider_Uploads" + FileUpload1.PostedFile.FileName));
cmd.Parameters.AddWithValue("@Image", FileUpload1.PostedFile.FileName);
cmd.ExecuteNonQuery();
con.close()
}
else
{
string image_name = "";
SqlCommand cmd1 = new SqlCommand("Select Image from Slider_Data where Section=@Section", con);
cmd1.Parameters.AddWithValue("@Section", ddlsection.SelectedValue);
con.Open();
SqlDataReader dr = cmd1.ExecuteReader();
if (dr.Read())
{
image_name = dr["Image"].ToString();
}
//cmd1.Parameters.AddWithValue("@Image", image_name); // i do not understand what is purpose of this
//con.Close();
}
pooja nirmalkar10y ago
Hi Nishant

I think image name is correct because the code is working when i update image but it dose not work when image is not updated.

cmd = new SqlCommand("Update Slider_Data set Heading=@Heading, Caption=@Caption, Image=@Image, Description=@Description",con);
cmd.Parameters.AddWithValue("@Section", ddlsection.SelectedValue);
cmd.Parameters.AddWithValue("@Heading", Txt_Head.Text);
cmd.Parameters.AddWithValue("@Caption",Txt_Cap.Text);
if (FileUpload1.HasFile)
{
FileUpload1.SaveAs(Server.MapPath("~/Slider_Uploads" + FileUpload1.PostedFile.FileName));
cmd.Parameters.AddWithValue("@Image", FileUpload1.PostedFile.FileName);
}
else
{
string image_name = "";
SqlCommand cmd1 = new SqlCommand("Select Image from Slider_Data where Section=@Section", con);
cmd1.Parameters.AddWithValue("@Section", ddlsection.SelectedValue);
con.Open();
SqlDataReader dr = cmd1.ExecuteReader();
if (dr.Read())
{
image_name = dr["Image"].ToString();
}
cmd1.Parameters.AddWithValue("@Image", image_name);
con.Close();
}
pooja nirmalkar10y ago
hi ravi

yes i have written update code

cmd = new SqlCommand("Update Slider_Data set Heading=@Heading, Caption=@Caption, Image=@Image, Description=@Description",con);
cmd.Parameters.AddWithValue("@Section", ddlsection.SelectedValue);
cmd.Parameters.AddWithValue("@Heading", Txt_Head.Text);
cmd.Parameters.AddWithValue("@Caption",Txt_Cap.Text);
if (FileUpload1.HasFile)
{
FileUpload1.SaveAs(Server.MapPath("~/Slider_Uploads" + FileUpload1.PostedFile.FileName));
cmd.Parameters.AddWithValue("@Image", FileUpload1.PostedFile.FileName);
}
else
{
string image_name = "";
SqlCommand cmd1 = new SqlCommand("Select Image from Slider_Data where Section=@Section", con);
cmd1.Parameters.AddWithValue("@Section", ddlsection.SelectedValue);
con.Open();
SqlDataReader dr = cmd1.ExecuteReader();
if (dr.Read())
{
image_name = dr["Image"].ToString();
}
cmd1.Parameters.AddWithValue("@Image", image_name);
con.Close();
}

if part is working properly but there is a error in else part...please have a look
Ravi Patel10y ago
Hi Pooja,
its seem error is coming beacause of this @Image
cmd1.Parameters.AddWithValue("@Image", image_name);

so you have to decalre @Image in the query
like "Select Image from Slider_Data where Section=@Section"
SqlCommand cmd1 = new SqlCommand("Select Image from Slider_Data where Section=@Section", con);
cmd1.Parameters.AddWithValue("@Section", ddlsection.SelectedValue);

and also where you have written update query ?
Nishant Mittal10y ago
Hi

Seems you have declared a varible not providing value for the same.

Can u please check the value of "image_name" and get back..