error:not all code path returns a value

Monica Priyadharshini

9y884.NET

Hi,

i wrote a function in DAL layer which uses the stroreprocedure for returns the integer value but its ahowing an error.

my code is:

public int restrictionInCourse(int studentID,int CourseID)

{

int id;

SqlConnection con = new SqlConnection(constring);

SqlCommand cmd;

try

{

con.Open();

cmd = new SqlCommand();

cmd.Connection = con;

cmd.CommandText = "spCourseRestrict";

cmd.CommandType = CommandType.StoredProcedure;

cmd.Parameters.Add("@courseID", CourseID);

cmd.Parameters.Add("@StudentID", studentID);

id = Convert.ToInt32(cmd.ExecuteScalar());

return id;

}

catch (Exception ex)

{

Console.WriteLine(ex.Message);

}

my storeprocedure is:

CREATE PROC spCourseRestrict

@StudentID int,

@courseID int

Begin

DECLARE @Status int

SET @Status=0

IF(@courseID=116)

BEGIN

IF Exists(SELECT courseID FROM dbo.CourseRegistrationStd WHERE CourseID=111 and UserID=@studentID)

BEGIN

SET @Status=1

END

SELECT @Status

END

cana anyone help me?

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Ankit Sharma9y ago
Accepted answer
Hi Monica,

since you are returning int from the method, you have to return value from catch block also.
this insures the method returns in case of exception also.
update your code as below
public int restrictionInCourse(int studentID, int CourseID)
        {
            int id;
            string constring = "";
            SqlConnection con = new SqlConnection(constring);
            SqlCommand cmd;

            try
            {
                con.Open();
                cmd = new SqlCommand();
                cmd.Connection = con;
                cmd.CommandText = "spCourseRestrict";
                cmd.CommandType = CommandType.StoredProcedure;
                cmd.Parameters.Add("@courseID", CourseID);
                cmd.Parameters.Add("@StudentID", studentID);
                id = Convert.ToInt32(cmd.ExecuteScalar());
                return id;
            }
            catch (Exception ex)
            {
                Console.WriteLine(ex.Message);
                return 0; //add this line
            }
        }
hope this helps
Monica Priyadharshini9y ago
thank you.
Manas Mohapatra9y ago
You are getting error because your code doesn't return always. It returns only try block ; what if exception occurrs it doesn't return anything. Try like below:
public int restrictionInCourse(int studentID, int CourseID)
{
    int id = 0;
    try
    {
        // Your code...but do not return

    }
    catch (Exception ex)
    {
        Console.WriteLine(ex.Message);
    }

    return id; // Return here
}
Only Entertaiment9y ago
There is problem with your query i am not familiar with this but i am pretty sure your db command getting nothing from db that is why its not return a value