Fail to pass OrderId to the receipt

Hello team, 

With reference to my earlier post with the issues of the OrderNumber and the OrderDate catching null reference error on the receipt view page, any additional information will highly appreciated.

This the OrderId value in the URL

On the Receipt View Page

@model SmartRestaurantManagement.ViewModel.OrderViewModel

An exception of type 'System.NullReferenceException' occurred in App_Web_4doslt4g.dll but was not handled in user code

Additional information: Object reference not set to an instance of an object.

The array of the data always get saves perfectly into the database but the error occurs on the receipt view page, and because it is not able to pass the data to the receipt.

The OrderNumber is generated within the CreatePOS view page and order details are pass from the POSController to the OrderRepository to the database.

Additional help will be highly appreciated.

Thank you Mr Paul.

For the route, I created POSController for the order view page and the receipt view page, the HomeController maintain the default route, and also the system consist of two logins details such as the admin page for the dashboard side and POS system  for the sales and printing of receipts.

I follow your steps alright but the OrderNumber, and OrderDate keep catching this NullReferenceException error and also says; Object reference not set to an instance of an object.

The error you are encountering occurs because the PrintSalesReceipts action method in your HomeController is expecting a non-nullable integer (int) parameter named orderId, but the value being passed to it is null. Since int is a value type and cannot accept null, the framework throws this exception. Your PrintSalesReceipts method likely looks like this:

public ActionResult PrintSalesReceipts(int orderId)
{
    // Logic to generate and return the receipt
}

Here, orderId is a required parameter of type int. If no value is provided for orderId or if the value is null, the framework cannot bind it to the int parameter.

• When navigating to the PrintSalesReceipts action (e.g., via a redirect or URL), the orderId parameter is either missing or not properly passed.
• This could happen due to:
  • A missing or incorrect query string parameter in the URL.
  • A failure to pass the orderId during redirection after saving the order.

The ASP.NET MVC framework attempts to bind route values, query strings, or form data to the action method parameters. If the binding fails (e.g., orderId is null or missing), it throws the error you are seeing. 

Save the Order

[HttpPost]
public ActionResult SaveOrder(OrderModel order)
{
    if (ModelState.IsValid)
    {
        // Save the order to the database
        var savedOrder = _orderService.Save(order);

        // Redirect to the PrintSalesReceipts action with the orderId
        return RedirectToAction("PrintSalesReceipts", new { orderId = savedOrder.Id });
    }

    // If the model is invalid, return to the form
    return View(order);
}

Print the Receipt

[HttpGet]
public ActionResult PrintSalesReceipts(int orderId)
{
    // Fetch the order details from the database
    var orderDetails = _orderService.GetOrderById(orderId);

    if (orderDetails == null)
    {
        return HttpNotFound("Order not found.");
    }

    // Pass the order details to the view
    return View(orderDetails);
}

View (PrintSalesReceipts.cshtml):

@model YourNamespace.OrderModel

Order Receipt
Order Number: @Model.OrderNumber
Order ID: @Model.Id

• Validate your route configuration to ensure it supports passing the orderId parameter.
• Debug the generated URL to confirm that the orderId is included.

Hello, you guys are right, I did that modification and it look like the receipt page view is not receiving the Order number generated to print the order so due to that it giving a null error, which I'm having trouble in fixing it 

It looks like the error you're facing is due to the fact that the PrintSalesReceipts(int orderId) method requires a non-nullable int, but you’re passing null or not passing orderId at all when calling that action @Space Waves

Means:

• Your PrintSalesReceipts(int orderId) action expects a non-null orderId (an int is non-nullable).

• But no value (or a null) is being passed for orderId in the URL or route data.

• The MVC model binder can’t assign null to a non-nullable int.

Root causes

Here are some common reasons for this error:
The route or query string didn’t provide a value for orderId.
Example:

/Home/PrintSalesReceipts ? No orderId in URL

instead of

/Home/PrintSalesReceipts?orderId=123 or /Home/PrintSalesReceipts/123

Solutions

Make orderId nullable

 

public ActionResult PrintSalesReceipts(int? orderId)
{
    if (!orderId.HasValue)
    {
        return new HttpStatusCodeResult(HttpStatusCode.BadRequest, "Order ID is required.");
    }

    // Proceed with orderId.Value
    ...
}