i have loop problem

Zakir Ahamed

9y913Windows Forms

hi this is my code i have selected values prblem:

else if (btncategory.Text == "Update")

{

string ChkSelectedValue = string.Empty;

//object chBoxListTables = null;

for (int i = 0; i < clbbrand.Items.Count; i++)

{

if (clbbrand.Items[i].Selected) -->> prblm Selected**

{

ChkSelectedValue = clbbrand.Items[i].Value + ','; -->> Value** Passing Prblm

}

//int Items = 0;

//for (int i = 0; i < clbbrand.Items.Count; i++)

//{

// if (clbbrand.Items[i].Selected)

// //if(clbbrand.SelectedIndex > 0)

// {

// ChkSelectedValue = chBoxListTables.Items[i].Value+ ',';

// }

//}

Hashtable hstbl = new Hashtable();

DataGridViewRow row = GvCategory.Rows[indexRow];

hstbl.Add("@status", "update");

hstbl.Add("@CategoryId", Convert.ToInt32(row.Cells[0].Value));

hstbl.Add("@updatedby", Global.UserID);

hstbl.Add("@BrandId",ChkSelectedValue);

Int64 dt = DataAccessLayer.ExecuteCommand_RowsAffected("Category_Mst_sp", hstbl);

if (dt >= 0)

{

MessageBox.Show("Category Details Updated Sucessfully", "Category Alert");

txtcategory.Text = string.Empty;

LoadCategory();

btncategory.Text = "SAVE";

}

else

{

MessageBox.Show("Already Entered the Category");

}

else

{

string title = "Category";

MessageBox.Show("Please Enter the Category", title);

}

catch (Exception exceptionObj)

{

MessageBox.Show(exceptionObj.Message.ToString());

}

8 Replies

Know the answer? Post it — somebody with the same question will find it here.

James Axsom8y ago
Hi Zakir,

This may provide you inspiration or ideas to resolve your issue.

Application Image:

C# Winforms Code:
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;

namespace Sandbox2
{
    public partial class MyMainForm : Form
    {
        // Support Variables
        StringBuilder m_brandIDs = new StringBuilder();
        int m_checkCount = 0;

        public MyMainForm()
        {
            InitializeComponent();
        }


        private void MyMainForm_Load(object sender, EventArgs e)
        {
            // Setup UI Control States
            InitializeListCheckListBox();
            btnClear.Enabled = GetClearButtonEnabledState();
            btnUpdate.Enabled = GetUpdateButtonEnabledState();
        }

        private void InitializeListCheckListBox()
        {
            // create data to populate check listbox clbBrand
            clbBrand.Items.Add(new Brand(1, "Apple"));
            clbBrand.Items.Add(new Brand(2, "Samsung"));
            clbBrand.Items.Add(new Brand(3, "Microsoft"));
            clbBrand.Items.Add(new Brand(4, "Google"));
            clbBrand.Items.Add(new Brand(5, "LG Electronics"));
            clbBrand.Items.Add(new Brand(6, "Sony"));
            clbBrand.Items.Add(new Brand(7, "Motorola"));
            clbBrand.Items.Add(new Brand(8, "HTC"));
            clbBrand.Items.Add(new Brand(9, "Huawei"));
        }

        private Boolean GetClearButtonEnabledState()
        {
            // Method: GetClearButtonEnabledState
            // Return: Boolean
            // returns a new state for button enabled based on runtime conditions

            // default value is always false
            Boolean result = false;

            // conditions for true
            // there must be at minimum 1 checked item in the checklistbox
            Boolean condition1 = (m_checkCount > 0);

            result = (condition1 == true);

            return result;
        }

        private Boolean GetUpdateButtonEnabledState()
        {
            // Method: GetUpdateButtonEnabledState
            // Return: Boolean
            // returns a new state for button enabled based on runtime conditions

            // default value is always false
            Boolean result = false;

            // conditions for true
            // there must be at minimum 1 checked item in the checklistbox
            Boolean condition1 = (m_checkCount > 0);

            result = (condition1 == true);

            return result;
        }

        private void clbBrand_ItemCheck(object sender, ItemCheckEventArgs e)
        {
            // Method: clbBrand_ItemCheck
            // Return: None
            // Create a comma delitmed output string as an item is (un)checked

            // ItemCheck Event Gotcha: This event fires first, then
            // CheckedItems colletion is populated with the checked item
            // as a result one can't use CheckedItems or CheckIndices during this event

            // Support Variables
            int checkedIndex = e.Index;
            CheckState isChecked = e.NewValue;
            Brand brand = (Brand)clbBrand.Items[checkedIndex];

            // add or subtract everytime you (un)check an item
            if(isChecked==CheckState.Checked)
            {
                m_checkCount++;

                if(m_checkCount==1)
                {
                    m_brandIDs.Append(brand.BrandID.ToString());
                }
                else
                {
                    m_brandIDs.Append(",");
                    m_brandIDs.Append(brand.BrandID.ToString());
                }

            }
            else
            {
                if(m_checkCount==1)
                {
                    m_brandIDs.Replace(brand.BrandID.ToString(), "");
                }
                else
                {
                    m_brandIDs.Replace(string.Concat(brand.BrandID.ToString(), ","), "");
                }

                m_checkCount--;
            }

            // display concatnated brand ids
            lblBrandIDs.Text = m_brandIDs.ToString();

            // update ui control state
            btnClear.Enabled = GetClearButtonEnabledState();
            btnUpdate.Enabled = GetUpdateButtonEnabledState();

        }

        private void btnClear_Click(object sender, EventArgs e)
        {
            // Method: btnClear_Clear
            // Return: None
            // unchecks all checked items, resets checkCount and clears the stringbuilder

            m_checkCount = 0;

            for (int index=0; index < clbBrand.Items.Count - 1; index++)
            {
                clbBrand.SetItemChecked(index, false);
            }

            m_brandIDs.Clear();

            lblBrandIDs.Text = m_brandIDs.ToString();
        }

        private void btnUpdate_Click(object sender, EventArgs e)
        {
            MessageBox.Show(string.Concat(m_brandIDs.ToString() + " successfully updated."), "Brand IDs", MessageBoxButtons.OK, MessageBoxIcon.Information);
        }
    }


    public struct Brand
    {
        private int m_brandID;
        private string m_brandName;

        public Brand(int brandID, string brandName)
        {
            m_brandID = brandID;
            m_brandName = brandName;
        }

        public int BrandID
        {
            get { return m_brandID; }
        }

        public string BrandName
        {
            get { return m_brandName; }
        }

        public override string ToString()
        {
            return m_brandName;
        }
    }
}
Have a great day.
0
Amit Gupta9y ago
@Zakir

Why you are using
if (clbbrand.GetItemChecked(i))

Please understand the code, what is it doing and for what purpose it was being implemented, as we are looping through CheckedIndices, it will only loop through the checked items.

Moreover, your question was quite confusing and not clear to understand the requirement, please be specific to the question you are asking for. Your question is changing on every post.

Be straight forward to your question like
1. What should be the output
2. What should be the input.
3. What should ve the best possible way to resolve the issue.

Consider the above points before asking any question, so that one can understand what is the issue because its only you who know the requirement.

Hope you understood !
+1
Zakir Ahamed9y ago
hi ji, i will send my sp and Function and Table Details and Developing COde:

Function in Sql Server 2012:

USE [RetailStore_DEV_V1]
GO
/****** Object: UserDefinedFunction [dbo].[fnSplitString] Script Date: 30-08-2017 17:00:31 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER FUNCTION [dbo].[fnSplitString]
(
@Input NVARCHAR(MAX),
@Character CHAR(1)
)
RETURNS @Output TABLE (ROWID INT,
Item NVARCHAR(1000)
)
AS
BEGIN
DECLARE @StartIndex INT, @EndIndex INT,@Loop INT

SET @StartIndex = 1
SET @Loop=1
IF SUBSTRING(@Input, LEN(@Input) - 1, LEN(@Input)) <> @Character
BEGIN
SET @Input = @Input + @Character
END

WHILE CHARINDEX(@Character, @Input) > 0
BEGIN
SET @EndIndex = CHARINDEX(@Character, @Input)

INSERT INTO @Output(ROWID,Item)
SELECT @Loop,SUBSTRING(@Input, @StartIndex, @EndIndex - 1)
SET @Loop=@Loop+1;
SET @Input = SUBSTRING(@Input, @EndIndex + 1, LEN(@Input))
END

RETURN
END
StoreProcedure I Write in SQL SEREVR:

if @status='update'
begin
update Category_Mst set UpdatedBy=@UpdatedBy,Updateddate=GETDATE() where CategoryId = @CategoryId
--update Category_Brand_tbl set BrandId=@BrandId,UpdatedBy=@UpdatedBy,Updateddate=GETDATE() where CategoryId = @CategoryId
Declare @TempTableVariable TABLE(
RowId Int,
BrandId int)
INSERT INTO @TempTableVariable
select * from dbo.[fnSplitString](@BrandId, ',')
--SELECT * FROM @TempTableVariable
DECLARE @I INT
DECLARE @Count INT
SET @Count =(SELECT COUNT(*) FROM @TempTableVariable)
SET @I = 1
WHILE @I <= @Count
BEGIN
update Category_Brand_tbl set
BrandId=(SELECT BrandId FROM @TempTableVariable WHERE RowId=@I),
UpdatedBy=@UpdatedBy,
Updateddate=GETDATE()
where CategoryId=@CategoryId
and Active=1
SET @I = @I + 1
END
END

DEveloping Code:

else if (btncategory.Text == "Update")
{
string ChkSelectedValue = string.Empty;
//for (int i = 0; i < clbbrand.Items.Count; i++)
//{
// if (clbbrand.GetItemChecked(i))
// {
// ChkSelectedValue += clbbrand.SelectedValue + ",";
// }
//}
var chkitems = clbbrand.CheckedIndices;
for (int i = 0; i < chkitems.Count; i++)
{
var value = chkitems[i].ToString();
// do your stuff here
if (clbbrand.GetItemChecked(i))
{
ChkSelectedValue = clbbrand.Items[i] + ",";
}
}
Hashtable hstbl = new Hashtable();
DataGridViewRow row = GvCategory.Rows[indexRow];
hstbl.Add("@status", "update");
hstbl.Add("@CategoryId", Convert.ToInt32(row.Cells[0].Value));
hstbl.Add("@updatedby", Global.UserID);
hstbl.Add("@BrandId", Convert.ToInt32(chkitems[0]));

Int64 dt = DataAccessLayer.ExecuteCommand_RowsAffected("Category_Mst_sp", hstbl);
if (dt >= 0)
{
MessageBox.Show("Category Details Updated Sucessfully", "Category Alert");
txtcategory.Text = string.Empty;
LoadCategory();
btncategory.Text = "SAVE";
}

else
{
MessageBox.Show("Already Entered the Category");
}
}
}
else
{
string title = "Category";
MessageBox.Show("Please Enter the Category", title);
}
}
catch (Exception exceptionObj)
{
MessageBox.Show(exceptionObj.Message.ToString());
}
}

Table Is LIke :

Category id 1 means,Brandid 1,2,3...

Really i have Problem in this Update Please help me..I am Really Confused

0
Amit Gupta9y ago
If I understood correctly, you want to get the index of the checkedItems?

If it is like that then replace your CheckedItems with CheckedIndices. This will return from the index 0, you can apply to suit your need
var chkitems = checkedListBox1.CheckedIndices;
for (int x = 0; x < chkitems.Count; x++)
{
         var value = chkitems[x].ToString();
         // do your stuff with value
}
Do let me know, if its like that or something else
0
Zakir Ahamed9y ago
hi

i am used u given code i will do some modulation it is working but my brandid value coming same id ex:id value 1,1,1,1,1.

i choose checked list box 1,2,3,4,5.

this the problem:

var chkitems = clbbrand.CheckedItems;
for (int i = 0; i < chkitems.Count; i++)
{
var value = chkitems[i].ToString();
// do your stuff here
if (clbbrand.GetItemChecked(i))
{
ChkSelectedValue += clbbrand.SelectedValue + ",";
}
}

please one more time Evaluate the whole code..please
0
Amit Gupta9y ago
Instead of iterating through all the items, why not just using the checkitems

Try like
var chkitems = checkedListBox1.CheckedItems;
for (int x = 0; x < chkitems.Count; x++)
{
         var value = chkitems[x].ToString();
         // do your stuff here
}
There is nothing like Selected or Value
clbbrand.Items[i].Selected

The array of the checkedlistbox will return on object, cast it to your respective datatype, if required.

Good Luck
0
Zakir Ahamed9y ago
clbbrand is a checklistbox Name ..

my prblm is i am Create a MultilistCheck box...it will be connected with Sql server..

i will do Get,Insert,Delete and Update

I will Finished Get,Insert,Delete

in Update is my Problem, i am not able to set the selcetd list item..and is not Update in Sql Serever
0
Amit Gupta9y ago
Hey

Will you elaborate your problem in a more specific way?
which control is this clbbrand
0