insert error

PankaJ D

SqlConnection cn = new SqlConnection(MyConn.cnstring);
//string sql = "insert into Insert1 values(?,?,?,?,?)";

SqlCommand cmd ;
cmd = new SqlCommand("insert into Insert1 values(?,?,?,?,?)", cn);

cmd.Parameters.AddWithValue("sname", txtname.Text);
cmd.Parameters.AddWithValue("srno", txtrno.Text);
cmd.Parameters.AddWithValue("sdob", dob.Value);
cmd.Parameters.AddWithValue("sadd", txtadd.Text);
cmd.Parameters.AddWithValue("sgender", cmdgender.Text);
cn.Open();
cmd.ExecuteNonQuery();
cn.Close();

When I use this code folowing error will gererate
"Incorrect syntax near '?'."

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Amit Choudhary16y ago

hi friend,

use following syntax to user parameterized query with command object:

 SqlCommand cmdDatabase =
            new SqlCommand("SELECT * FROM dbo.Cars " +
                                 "WHERE TagNumber = @TagNbr;", conDatabase);

            cmdDatabase.Parameters.Add("@TagNbr", SqlDbType.VarChar);
            cmdDatabase.Parameters["@TagNbr"].Value = txtTagNumber.Text;

you can user cmd.Parameters.AddWithValue(); method also but use @.

Please mark it as answer if it helps you.

PankaJ D16y ago
For hitendra-> This is not a ans of my question. I know this way.
Hirendra Sisodiya16y ago
you can use this code instead of above :
SqlConnection cn = new SqlConnection(MyConn.cnstring);
cn.Open();
SqlCommand cmd ;
cmd = new SqlCommand("insert into Insert1 values('"+ txtname.Text +"','"+ txtrno.Text +"','"+ dob.Text +"','"+ txtadd.Text +"','"+ cmdgender.Text +"',)", cn);
cmd.ExecuteNonQuery();
cn.Close();
thanks
Lalit M16y ago
I thunk you are missing the opening parenthesis for your INSERT command,please check and try.