Paint Bucket function code in C# ,hangs when running

2 down vote favorite

I try to use stack class for paint bucket function ,but when running and clicking on selected area in picture box to be filled with selected color, nothing happens and cpu usage goes up to %100 and system hangs! here is the code,first, picture box code for selecting this function and call fill function after clicking:

private void pictureBox1_MouseDown(object sender, MouseEventArgs e)
{

if (act == "color")
{

fill(bmp, e.X, e.Y, bmp.GetPixel(e.X, e.Y));
pictureBox1.Image = bmp;

}
=================================================

private void fill(Bitmap picture, int x, int y, Color bcolor)
        {

            if (x > 0 && x < picture.Width && y > 0 && y < picture.Height)
             {

                 Point p = new Point(x, y);
                 Stack s = new Stack();
                 s.Push(p);
                 while (s.Count != 0)
                 {
                     p = s.Pop();
                     Color currentcolor = picture.GetPixel(p.X, p.Y);

                     if (currentcolor == bcolor)
                     {
                         picture.SetPixel(p.X, p.Y, currentcolor);
                         s.Push(new Point(p.X - 1, p.Y));
                         s.Push(new Point(p.X + 1, p.Y));
                         s.Push(new Point(p.X, p.Y - 1));
                         s.Push(new Point(p.X, p.Y + 1));

                     }

So ,any suggestion for correcting or a better code for paint bucket?

1 Reply

Know the answer? Post it — somebody with the same question will find it here.

Anil Sadangi10y ago
Maybe your code hangs because the stack could be growing infinitely. Try to debug it and see if it never stops growing. To do that, put a counter inside the while loop and keep increasing it with every loop. If the counter exceeds the total size of the image (width * height), that could mean your loop never finishes.

Anyway there's some other approach to implementing Paint Bucket in this post:
http://support.leadtools.com/SupportPortal/CS/forums/44770/ShowPost.aspx