Passing 2 parameters but only 1 from sql server DB

Jes Sie

Is it possible to pass 2 parameters in web application but only 1 parameter comes from sql server db? The other parameter comes from a pre set dropdownlist. If it's possible, how to do it? This is what I have in mind but not sure if it is correct.

public static List GetCompulsoryCoverage(string vehicleType, string Option)
{
List getVehicleType = new List();
using (SqlConnection con = DBConnection.GetDbCon())
{
SqlCommand cmd = new SqlCommand("select * from tblCompulsoryTable where VehicleType = @VehicleType", con);
cmd.CommandType = CommandType.Text;
cmd.Parameters.AddWithValue("@VehicleType", vehicleType);
cmd.Parameters.AddWithValue("@CompulsoryOptions", Option);
con.Open();
SqlDataReader rdr = cmd.ExecuteReader();
while (rdr.Read())
{
CompulsoryTable Vehicles = new CompulsoryTable();
Vehicles.VehicleType = rdr["VehicleType"].ToString();
getVehicleType.Add(Vehicles);
}
}
return getVehicleType;
}

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Nitin Sontakke9y ago
Accepted answer
Of course it is possible. But please explain what you are trying to achieve here. I can see that you are passing value for @vehicleType but other parameter @compulsoryOptions is just declared but never used. Why?

In general, if possible, do not use rdr["VehicleType"].ToString() syntax. Use rdr.GetString(0) instead. Where 0 is ordinal position of the column starting with 0 just as arrays.
Jes Sie9y ago
Hi Nitin Sontakke, again thanks for the insight. I'm taking your suggestion not to use this kind of syntax (rdr["VehicleType"].ToString()).

As for my question, I found a way to solve it. I used the parameter vehicle fromt the DB and uses a dropdownlist to satisfy my other parameter.
Nitin Sontakke9y ago
May be you should also have a sqlDataReader creation encapsulated inside a using clause.
Nitin Sontakke9y ago
In addition, you have a constructor defined in CompulsoryTable class which will accept VehicleType and you can have all of this in just one line as:

getVehicleType.Add(new CompulsoryTable(rdr.GetString(0)));

Simple and elegent. Otherwise what is the use of OOP?