Robust Dictionary Exception Handling

David Smith

I basically want to make sure I incorporate all exception handling possible for ArrayDictionary below.

What are all the possible exception handling you can do for the dictionary and dictionary arrays below. I know a few contraints off the top, All three Dictionaries must have the number of items or count which is 5 items each after items are being added. If not we can't continue. Another contraint will be to ensure that the dictionary count is three. and you can also check is dictionary is not null.

What are more checks and balances or exception handling?

review the next reply.

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes14y ago
Incidentally, although it's something I'm occasionally guilty of myself, when assigning to a bool variable you don't need to use C#'s ternary operator if the RHS is just a simple expression.

Instead of:

IsArrayDataDictionaryValidated = (ArrayDataDictionary[arrayDataDictionaryItem .Key.ToString()].Count != 5) ? false : true;

You can simply write :

IsArrayDataDictionaryValidated = (ArrayDataDictionary[arrayDataDictionaryItem .Key.ToString()].Count == 5);
David Smith14y ago
thanks, this is what i am already doing below.

//Validating each data array dictionary item count.
foreach (var arrayDataDictionaryItem in ArrayDataDictionary)
{

IsArrayDataDictionaryValidated = (ArrayDataDictionary[arrayDataDictionaryItem .Key.ToString()].Count != 5) ? false : true;

if (!IsArrayDataDictionaryValidated )
{ throw new NotImplementedException("Array dictionary primary key " + arrayDataDictionaryItem .Key.ToString() + " does not implement 1101 items: "); }
}
Vulpes14y ago
Well, firstly, the code won't compile as it stands because the arguments have no types (I know they're double arrays from previous threads) and because you're trying to add scalar double values to a list which is expecting arrays of doubles.

Secondly, there's no need to call ArrayDictionary.Clear() because you've only just instantiated it in the previous line and it must therefore be empty.

As far as error handling is concerned you only need to check that the 3 array arguments are not null and have a length of 5. As far as I can see nothing else can go wrong:

public Dictionary> ArrayDictionary { get; set; }

public void ConstructArray(double[] ADict1, double[] ADict2, double[] ADict3)
{
if(ADict1 == null || ADict2 == null || ADict3 == null) throw new ArgumentException("Array argument cannot be null");
if(ADict1.Length != 5 || ADict2.Length !=5 || ADict3.Length != 5) throw new ArgumentException("Array argument must have a length of 5");

ArrayDictionary = new Dictionary>();

foreach (ArrayType arrayDictionaryItem in Enum.GetValues(typeof(ArrayType)))
{
ArrayDictionary.Add(arrayDictionaryItem.ToString(), new List());

switch (arrayDictionaryItem)
{
case ArrayType.Array1:

ArrayDictionary[arrayDictionaryItem.ToString()].Add(ADict1);
break;

case ArrayType.Array2:

ArrayDictionary[arrayDictionaryItem.ToString()].Add(ADict2);
break;

case ArrayType.Array3:

ArrayDictionary[arrayDictionaryItem.ToString()].Add(ADict3);
break;
}
}
}
David Smith14y ago
enum ArrayType{ Array1, Array2, Array3}

public Dictionary> ArrayDictionary { get; set; }

ContructArrayDictionar(ADict1 [], ADict2 [], ADict3 [])
{
ArrayDictionary = new Dictionary>();
ArrayDictionary.Clear();

foreach (ArrayType arrayDictionaryItem in Enum.GetValues(typeof(ArrayType)))
{
ArrayDictionary .Add(arrayDictionaryItem .ToString(), new List());

switch (arrayDictionaryItem )
{
case ArrayType.ArrayType1:

foreach (var ADict1Item in ADict1 )
{
ArrayDictionary[arrayDictionaryItem .ToString()].Add(ADict1Item );
}

break;

case ArrayType.ArrayType2:

foreach (var ADict2Item in ADict2)
{
ArrayDictionary[arrayDictionaryItem .ToString()].Add(ADict2Item );
}
break;

}
}