Some time the same message. Need to resolv...

Israel

9y823Learn iOS Programming

Hi,

I wrote these codes but why some time I receive this message and how can to resolv it please forever:

The connection was not closed. The connection's current state is open.

conn.Open();

OleDbCommand cmd = conn.CreateCommand();

cmd.CommandType = CommandType.Text;

cmd.CommandText = "select * from cadastramento order by ID";

cmd.ExecuteNonQuery();

DataTable dt = new DataTable();

OleDbDataAdapter da = new OleDbDataAdapter(cmd);

da.Fill(dt);

conn.Close();

dGVCons.DataSource = dt;

dGVCons.CurrentCell = dGVCons.Rows[dGVCons.Rows.Count - 1].Cells[0];

5 Replies

Know the answer? Post it — somebody with the same question will find it here.

Amit Gupta9y ago
Create a centralized method to get the connection. Public static OleDbConnection GetConnection () { var conn = new OleDbConnection(connstr)) if (conn.ConnectionState!=ConnectionState.Open ()) conn.Open (); return conn; }
Manas Mohapatra9y ago
You can close the connection in following ways:

using: It will auto close the the connection

using (SqlConnection connection = new SqlConnection(connectionString))
{
//etc...
}

Alternatively, add a catch block to the try-finally:

conn.Open();

try
{

}
catch
{

}
finally
{
conn.Close();
}

If it doesn't resolve your problem, please restart your machine/studio so that all open connection will be closed.
Israel9y ago
Hi!

These codes doesnt work properly. It's sturk!
See what I do but still giving the same error message:

conn.Open();
using (OleDbConnection conn = new OleDbConnection(connstr))
{
using (OleDbDataAdapter ad = new OleDbDataAdapter("SELECT * FROM cadastramento", conn))
{
DataTable dt = new DataTable();
ad.Fill(dt);
dGVCadast.DataSource = dt;
dGVCadast.CurrentCell = dGVCadast.Rows[dGVCadast.Rows.Count - 2].Cells[0];
conn.Close();
}
}

I do try also this (even that it's gives the same error message) :

dGVCadast.Rows.Clear();
Prakash Kumar9y ago
Use using statement for auto close the connection once used
using (SqlConnection connection = new SqlConnection(connectionString))
   {
       try
       {
           SqlCommand command = new SqlCommand(queryString, connection);
           command.Connection.Open();
           command.ExecuteNonQuery();
       }
       catch (InvalidOperationException)
       {
           //log and/or rethrow or ignore
       }
       catch (SqlException)
       {
           //log and/or rethrow or ignore
       }
       catch (ArgumentException)
       {
           //log and/or rethrow or ignore
       }
   }
Bikesh Srivastava9y ago
Just Dispose method to end all session.