Too many redirects error in MVC application

Hi All,

I am getting Too many redirects error in my MVC application.

I have kept the debugger in SessionExpire Attribute filter , here debugger goes in loop.

This error is occuring from implementation of Cookie in my project.

My requirement is to keep User session alive until user log out.

My Code:

Account Controller:

[HttpGet]
[AllowAnonymous]
[SessionExpire]
public ActionResult Login(string returnUrl)
{
HttpContext.Request.IsAjaxRequest();
AccountModel userLoginModel = new AccountModel();
string cookieName = "MyCookie";
HttpCookie authCookie = System.Web.HttpContext.Current.Request.Cookies[cookieName];
if (authCookie != null)
{
if (!string.IsNullOrEmpty(authCookie.Value))
{
FormsAuthenticationTicket authTicket = FormsAuthentication.Decrypt(authCookie.Value);
if (authTicket.IsPersistent)
{
userLoginModel.UserName = authTicket.Name;
userLoginModel.RememberMe = authTicket.IsPersistent;
userLoginModel.Password = authTicket.UserData;
}
if (User.Identity.IsAuthenticated)
{
string UserID = GetLoggedInUserData();
//List UserEntity = GetLoggedInUserData();
if (UserID != string.Empty)
{
System.Web.HttpContext.Current.Session["userID"] = UserID;
//string userID = UserEntity[0].UserID.ToString();
//SessionValue.SetLoginData(userID, userRole, userEmail, userBusinessGroupIDs, userLocationIDs);
//UserEntity = null;
}
return RedirectToAction("Index", "Home");
}
}
}
return View();
}
[HttpPost]
[AllowAnonymous]
[ValidateAntiForgeryToken]
public ActionResult Login(AccountModel oModel, string returnUrl)
{
string responseMessage = string.Empty;
string UserName = oModel.UserName;
string Password = oModel.Password;
if (ValidateUser(UserName, Password, ref responseMessage))
{
FormsAuthentication.SetAuthCookie(oModel.UserName, oModel.RememberMe);
int timeout = oModel.RememberMe ? 7 : 1;
FormsAuthenticationTicket authTicket = new
FormsAuthenticationTicket(1, //version
oModel.UserName, // user name
DateTime.Now, //creation
DateTime.Now.AddDays(timeout), //Expiration (you can set it to 1 month
oModel.RememberMe, //Persistent
oModel.Password); // additional informations
string encryptedTicket = System.Web.Security.FormsAuthentication.Encrypt(authTicket);
HttpCookie authCookie = new HttpCookie("MyCookie", encryptedTicket);
if (oModel.RememberMe)
{
authCookie.Expires = authTicket.Expiration;
}
else
{ authCookie.Expires = authTicket.Expiration; }
authCookie.HttpOnly = true;
System.Web.HttpContext.Current.Response.Cookies.Add(authCookie);
FormsIdentity identity = new FormsIdentity(authTicket);
string UserID = GetLoggedInUserData();
if (UserID != string.Empty)
{
System.Web.HttpContext.Current.Session["userID"] = UserID;
//SessionValue.SetLoginData(userID, userRole, userEmail, userBusinessGroupIDs, userLocationIDs);
//UserEntity = null;
}
return RedirectToAction("Index", "Home");
}
else
{
ViewBag.Error = true;
ViewBag.Message = responseMessage;
return View();
}
}

SessionExpire

[AttributeUsage(AttributeTargets.Method, Inherited = true, AllowMultiple = false)]
public class SessionExpireAttribute : ActionFilterAttribute
{
public override void OnActionExecuting(ActionExecutingContext filterContext)
{
HttpContext context = HttpContext.Current;
if (context.Session != null)
{
if (context.Session.IsNewSession == true)
{
string sessionCookie = context.Request.Headers["Cookie"];
if ((sessionCookie != null) && (sessionCookie.IndexOf("ASP.NET_SessionId_My") >= 0))
{
// FormsAuthentication.SignOut();
string redirectTo = "~/Account/Login";
if (!string.IsNullOrEmpty(context.Request.RawUrl))
{
filterContext.HttpContext.Response.Redirect(FormsAuthentication.LoginUrl);
//redirectTo = string.Format("~/Home/Login?ReturnUrl={0}", HttpUtility.UrlEncode(context.Request.RawUrl));
// filterContext.Result = new RedirectResult(redirectTo);
return;
}
}
}
}
base.OnActionExecuting(filterContext);
}
}

2 Replies

Know the answer? Post it — somebody with the same question will find it here.

Sandy8y ago
Accepted answer
Hi Pravin,

One check is missing on Action Filter this will going in recursive loop.
if (!string.IsNullOrEmpty(context.Request.RawUrl) && context.Request.RawUrl != "/Account/Login")
this will complete execution of login action and also in login section, you are also redirecting the user to home page.

Let me know if this will create any other issue or didn't resolve your problem.

Thanks
Sandy
+2
Pravin Ghadge8y ago
Hi Sandy,

You are simply great.

Issue has been resolved
0