update data in control through gridview

Ankita Singh

hello guys... i was show data in textbox control and dropdown control click edit button in gridview after show data i want to update it.. i am showing my code

try

{

string qry = "update City_tbl set State=@State,City =@City where id=@id";

SqlConnection con = new SqlConnection();

SqlCommand cmd = new SqlCommand(qry, con);

cmd.Parameters.AddWithValue("@State", SqlDbType.NVarChar).Value = ddlstate.Text.Trim();

cmd.Parameters.AddWithValue("@City", SqlDbType.NVarChar).Value = TextBox1.Text.Trim();

con.Open();

cmd.ExecuteNonQuery();

con.Close();

FillGrid();

ClearControls();

lblMessage.Text = "Updated Successfully.";

}

catch

{

}

finally

{

if (con.State == ConnectionState.Open)

con.Close();

}

when i use breakpoint and debug then connectionis open but not close and not bind FillGrid() after this data is not updating... please some one tell me where is problem creating... thank you

9 Replies

Know the answer? Post it — somebody with the same question will find it here.

Amit Gupta8y ago
Accepted answer
See the highlighted mistakes
cmd.CommandText = "update City_tbl set State=@State,City=@City where id=@id";
cmd.Parameters.AddWithValue("@State", ddlstate.SelectedValue);
cmd.Parameters.AddWithValue("@City", TextBox1.Text);
cmd.Parameters.AddWithValue("@CustomerID", hidCustomerID.Value);
Ankita Singh8y ago
i was just try taken a input type of id and this id name is hidCustomerID... this id got right value after use breakpoint...

then declare this pramater of id in coding page
Amit Gupta8y ago
@Ankita

Please be specific to what you are asking, don't rush to post you partial code.

No, your parameter is not valid, in qyery you need @id and you are passing @customerid, you should pass the same parameters that you had declared in your query.

Do correct above, and still exception occurs then post your exception
Ankita Singh8y ago
everything is fine but error on cmd.executenonquery... all parametere got right value but i have no idea where is create problem
Ankita Singh8y ago
also i was try this but got same error... and there is pass the paarameter of id..i take hidden field of id...
SqlCommand cmd = new SqlCommand();
cmd.CommandText = "update City_tbl set State=@State,City=@City where id=@id";
cmd.Parameters.AddWithValue("@State", ddlstate.SelectedValue);
cmd.Parameters.AddWithValue("@City", TextBox1.Text);
cmd.Parameters.AddWithValue("@CustomerID", hidCustomerID.Value);
cmd.Connection = con;
con.Open();
cmd.ExecuteNonQuery();

con.Close();
FillGrid();
ClearControls();
lblMessage.Text = "Updated Successfully.";
Amit Gupta8y ago
You also missed to pass the parameter of @id. Do check all fields and rest of your code is good.
Ankita Singh8y ago
all button are work properly exception of update...
Ankita Singh8y ago
public partial class city : System.Web.UI.Page
{
// string id=Request.QueryString["id"].ToString();
SqlConnection con = new SqlConnection(System.Configuration.ConfigurationManager.ConnectionStrings["dbconnectionstr"].ToString());
protected void Page_Load(object sender, EventArgs e)

its my connection string... problem is in cmd.ExecuteNonQuery
Amit Gupta8y ago
Where is the connection string? You just initialize the connection but haven't passed connection string