What are the errors of the code in C++?

Please solve the errors.

The code:

#include "stdafx.h"
# include
# include
# include
# include
using namespace std;
int top=-1;

char Stack[25][100]={NULL};

void push(const char *);
const char* pop( );

void postfix_to_infix(constchar *);

int main( )
{
clrscr( );

char Postfix_expression[100]={NULL};

cout<<"\n\n\t Enter the Postfix Expression : ";
cin.getline(Postfix_expression,80);

postfix_to_infix(Postfix_expression);

getch( );
return 0;
}

/*************************************************************************///----------------------------- push(const char) ----------------------///*************************************************************************/void push(constchar *Symbol)
{
if(top==24)
cout<<"Error : Stack is full."<
else
{
top++;
strcpy(Stack[top],Symbol);
}
}

/*************************************************************************///-------------------------------- pop( ) -----------------------------///*************************************************************************/constchar* pop( )
{
char Symbol[100]={NULL};

if(top==-1)
cout<<"Error : Stack is empty."<
else
{
strcpy(Symbol,Stack[top]);
strset(Stack[top],NULL);
top--;
}

return Symbol;
}

/*************************************************************************///--------------------- postfix_to_infix(const char *) ----------------///*************************************************************************/void postfix_to_infix(constchar *Postfix)
{
char Infix_expression[100]={NULL};
char Postfix_expression[100]={NULL};

strcpy(Postfix_expression,Postfix);
strcat(Postfix_expression,"=");

int count=0;

char Symbol_scanned[5]={NULL};

do
{
Symbol_scanned[0]=Postfix_expression[count];

if(Symbol_scanned[0]=='/' || Symbol_scanned[0]=='*' ||
Symbol_scanned[0]=='-' || Symbol_scanned[0]=='+' ||
Symbol_scanned[0]=='^' )
{
char Value_1[100]={NULL};
char Value_2[100]={NULL};
char Result[100]={NULL};

strcpy(Value_1,pop( ));
strcpy(Value_2,pop( ));

if(Infix_expression[(count+1)]!='=')
strcpy(Result,"(");

strcat(Result,Value_2);
strcat(Result,Symbol_scanned);
strcat(Result,Value_1);

if(Infix_expression[(count+1)]!='=')
strcat(Result,")");

push(Result);
}

else
push(Symbol_scanned);

count++;
}
while(Postfix_expression[count]!='=');

strset(Infix_expression,NULL);
strcpy(Infix_expression,pop( ));

cout<<"\n\n\t Infix Expression is : "< }

5 Replies

Know the answer? Post it — somebody with the same question will find it here.

Joe Wilson12y ago
So what is your solution about my question ?
Joe Wilson12y ago
you are right .
( c * (a + b) ) + c / d
Wim Sturkenboom12y ago
Are you sure ( ( c * ( a + b ) + ( c / d ) ) and ( c * a + b ) + c / d will return the same result?

I have always been told (learned at primary school or so) that multiplying goes before addition. If I'm right and the above is the output of your code, your code is wrong

No idea how to fix it though.
Joe Wilson12y ago
I understand that the code was right but i want to decrease the amount of parenthesis by paying attention to the mathematical operator priorities .

For Example:
The post fix expression : c a b - * c d / +

The infix expression with full parenthesis: ( ( ( c * ( a + b ) + ( c / d ) )

The Infix expression with less parenthesis ( by paying attention to the mathematical operator priorities ) :

( c * ( a + b ) ) + c / d
Sam Hobbs12y ago
What errors? I see no errors.