Cast is redundant. How to use the is statement?

Why is it saying "Cast is redundant"? If I remove the cast it instead says How can I target and use the is statement "toy is Featuer feather" otherwise?

Working example: Only says "Cast is redundant" by doesn't through any errors.

if (input == 1 && (object)toy is Feather feather)
{
Console.WriteLine("ba");
typeOfToy = feather;
}

Working example: Foreach lets me target the "toy is Feather feather" without any errors. But putting every is statement in a foreach seems overkill?

foreach (var toy in this.toy)
{
if (input == 1 && toy is Feather feather)
{
Console.WriteLine("ba");
typeOfToy = feather;
}
}

Not working example: Casting (object) has been removed and through: "An expression of type List cannot be handled by a pattern of type 'Feather'. Why is that and what's the best practise using my two examples above? Any other ways to solve this?

if (input == 1 && toy is Feather feather)
{
Console.WriteLine("ba");
typeOfToy = feather;
}

3 Replies

Know the answer? Post it — somebody with the same question will find it here.

Chris Anderson5y ago
Thanks for your suggestions! I'll try them out!
Rajanikant Hawaldar5y ago
Try if it works
foreach (var toy in this.toy.OfType(Feather)) // this will returns only Feather toy
So no need to check at if condition
Sachin Singh5y ago
use GetType() instead
if (input == 1 && toy.GetType()==TypeOf(feather))
{
    Console.WriteLine("ba");
    typeOfToy = feather;
}
OR//
    if (input == 1 && Object.ReferenceEquals(toy.GetType(), feather.GetType())

    )
    {
        Console.WriteLine("ba");
        typeOfToy = feather;
    }