File parse in c#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.IO;
namespace readfrom_textfile {
class Program {
static void Main(string[] args) {
var fileStream = new FileStream(@"D:\Practise\test.txt", FileMode.Open, FileAccess.Read);
using(var streamReader = new StreamReader(fileStream, Encoding.UTF8)) {
string line;
while ((line = streamReader.ReadLine()) != null) {
string[] data = line.Split(new char[] {
'('
}, StringSplitOptions.RemoveEmptyEntries);
string bikeName = data[0].Trim().Split(' ').Last();
bikeNamebikeName = bikeName.Remove(bikeName.Length - 1);
string[] usageData = data[1].Split(new char[] {
';'
}, StringSplitOptions.RemoveEmptyEntries);
string issuedBike = usageData[0].Trim().Split(' ')[2];
string inUseBike = usageData[1].Trim().Split(' ')[2];
Console.WriteLine("Name:" + bikeName);
Console.WriteLine("Total:" + issuedBike);
Console.WriteLine("InUse:" + inUseBike);
Console.WriteLine();
}
}
Console.ReadLine();
}

Your coding is not very well structured.You have a line that is not being printed, but you are processing it. At the moment you are repeating code for each item, which leads to errors.

You may want to change these lines to be done in loops. That way, all the items in the array will be actioned. Try to make your code something similar to this structure. (This is pseudocode, so you will have to use the correct C# syntax for your code.)

Main print report code

{

Print header()

Print Usage()

Print footer()

}

Print header()

{

(format header how you want it)

}

Print Usage()
{

For each item in array

// (format the data how you want it printed)

         // then Print data to console
      Next
   }

Print footer()
   {
      Console.WriteLine("Name:" + bikeName);
      Console.WriteLine("Total:" + issuedBike);
      Console.WriteLine("InUse:" + inUseBike);
      Console.WriteLine();

}

Obviously, you will have to design the header and footer how you want them.

The advantage of using functions and loops is to save coding the same line many times. it also makes it easier to change a coded section without having to go through all the code.

That's okay. I can imagine. You are not alone. Unfortunately, our culture is such that we have never been taught how express properly and clearly.

I don't know how to explain you to understand my problem.Anyhow thanks for your help@

Nitin Sontakke

Dinesh, I am not seeing what is updated. Still 2 in input and 1 in output!

Because this issue is faced by you, you know everything about it. The things which are quite obvious to you will not be very obvious to us. So you will need to point us out very preciously where the problem is.

Please try to imagine our situation. You will need to tell us each and every minor thing and also help us understand the issue immediately so that we focus on resolving the issue and not understanding the issue, which i assume already aware of.

Sorry .I updated my question.

Again, when in input it is "Total of 2 bike" why does your output shows 1? Are you saying that you are having trouble identifying "members"?

If yes, you cannot treat each line same. First you will need to identify which line is this and treat it separately. Identify that "Bike details" have started and they are over, etc.

Name: Yamaha;
Total: 2;
Inuse: 2;

You cannot say...something...something...please post full lines. Also, when you say you cannot achieve 100%, what is the problematic area? Where are the associated lines? Which pattern is not being caught?

Without that it would be difficult to look into.

8 Replies

Know the answer? Post it — somebody with the same question will find it here.

David Wood9y ago
Your coding is not very well structured.You have a line that is not being printed, but you are processing it. At the moment you are repeating code for each item, which leads to errors.

You may want to change these lines to be done in loops. That way, all the items in the array will be actioned. Try to make your code something similar to this structure. (This is pseudocode, so you will have to use the correct C# syntax for your code.)

Main print report code
   {
      Print header()
      Print Usage()
      Print footer()
   }

Print header()
{
   (format header how you want it)
}

Print Usage()
   {
      For each item in array
         // (format the data how you want it printed)
         // then Print data to console
      Next
   }

Print footer()
   {
      Console.WriteLine("Name:" + bikeName);
      Console.WriteLine("Total:" + issuedBike);
      Console.WriteLine("InUse:" + inUseBike);
      Console.WriteLine();
   }

Obviously, you will have to design the header and footer how you want them.

The advantage of using functions and loops is to save coding the same line many times. it also makes it easier to change a coded section without having to go through all the code.
Nitin Sontakke9y ago
That's okay. I can imagine. You are not alone. Unfortunately, our culture is such that we have never been taught how express properly and clearly.
Dinesh Santhalingam9y ago
I don't know how to explain you to understand my problem.Anyhow thanks for your help@
Nitin Sontakke
Nitin Sontakke9y ago
Dinesh, I am not seeing what is updated. Still 2 in input and 1 in output!

Because this issue is faced by you, you know everything about it. The things which are quite obvious to you will not be very obvious to us. So you will need to point us out very preciously where the problem is.

Please try to imagine our situation. You will need to tell us each and every minor thing and also help us understand the issue immediately so that we focus on resolving the issue and not understanding the issue, which i assume already aware of.
Dinesh Santhalingam9y ago
Sorry .I updated my question.
Nitin Sontakke9y ago
Again, when in input it is "Total of 2 bike" why does your output shows 1? Are you saying that you are having trouble identifying "members"?

If yes, you cannot treat each line same. First you will need to identify which line is this and treat it separately. Identify that "Bike details" have started and they are over, etc.
Dinesh Santhalingam9y ago
1. Name: Yamaha;
2. Total: 2;
3. Inuse: 2;
I got this solution from my above code.But i want my o/p like below.
my text file contains:
Users of Yamaha: (Total of 2 bike issued; Total of 2 bike in use).
line....................something
line..................something
Bike details .........................
1125 Monica YamahaR15(v3.0)(petrol / 7788 4903), start Wed 1 / 18 8: 53
1128 Dhini Yamaha Fz(v2.0)(petrol / 7748 4903), start Wed 1 / 18 9: 53
o/p
1. Name: Yamaha;
2. Total: 2;
3. Inuse: 2;
4. members: Monica[Wed 1 / 18 8: 53] ,dhini [Wed 1 / 18 9: 53]