following is my api , is enumerable i s better than list etc

rajesh yadav

following is what i get from database. in tuples/record.

{ "nodeHierarchy": [{ "L1": "Mechanical" }, { "L2": "nical" }, { "L3": "nical2" }], "weightage": "34", "dateFrom": "01 jan 2020", "dateTo": "04 Feb 2020", "WSID": "Rky6", "scope": "4234", "IsLeafNode": true, "Parentnode": [{ "L1": "Mechanical" }, { "L2": "nical" }] }
{ "nodeHierarchy": [{ "L1": "Mechanical" }, { "L2": "nical" }], "weightage": "34", "dateFrom": "01 jan 2020", "dateTo": "04 Feb 2020", "WSID": "Rky6", "scope": "4234", "IsLeafNode": true, "Parentnode": [{ "L1": "Mechanical" }] }
{ "nodeHierarchy": [{ "L1": "Mechanical" ], "weightage": "34", "dateFrom": "01 jan 2020", "dateTo": "04 Feb 2020", "WSID": "Rky6", "scope": "4234", "IsLeafNode": true, "Parentnode": [] }

[HttpGet]
public IEnumerable GetSCurvePlan(string WSId, string dtFrom, string dtTo, string ReportType)
{
//I get json from databse given above then transfrom it in following list.
List lstSCurveObj = new List();
IEnumerable IenumObject = lstSCurveObj.GroupBy(val => val.ProgressDate.AddDays(((CultureInfo.CurrentCulture.DateTimeFormat.FirstDayOfWeek) - val.ProgressDate.DayOfWeek) + 6))
.Select(grouped => new
{
ProgressDate = grouped.Key,
PlannedProgressPercentageWithWeightage = grouped.Sum(Pp => Pp.PlannedProgressPercentageWithWeightage),
ActualProgressPercentage = grouped.Sum(Ap => Ap.ActualProgressPercentage),
grouped.OrderByDescending(Pc => Pc.ProgressDate).First().PlannedPrgressPercentageWithWeightageCumulative,
grouped.OrderByDescending(Ac => Ac.ProgressDate).First().ActualProgressPercentageCumulative
}).OrderBy(o=> o.ProgressDate).ToList();
return IenumObject;
}

Q1) I have to return the data of the class in json format, so u can change anything if u want. my objective is that it should be optimised?

q2) is tolist() function is required, because, without it, it works? for optimisation.

as there is no where clause and it is used only once.

Q3) initially I was returning List but it was showing IEnumerable anonymous type cant be cast to List

so i converted it to ienumerbal how far it is good or there is other better ways?

Q4) as i have used orderby and tolist , then i have returened , will it keep the order or i have to write like following

return IenumObject.OrderBy(o => o.ProgressDate)

yours sincerely

3 Replies

Know the answer? Post it — somebody with the same question will find it here.

Laxmidhar Sahoo6y ago
1-List lstSCurveObj = new List(); // here there are no data .So how you group it

if use ToList() then insted of IEnumerable IenumObject use var IenumObject
rajesh yadav6y ago
thank u, that answers me,

as I said my objective is to make an API to send the data in S-curve class formate.
in that case, i should use IEnumerator.

pls also ans 4) question
Laxmidhar Sahoo6y ago
One important difference between IEnumerable and List (besides one being an interface and the other being a concrete class) is that IEnumerable is read-only and List is not.
So if you need the ability to make permanent changes of any kind to your collection (add & remove), you'll need List. If you just need to read, sort and/or filter your collection, IEnumerable is sufficient for that purpose.