I have two arrays in c#

Mark Tabor

I have two arrays in c# bascially i am creating a function to check either my string contains at least one lowercase one uper case and one digit so i take a string and then convert it to lowercase and uppercase and then covert them to array and then comparing to check if atleast one item like one upercase one lowercase one digit exists then success message shown

The problem is here

if i input as a main string as "acg123"

and my uppercase string would contain "ACG123" now for the first three characters it works fine like a and A are different and C and c are differnet but when it comes to number it makes the condition true as in both of them we have 123, so how can i compare just characters from the string array instead of any number

7 Replies

Know the answer? Post it — somebody with the same question will find it here.

Tapan Patel9y ago
Accepted answer
If you don't want to use the regex, you can still do by following way (without creating number of strings and char array in your code).
string UserInput = "abc44AA";
char[] CharArray = UserInput.ToCharArray();
// 65 - 'A', 90 - 'Z'
// 97 - 'a', 122 - 'z'
// 48 - '0', 57 - '9'
if(
   CharArray.Any(ch=>ch>=65 && ch<=90)) &&
   CharArray.Any(ch => (ch >= 97 && ch <= 122)) &&
CharArray.Any(ch => (ch >= 48 && ch <= 57))
)
Debug.WriteLine("OK");
else
Debug.WriteLine("Not Ok");
+1
Tapan Patel9y ago
Defined the string/user input.

string UserInput = "abc44AA";

Convert the string to character array (which can also be represented by ascii values)

char[] CharArray = UserInput.ToCharArray();

Below is the ascii value range for capital A-Z, lower a-z and 0-9.
// 65 - 'A', 90 - 'Z'
// 97 - 'a', 122 - 'z'
// 48 - '0', 57 - '9'

Here, I am checking if the CharArray (character array) contains any character that falls between the above mentioned ascii value range or not. If all three conditions are true - meaning - it contains at least one upper case, one lower case character and a digit, print 'ok' else 'not ok'.

if(
CharArray.Any(ch=>ch>=65 && ch<=90)) &&
CharArray.Any(ch => (ch >= 97 && ch <= 122)) &&
CharArray.Any(ch => (ch >= 48 && ch <= 57))
)
Debug.WriteLine("OK");
else
Debug.WriteLine("Not Ok");

Please mark it as answer if it addresses the issue.
0
Mark Tabor9y ago
dear Tapan Patel thank for response

what is this
string UserInput = "abc44AA";
char[] CharArray = UserInput.ToCharArray();
// 65 - 'A', 90 - 'Z'
// 97 - 'a', 122 - 'z'
// 48 - '0', 57 - '9'
if(
CharArray.Any(ch=>ch>=65 && ch<=90)) &&
CharArray.Any(ch => (ch >= 97 && ch <= 122)) &&
CharArray.Any(ch => (ch >= 48 && ch <= 57))
It works fine but can you explain what you wrote do you convert the string to ASCII and then checking?
0
Mark Tabor9y ago
if you have a test and you do not know the regex whole expression
0
Mark Tabor9y ago
I want to do it using string manipulation instead of using REGEX i did it by that way

string LowerUserInput = UserInput.ToLower();
string UperCaseInput = UserInput.ToUpper();
char[] num = UserInput.ToCharArray();

bool isnumber = UserInput.Any(c => char.IsDigit(c));
bool FirstCheck=false, secondCheck=false, thirdCheck=false;

// int number = Convert.ToInt32(UserInput);
for (int i = 0; i < UserInput.Length; i++)
{
//UserInput.Contains(LowerUserInput) && UserInput.Contains(UperCaseInput) && isnumber
if (UserInput.Length >= 6 )
{
var output0 = Regex.Replace(UserInput, @"[\d-]", string.Empty);
char[] arr1 = UserInput.ToCharArray();
char[] aaaarr=output0.ToCharArray();
char[] arr2 = LowerUserInput.ToCharArray();
var output = Regex.Replace(LowerUserInput, @"[\d-]", string.Empty);

char[] arrs=output.ToCharArray();
char[] arr3=UperCaseInput.ToCharArray();
var output2 = Regex.Replace(UperCaseInput, @"[\d-]", string.Empty);
char[] arrss=output2.ToCharArray();
for (int ko = 0; ko < aaaarr.Length; ko++)
{
if (aaaarr[ko] == arrs[ko])
{
FirstCheck = true;
break;
// Console.WriteLine("First Good ");
}
}
for (int ll = 0; ll < aaaarr.Length; ll++)
{
if (arrss[ll] == aaaarr[ll])
{
secondCheck = true;
break;
// Console.WriteLine("Second Criteria also fine ");
}
}
if (isnumber)
{
thirdCheck = true;
break;
//Console.WriteLine("Third is also good and first already");
}

}
// else
//{
// Console.WriteLine("Your password is incorrect!");
// break;
//}
}
if (FirstCheck == true && secondCheck == true && thirdCheck == true )
{
Console.WriteLine("You are ok");
}
else
{
Console.WriteLine("Not OK");
}
}
0
Tapan Patel9y ago
If you really want to check whether string contains lowercase, upper case and a digit, then you need positive lookahead in regex (http://www.blackwasp.co.uk/RegexLookahead.aspx)

Try below code and it would work.
Regex reg = new Regex("(?=.*?[a-z])(?=.*?[A-Z])(?=.*?[0-9])");
//string testdata = "abc234abcA";
string testdata = "AabcACACAC5";
bool isMatch = reg.IsMatch(testdata);
Please mark it as an answer if it addresses the issue.
0
Rahul Kaushik9y ago
Hi mark,

That is good question to ask. So to do it. When you traverse the array for comapring first check whether
array[i] is number or not and if yes skip that comparison.
so for comparing it use this code

bool valid= Regex.IsMatch(array[i], @"^\d{9}$");

then check valid==true;

(If you find this as a solution do accept it. As for future purpose)
0