In controller Discount and Vat Value are not consistent

Emmmanuel FIADUFE

public ActionResult GetAllPrintSalesRecord()
{
decimal total = 0;
decimal tax = 0;
decimal discount = 0;
if (modifiedData != null)
{
total = Convert.ToDecimal(TotalAmount);
discount = Sum(a=>a.DiscountPercent);
tax = Sum(discount * VatPercent) / 100);
}
return Json(new { modifiedData = modifiedData, total = total, discount = discount, tax = tax }, JsonRequestBehavior.AllowGet);
}

3 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vishal Joshi2y ago

Accepted answer

Hello Emmmanuel,

You need to check if data is in list format or in single object. if it's in list format you need to sum all and then need to calculate discount on it.

Try the below code

public ActionResult GetAllPrintSalesRecord(decimal DiscountPercent, decimal VatPercent)
{
     decimal total = 0;
     decimal tax = 0;
     decimal discount = 0;
     if (modifiedData != null)
      {                
          total = modifiedData.Sum(A => A.YourAmountColumn);                
          discount = ((total * DiscountPercent)/100);
          tax = (((total - discount) * VatPercent) / 100);
      }
      return Json(new { modifiedData = modifiedData, total = total, discount = discount, tax = tax }, JsonRequestBehavior.AllowGet);
}

Please change variable names accordingly.

Thanks

Vishal

Emmmanuel FIADUFE2y ago
Thank you team, it is working perfectly
Abhishek Yadav2y ago
It seems that there is an inconsistency in the application of discount and VAT values in the controller code.

In the code snippet provided, the variables `discount` and `tax` are being calculated based on the `Sum` method, which is not clear from the code snippet what it is summing. Additionally, there is a syntax error in calculating the `tax` variable, as there is an extra closing parenthesis after dividing by 100.

To ensure consistency, it is important to check how the `discount` and `VatPercent` values are being calculated or retrieved before performing any calculations. It is also advisable to review the logic of the code to ensure accuracy in the calculation of the `discount` and `tax` variables.

Can you provide more details or context on how the `discount` and `VatPercent` values are being determined in your application?