Is theApplication.OpenForms to much overhead for the program?

Gustavo

Hello:

I have this code. Is theApplication.OpenForms to much overhead for the program?

((FormICEPack)Application.OpenForms["FormICEPack"]).textBoxLoginUser_ID.Text = textBoxUser_ID.Text;
((FormICEPack)Application.OpenForms["FormICEPack"]).textBoxLoginPassword.Text = textBoxPassword.Text;
((FormICEPack)Application.OpenForms["FormICEPack"]).textBoxLoginProfile_ID.Text = textBoxProfileLogin_ID.Text;
((FormICEPack)Application.OpenForms["FormICEPack"]).textBoxLoginProfileServer.Text = textBoxProfileServer.Text;
((FormICEPack)Application.OpenForms["FormICEPack"]).textBoxLoginProfileServerType.Text = textBoxProfileServerType.Text;
((FormICEPack)Application.OpenForms["FormICEPack"]).textBoxLoginProfileLogin_ID.Text = textBoxProfileLogin_ID.Text;
((FormICEPack)Application.OpenForms["FormICEPack"]).textBoxLoginProfilePassword.Text = textBoxProfilePassword.Text;
((FormICEPack)Application.OpenForms["FormICEPack"]).textBoxLoginProfileDatabase.Text = textBoxProfileDatabase.Text;

5 Replies

Know the answer? Post it — somebody with the same question will find it here.

Nainil16y ago
Accepted answer
Hi Giorgio,
The more forms you open within a single application, the more memory your application is going to use. However from the above code it looks like you only have 1 instance of FormICEPack form opened and accessing that Form instance using the code above should not be too much overhead. Hope this helps.
theLizard16y ago
Hi Georgio,

This is why I said that forms management is important in MDI applications so hope that you revisit the zip I uploaded for one of your questions.
theLizard16y ago
Hi Georgio,

This is why I said that forms management is important in MDI applications so hope that you revisit the zip I uploaded for one of your questions.
Gustavo16y ago
Sam:

Thanks that is what I was looking for, the whole time:
This way I can define the form at load time and then use it any time I want.... Thanks.

Sam Hobbs16y ago

You should look at the documentation of Application.OpenForms. As Nainil indicates, it provides a list of forms that are open, it does not open forms. That code is not innefficient, but it can be more efficient.

FormICEPack f = Application.OpenForms["FormICEPack"]) as FormICEPack;

if (f == null)

{

// error

return;

}

f.textBoxLoginUser_ID.Text = textBoxUser_ID.Text; 

f.textBoxLoginPassword.Text = textBoxPassword.Text; 

f.textBoxLoginProfile_ID.Text = textBoxProfileLogin_ID.Text; 

f.textBoxLoginProfileServer.Text = textBoxProfileServer.Text; 

f.textBoxLoginProfileServerType.Text = textBoxProfileServerType.Text; 

f.textBoxLoginProfileLogin_ID.Text = textBoxProfileLogin_ID.Text; 

f.textBoxLoginProfilePassword.Text = textBoxProfilePassword.Text; 

f.textBoxLoginProfileDatabase.Text = textBoxProfileDatabase.Text;