Merge multiple text files into one text file

sorry again for disturbance but as per your code now this error is coming when i run the program Error1

The best overloaded method match for 'System.IO.File.OpenRead(string)' has some invalid argumentsC:\Hyperspectral_Tool\Hyperspectral_Tool\merge.cs7337Hyperspectral_Tool


Error2Argument '1': cannot convert from 'object' to 'string'C:\Hyperspectral_Tool\Hyperspectral_Tool\merge.cs7351Hyperspectral_Tool

Hi Meenakshi,

This error is obevious as you are trying to iterate over listbox. just change it to [listbox].items.

public void saveFileDialog1_FileOk( object sender, System.ComponentModel.CancelEventArgs e)
{

 const int chunkSize = 16 * 1024*1024;
string temp = null;
using (var output = File.Create(saveFileDialog1.FileName)){
    foreach (var file in lstfile.Items)
        {
        using (var input = File.OpenRead(file))
                {
                    var buffer = new byte[chunkSize];
                    int bytesRead;
                    while ((bytesRead = input.Read(buffer, 0, buffer.Length)) > 0)
                    {
                        output.Write(buffer, 0, bytesRead);
                    }
                }
       
    }

}
string prompt = null;
prompt = string.Concat(lbl2.Text, " files merged succesfully");
 Interaction.MsgBox(prompt, MsgBoxStyle.Information, "Merge");
 lstfile.Items.Clear(); lbl1.Text = "0";

}

Hope, this will help you out. Please feel free to connect in case of any query.

Please don't forget to mark as answer if this post helps you.

thanks for the reply but this code gives one error that is : Error1


"foreach statement cannot operate on variables of type 'System.Windows.Forms.ListBox' because 'System.Windows.Forms.ListBox' does not contain a public definition for 'GetEnumerator"

public void saveFileDialog1_FileOk( object sender, System.ComponentModel.CancelEventArgs e)
{

 const int chunkSize = 16 * 1024*1024;
string temp = null;
using (var output = File.Create(saveFileDialog1.FileName)){
    foreach (var file in lstfile)
        {
        using (var input = File.OpenRead(file))
                {
                    var buffer = new byte[chunkSize];
                    int bytesRead;
                    while ((bytesRead = input.Read(buffer, 0, buffer.Length)) > 0)
                    {
                        output.Write(buffer, 0, bytesRead);
                    }
                }
       
    }

}
string prompt = null;
prompt = string.Concat(lbl2.Text, " files merged succesfully");
 Interaction.MsgBox(prompt, MsgBoxStyle.Information, "Merge");
 lstfile.Items.Clear(); lbl1.Text = "0";

}

Hi Meenakshi,

I have updated your code make it working. Actually you have to use different StreamReader everytime or need to close or dispose after every iteration of your loop.

I have updated your code in better manner. Please consider it to update for any compilation error as i have not tested it on Visual studio.




public void saveFileDialog1_FileOk( object sender, System.ComponentModel.CancelEventArgs e)
{


string temp = null;
using (var output = File.Create(saveFileDialog1.FileName)){
    foreach (var file in lstfile)
        {
        using (var input = File.OpenRead(file))
                {
                    var buffer = new byte[chunkSize];
                    int bytesRead;
                    while ((bytesRead = input.Read(buffer, 0, buffer.Length)) > 0)
                    {
                        output.Write(buffer, 0, bytesRead);
                    }
                }
       
    }

}
string prompt = null;
prompt = string.Concat(lbl2.Text, " files merged succesfully");
 Interaction.MsgBox(prompt, MsgBoxStyle.Information, "Merge");
 lstfile.Items.Clear(); lbl1.Text = "0";

}

Hope, this will help you out. Feel free to connect in case of any query.

Please don't forget to mark as answer if this post helps you.

sir ,
i'm using one button control on its click event opendialog will open where i set multiselect property =true,
all those text files path get add to list box.and then used again one button to merge those text files to one text file and save them using savedialog box.but when i want to save i got one error
 
public void saveFileDialog1_FileOk( object sender, System.ComponentModel.CancelEventArgs e)
{
StreamReader Reader = default(StreamReader);
 int i = 0;
string temp = null;
for (i = 0; i <= lstfile.Items.Count - 1; i++)
{
Reader = File.ReadAllText(temp);
 
Reader = File.OpenText(lstfile.Items.Add(i));

temp = Reader.ReadToEnd();

File.AppendAllText(saveFileDialog1.FileName, temp);
 }
string prompt = null;
prompt = string.Concat(lbl2.Text, " files merged succesfully");
 Interaction.MsgBox(prompt, MsgBoxStyle.Information, "Merge");
 lstfile.Items.Clear(); lbl1.Text = "0";
}

the problem is there in these coloured line ...pls help me to solve my problem.

Hello Meenakshi,

Can you please paste your code here which makes very easy to understand the problem ?

The simplest solution i am having in my mind is to convert above code to function which takes file names as parameter.


public void MergeFiles(string[] inputFiles,string mergeFileName)
{
        const int chunkSize = 2 * 1024; // 2KB

        using (var output = File.Create(mergeFileName))
        {
            foreach (var file in inputFiles)
            {
                using (var input = File.OpenRead(file))
                {
                    var buffer = new byte[chunkSize];
                    int bytesRead;
                    while ((bytesRead = input.Read(buffer, 0, buffer.Length)) > 0)
                    {
                        output.Write(buffer, 0, bytesRead);
                    }
                }
            }
}
}

Call above this method where you select the list of files.

var inputFiles = new[] { "file1.txt", "file2.txt", "file3.txt" };

MergeFiles(inputFiles,"OutPut.txt");

Hope, this will help you out. Feel free to connect in case of any query.

Please don't forget to mark as answer if this post helps you.

Hi, 

You can try this code as well. There is class containing 2 methods for reading and writing the output.
using System.Collections.Specialized;
using System.IO;
.................
.................

class ReadMergeTextFiles
    {
        string path = @"C:\Dhirendra\Learning\Corner\SampleFiles\";
       


        public void MergeFiles(string targetFile)
        {
            StringCollection mergedValuesCollection = new StringCollection();
            //Get files from openFileDialog
            string[] arrFiles = { "S100141.asd.txt", "S100144.asd.txt" }; //Lets take file names
            foreach (string fname in arrFiles)
            {
                mergedValuesCollection = ReadFile(fname, mergedValuesCollection);
            }


            //Write to file
            using (StreamWriter file = new StreamWriter(path + targetFile))
            {
                foreach (string line in mergedValuesCollection)
                {
                        file.WriteLine(line);
                }
            }
        }




        public StringCollection ReadFile(string fileName, StringCollection mergedValues)
        {
            int i = 0;
            string filePath = path + fileName;


            try
            {
                using (StreamReader sr = new StreamReader(filePath))
                {
                    String line = string.Empty;
                    while ((line = sr.ReadLine()) != null) //Assuming there is white space seperator for each line.
                    {
                        line = line.Substring(line.IndexOf(' '), line.Length - line.IndexOf(' ')).Trim();
                        if (i != 0)
                        {
                            double val = Double.Parse(line);
                            line = string.Format("{0, 8:F6}", val);
                        }
                        else
                            line = string.Format("{0, 11}", line);
                        if (mergedValues.Count > i && mergedValues[i] != null)
                            mergedValues[i] += "\t" + line;
                        else
                            mergedValues.Add(line);
                        i++;
                    }
                }
            }
            catch (Exception e)
            {
                Console.WriteLine("The file could not be read:");
                Console.WriteLine(e.Message);
            }


            return mergedValues;
        }
    }

//Calling from main method.
static void Main(string[] args)
        {
            ReadMergeTextFiles objReadMergeTextFiles = new ReadMergeTextFiles();
            objReadMergeTextFiles.MergeFiles("mergedOutput.txt");
        }

The output will be stored in the passed file name in the location which you specify in "path" global variable.

mergedOutput.txt
S100141.asd        S100144.asd
0.015082             0.013506
0.011691             0.010981
0.010658             0.012235
0.013030             0.016356
0.014744             0.015739



Thanks

You can Use StreamReader to Read Those two Files and
by Creating a New File and write those using StreamWriter.