Plzz Solve In this code error

Sourabh Dhiman

SqlCommand cmd = new SqlCommand("insert into tblProduct(ProductID,Name,UnitPrice,QtyAvl)Values(@ProductID,@Name,@UnitPrice,@QtyAvl)", con);

cmd.Connection = con;

cmd.Parameters.Add("@ProductID", SqlDbType.Int).Value = TextBox1.Text;

cmd.Parameters.Add("@Name", SqlDbType.VarChar, 50).Value = TextBox2.Text;

cmd.Parameters.Add("@UnitPrice", SqlDbType.NVarChar, 50).Value = TextBox3.Text;

cmd.Parameters.Add("@QtyAvl", SqlDbType.NVarChar, 50).Value = TextBox4.Text;

cmd.ExecuteNonQuery();

SqlDataAdapter ds = new SqlDataAdapter();

DataTable dt = new DataTable();

ds.Fill(dt);

GridView2.DataSource = dt;

GridView2.DataBind();

cmd.Dispose();

con.Close();

what's error in code

6 Replies

Know the answer? Post it — somebody with the same question will find it here.

Code Alone8y ago
Hi Sourabh,

There may be many issues with this code. Some of them are as below :
1. before cmd.ExecuteNonQuery(); make sure ConnectionState is not closed
to avoid this error use below :
if (con.State == ConnectionState.Closed)
con.Open();

2. Kindly use a data retrieve command to get the desired data for GridView.
cmd.CommandText="ProductID,Name,UnitPrice,QtyAvl FROM tblProduct"

Try this final Code :
SqlCommand cmd = new SqlCommand("insert into tblProduct(ProductID,Name,UnitPrice,QtyAvl)Values(@ProductID,@Name,@UnitPrice,@QtyAvl)", con);
cmd.Connection = con;
cmd.Parameters.Add("@ProductID", SqlDbType.Int).Value = TextBox1.Text;
cmd.Parameters.Add("@Name", SqlDbType.VarChar, 50).Value = TextBox2.Text;
cmd.Parameters.Add("@UnitPrice", SqlDbType.NVarChar, 50).Value = TextBox3.Text;
cmd.Parameters.Add("@QtyAvl", SqlDbType.NVarChar, 50).Value = TextBox4.Text;
if (con.State == ConnectionState.Closed)
con.Open();
cmd.ExecuteNonQuery();
cmd.CommandText = "ProductID,Name,UnitPrice,QtyAvl FROM tblProduct";
DataTable dt = new DataTable();
SqlDataReader dr = cmd.ExecuteReader();
dt.Load(dr);
GridView2.DataSource = dt;
GridView2.DataBind();

Note : make sure you no error will be throw from database like Primary Key Unique key. If you need full solution then put aspx, .aspx.cs and sql files together. So that viewer can answer easily.
Jenith Thakkar8y ago
If you want to bind datatable on grid then no need to require cmd.ExecuteNonQuery so remove that line and try it again
Vincent Maverick Durano8y ago
Is this an assignment? What's the error you are getting?
Pravat Kumar8y ago
For binding data into gridview, please use below code.

DataTable dt = new DataTable();
using (SqlConnection sqlConnection = new SqlConnection(strConnectionString))
{
using (SqlCommand sqlCommand = new SqlCommand("select * from tblProduct"))
{
sqlCommand.Connection = sqlConnection;
sqlCommand.CommandType = CommandType.Text;
SqlDataAdapter sqlDataAdapter = new SqlDataAdapter(sqlCommand);
sqlConnection.Open();
sqlDataAdapter.Fill(dt);
}
}
if (dt.Rows.Count > 0)
{
GridView2.DataSource = dt;
GridView2.DataBind();
}
Pravat Kumar8y ago
Hello Sourabh,

please try below code for inserting data into a table.

using (SqlConnection sqlConnection = new SqlConnection(strConnectionString))

{

using (SqlCommand sqlCommand = new SqlCommand("insert into tblProduct(ProductID,Name,UnitPrice,QtyAvl)Values(@ProductID,@Name,@UnitPrice,@QtyAvl)"))

{

sqlCommand.Connection = sqlConnection;

sqlCommand.CommandType = CommandType.Text;

sqlCommand.Parameters.Add("@ProductID", SqlDbType.Int);

sqlCommand.Parameters["@ProductID"].Value = Convert.ToInt32(TextBox1.Text.Trim());

sqlCommand.Parameters.Add("@Name", SqlDbType.VarChar, 50);

sqlCommand.Parameters["@Name"].Value = TextBox2.Text.Trim();

sqlCommand.Parameters.Add("@UnitPrice", SqlDbType.VarChar, 50);

sqlCommand.Parameters["@UnitPrice"].Value = TextBox3.Text.Trim();

sqlCommand.Parameters.Add("@QtyAvl", SqlDbType.VarChar, 50);

sqlCommand.Parameters["@QtyAvl"].Value = TextBox4.Text.Trim();

sqlConnection.Open();

sqlCommand.ExecuteNonQuery();

}

}
Sanwar Ranwa8y ago
Hello

What error exactly you getting share that error