Save Data into Multiple table

From the provided code, there seem to be a few issues that might be causing the data not to be saved properly. Here are some potential points of improvement:

1. Category Creation Logic: In the SaveItem action method, the category creation logic appears to have a small issue. When a new category is being created, you're trying to set the CategoryId of the objCategory based on the itemModel.CategoryId, which might be 0 or uninitialized. Instead, you should let the database generate the new CategoryId.

2. Quantity Type Assignment: In the SaveItem method, when assigning the objQnty.TypeId, it seems like the value is being assigned from objQnty.TypeId itself instead of the incoming itemModel.

3. Status Property: In your ItemViewModel, you have a property called Status, but in your JavaScript function, you're sending Active instead of Status. Ensure consistency between the property names.

4. Error Handling: Instead of rethrowing the exception using throw ex;, it's better to log the exception details or handle it appropriately, such as logging it to a file or returning a specific error message to the client for debugging.

5. Check AJAX Response: When handling AJAX errors, use msg.responseText instead of msg.responsetext for getting the error details.

Here's an adjusted version of your code considering these points:

public ActionResult SaveItem(ItemViewModel itemModel)
{
    var result = false;
    try
    {
        tblCategory objCategory = new tblCategory();
        if (itemModel.CategoryId > 0)
        {
            objCategory = objRestaurantDBEntities.tblCategories
                .FirstOrDefault(x => x.CategoryId == itemModel.CategoryId);
        }
        else
        {
            objCategory.CategoryName = itemModel.CategoryName;

            objRestaurantDBEntities.tblCategories.Add(objCategory);
            objRestaurantDBEntities.SaveChanges();

            // Assign the generated CategoryId after save
            itemModel.CategoryId = objCategory.CategoryId;
        }

        tblQuantity objQnty = new tblQuantity();
        if (itemModel.QuantityId > 0)
        {
            objQnty = objRestaurantDBEntities.tblQuantities
                .FirstOrDefault(x => x.QuantityId == itemModel.QuantityId);
        }
        objQnty.Quantity = itemModel.Quantity;
        objQnty.TypeId = itemModel.TypeId; // Assign the correct TypeId here

        if (itemModel.QuantityId <= 0)
        {
            objRestaurantDBEntities.tblQuantities.Add(objQnty);
        }

        tblItem objItem = new tblItem();
        if (itemModel.ItemId > 0)
        {
            objItem = objRestaurantDBEntities.tblItems
                .FirstOrDefault(x => x.ItemId == itemModel.ItemId);
        }
        objItem.PCode = itemModel.PCode;
        objItem.ItemName = itemModel.ItemName;
        objItem.ItemPrice = itemModel.ItemPrice;
        objItem.CategoryId = itemModel.CategoryId;
        objItem.Active = itemModel.Active;

        if (itemModel.ItemId <= 0)
        {
            objRestaurantDBEntities.tblItems.Add(objItem);
        }

        objRestaurantDBEntities.SaveChanges();
        result = true;
    }
    catch (Exception ex)
    {
        // Log the exception or handle it appropriately
        // Logging ex: Logger.Log(ex);
        // Return a meaningful error message
        return Json(new { success = false, message = "An error occurred while saving the item." });
    }

    return Json(new { success = result, message = "Item saved successfully." });
}

 

Please ensure that the itemModel in the JavaScript function matches the properties of your ItemViewModel. Also, verify the correctness of the data being sent from the front-end and received in the backend.

Additionally, make sure that the CategoryId and QuantityId values are correctly passed from the frontend when creating new items or quantities.